From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1hvJU6-0002fC-MD
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 12:47:58 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.89)
 (envelope-from <mol@pengutronix.de>) id 1hvJU6-0005JO-EH
 for ptxdist@pengutronix.de; Wed, 07 Aug 2019 12:47:58 +0200
Date: Wed, 7 Aug 2019 12:47:58 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20190807104758.kfxmrjxtvns4s4j2@pengutronix.de>
References: <20190723133502.20922-1-lapeddk@gmail.com>
 <20190723135311.21924-1-lapeddk@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20190723135311.21924-1-lapeddk@gmail.com>
Subject: Re: [ptxdist] [PATCH v2] systemd: Install configuration files for
 systemd-modules-load.service
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Tue, Jul 23, 2019 at 03:53:11PM +0200, Lars Pedersen wrote:
> Signed-off-by: Lars Pedersen <lapeddk@gmail.com>

No. This is very similar to SYSTEMD_UDEV_CUST_RULES and that turned out to
be a bad idea.
The problem with stuff like this is, that as soon as BSPs get a little bit
more complex, options like this start to conflict with packages that want
to install individual files from these directories.

And in most cases, there are other files that are installed anyways to use
the functionality provided by the modules that are loaded, so the config
file should be installed together with those anyways.

Michael

> ---
> v2: Added systemd prefix to title
>  rules/systemd.in   | 5 +++++
>  rules/systemd.make | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/rules/systemd.in b/rules/systemd.in
> index 5ce43b99c..c7f410cf7 100644
> --- a/rules/systemd.in
> +++ b/rules/systemd.in
> @@ -169,6 +169,11 @@ config SYSTEMD_UDEV_CUST_RULES
>  	  This will install the customized udev rules files from
>  	  'projectroot/usr/lib/udev/rules.d' into '/usr/lib/udev/rules.d'
>  
> +config SYSTEMD_MODULES_LOAD_D
> +	bool
> +	default n
> +		prompt "install kernel modules to load at boot"
> +
>  endmenu
>  
>  menu "persistent device node links  "
> diff --git a/rules/systemd.make b/rules/systemd.make
> index da375fd89..4bed33be5 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -452,6 +452,10 @@ ifdef PTXCONF_SYSTEMD_UDEV_CUST_RULES
>  	@$(call install_alternative_tree, systemd, 0, 0, /usr/lib/udev/rules.d)
>  endif
>  
> +ifdef PTXCONF_SYSTEMD_MODULES_LOAD_D
> +	@$(call install_alternative_tree, systemd, 0, 0, /usr/lib/modules-load.d)
> +endif
> +
>  	@$(call install_finish, systemd)
>  
>  	@$(call touch)
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de