From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>) id 1hnLDK-0006Tg-2j
 for ptxdist@pengutronix.de; Tue, 16 Jul 2019 13:01:42 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.89)
 (envelope-from <mol@pengutronix.de>) id 1hnLDJ-00046P-Q2
 for ptxdist@pengutronix.de; Tue, 16 Jul 2019 13:01:41 +0200
Date: Tue, 16 Jul 2019 13:01:41 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20190716110141.23qjy2lzmbjk5nvr@pengutronix.de>
References: <20190712130229.9288-1-s.trumtrar@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20190712130229.9288-1-s.trumtrar@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] rules: kernel: set CROSS_STRIP to kernel
 toolchain
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de

On Fri, Jul 12, 2019 at 03:02:29PM +0200, Steffen Trumtrar wrote:
> Overwrite the CROSS_STRIP environment variable.
> This is needed if the kernel is build with a different toolchain
> than the userspace. Stripping of kernel modules will fail otherwise,
> because the kernel will try to use strip from the userspace toolchain.

It's not that simple. How did you test this? I'm pretty sure that this will
fail if e.g. perf is enabled.

- target-specific variables are propagated to any prerequisites. This is
  not acceptable here
- If the strip is incompatible, then I'm sure that building the userspace
  tools from the kernel with the kernel toolchain is not correct either.

This requires a more complex solution.

Michael

> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  rules/kernel.make | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/kernel.make b/rules/kernel.make
> index 1e445559b490..874198c48e99 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -262,6 +262,8 @@ $(STATEDIR)/kernel.targetinstall.post: $(IMAGEDIR)/linuximage.lzo
>  endif
>  endif
>  
> +$(STATEDIR)/kernel.targetinstall.post: \
> +	CROSS_STRIP=$(KERNEL_CROSS_COMPILE)strip
>  $(STATEDIR)/kernel.targetinstall.post:
>  	@$(call targetinfo)
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de