[ptxdist] [PATCH] modemmanager: add dependency on libxslt as host-tool

[ptxdist] [PATCH] modemmanager: add dependency on libxslt as host-tool

[Ulrich Ölmann]

xsltproc is needed for header generation.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 rules/modemmanager.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/modemmanager.in b/rules/modemmanager.in
index 50f2d9c6af9d..4cf335efdda3 100644
--- a/rules/modemmanager.in
+++ b/rules/modemmanager.in
@@ -2,6 +2,7 @@
 
 menuconfig MODEMMANAGER
 	tristate
+	select HOST_LIBXSLT
 	select GLIB
 	select UDEV
 	select LIBGUDEV
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] modemmanager: add dependency on libxslt as host-tool

[Michael Olbrich]

On Sun, Jun 16, 2019 at 06:39:34PM +0200, Ulrich Ölmann wrote:
> xsltproc is needed for header generation.

No. The generated header is shipped with the tarball. This is only needed
if the input for this header is modified with a patch.

Btw, you can add this dependency locally without overwriting the whole
modemmanager.in file:

$ cat rules/modemmanager-fixup.in
## SECTION=networking

config MODEMMANAGER
	tristate
	# needed because of local patches
	select HOST_LIBXSLT

Konfig will then merge the two occurrences of the symbol. The original one
will make sure the option is enabled and this will add the extra
dependency.

Michael

> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  rules/modemmanager.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6af9d..4cf335efdda3 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig MODEMMANAGER
>  	tristate
> +	select HOST_LIBXSLT
>  	select GLIB
>  	select UDEV
>  	select LIBGUDEV
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] modemmanager: add dependency on libxslt as host-tool

[Ulrich Ölmann]

Hi Michael,

On Thu, Jun 20 2019 at 12:11 +0200, Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> On Sun, Jun 16, 2019 at 06:39:34PM +0200, Ulrich Ölmann wrote:
>> xsltproc is needed for header generation.
>
> No. The generated header is shipped with the tarball. This is only needed
> if the input for this header is modified with a patch.

you are right, indeed I have put patches on top of the tarball.
Thanks for clarifying!

> Btw, you can add this dependency locally without overwriting the whole
> modemmanager.in file:
>
> $ cat rules/modemmanager-fixup.in
> ## SECTION=networking
>
> config MODEMMANAGER
> 	tristate
> 	# needed because of local patches
> 	select HOST_LIBXSLT
>
> Konfig will then merge the two occurrences of the symbol. The original one
> will make sure the option is enabled and this will add the extra
> dependency.

Oh, I was unaware of that up to now - very good to know this!

Best regards
Ulrich

> Michael
>
>> 
>> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
>> ---
>>  rules/modemmanager.in | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
>> index 50f2d9c6af9d..4cf335efdda3 100644
>> --- a/rules/modemmanager.in
>> +++ b/rules/modemmanager.in
>> @@ -2,6 +2,7 @@
>>  
>>  menuconfig MODEMMANAGER
>>  	tristate
>> +	select HOST_LIBXSLT
>>  	select GLIB
>>  	select UDEV
>>  	select LIBGUDEV
>> -- 
>> 2.20.1
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de