mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] modemmanager: add dependency on libxslt as host-tool
Date: Thu, 20 Jun 2019 12:11:34 +0200	[thread overview]
Message-ID: <20190620101134.3dz2lp6eruokw2vt@pengutronix.de> (raw)
In-Reply-To: <20190616163934.705-1-u.oelmann@pengutronix.de>

On Sun, Jun 16, 2019 at 06:39:34PM +0200, Ulrich Ölmann wrote:
> xsltproc is needed for header generation.

No. The generated header is shipped with the tarball. This is only needed
if the input for this header is modified with a patch.

Btw, you can add this dependency locally without overwriting the whole
modemmanager.in file:

$ cat rules/modemmanager-fixup.in
## SECTION=networking

config MODEMMANAGER
	tristate
	# needed because of local patches
	select HOST_LIBXSLT

Konfig will then merge the two occurrences of the symbol. The original one
will make sure the option is enabled and this will add the extra
dependency.

Michael

> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  rules/modemmanager.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/modemmanager.in b/rules/modemmanager.in
> index 50f2d9c6af9d..4cf335efdda3 100644
> --- a/rules/modemmanager.in
> +++ b/rules/modemmanager.in
> @@ -2,6 +2,7 @@
>  
>  menuconfig MODEMMANAGER
>  	tristate
> +	select HOST_LIBXSLT
>  	select GLIB
>  	select UDEV
>  	select LIBGUDEV
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2019-06-20 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-16 16:39 Ulrich Ölmann
2019-06-20 10:11 ` Michael Olbrich [this message]
2019-06-20 12:41   ` Ulrich Ölmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620101134.3dz2lp6eruokw2vt@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=u.oelmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox