Re: [ptxdist] [PATCH 2/2] host-openocd: add initial support

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jun 14, 2019 at 11:41:34AM +0200, Michael Olbrich wrote:
> On Fri, Jun 14, 2019 at 11:15:28AM +0200, Michael Grzeschik wrote:
> > On Fri, Jun 14, 2019 at 09:18:23AM +0200, Michael Olbrich wrote:
> > > On Fri, Jun 07, 2019 at 12:19:49AM +0200, Michael Grzeschik wrote:
> > > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > > > ---
> > > >  patches/openocd-af952850/autogen.sh |  3 +
> > > >  rules/host-openocd.in               | 12 ++++
> > > >  rules/host-openocd.make             | 89 +++++++++++++++++++++++++++++
> > > >  3 files changed, 104 insertions(+)
> > > >  create mode 100755 patches/openocd-af952850/autogen.sh
> > > >  create mode 100644 rules/host-openocd.in
> > > >  create mode 100644 rules/host-openocd.make
> > > > 
> > > > diff --git a/patches/openocd-af952850/autogen.sh b/patches/openocd-af952850/autogen.sh
> > > > new file mode 100755
> > > > index 000000000..7d344d32f
> > > > --- /dev/null
> > > > +++ b/patches/openocd-af952850/autogen.sh
> > > > @@ -0,0 +1,3 @@
> > > > +#!/bin/bash
> > > > +
> > > > +exec ./bootstrap
> > > > diff --git a/rules/host-openocd.in b/rules/host-openocd.in
> > > > new file mode 100644
> > > > index 000000000..8c863598e
> > > > --- /dev/null
> > > > +++ b/rules/host-openocd.in
> > > > @@ -0,0 +1,12 @@
> > > > +## SECTION=hosttools
> > > > +
> > > > +menuconfig HOST_OPENOCD
> > > > +	tristate
> > > > +	prompt "openocd"
> > > > +	select HOST_LIBUSB
> > > > +	select HOST_JIMTCL
> > > > +	select HOST_LIBFTDI1
> > > > +	help
> > > > +	  The "Open On-Chip Debugger" provides JTAG/SWD access from GDB
> > > > +	  (or directly with TCL scripts) to processors with ARM and MIPS
> > > > +	  based cores.
> > > > diff --git a/rules/host-openocd.make b/rules/host-openocd.make
> > > > new file mode 100644
> > > > index 000000000..8a741856e
> > > > --- /dev/null
> > > > +++ b/rules/host-openocd.make
> > > > @@ -0,0 +1,89 @@
> > > > +# -*-makefile-*-
> > > > +#
> > > > +# Copyright (C) 2013 by Michael Grzeschik <mgr@pengutronix.de>
> > > > +#
> > > > +# See CREDITS for details about who has contributed to this project.
> > > > +#
> > > > +# For further information about the PTXdist project and license conditions
> > > > +# see the README file.
> > > > +#
> > > > +
> > > > +#
> > > > +# We provide this package
> > > > +#
> > > > +HOST_PACKAGES-$(PTXCONF_HOST_OPENOCD) += host-openocd
> > > > +
> > > > +#
> > > > +# Paths and names
> > > > +#
> > > > +HOST_OPENOCD_VERSION	:= af952850
> > > > +HOST_OPENOCD_MD5	:= fa6841d4e4e76d1626406a99d5b1851d
> > > > +HOST_OPENOCD		:= openocd-$(HOST_OPENOCD_VERSION)
> > > > +HOST_OPENOCD_SUFFIX	:= tar.bz2
> > > > +HOST_OPENOCD_URL	:= git://git.code.sf.net/p/openocd/code;tag=$(HOST_OPENOCD_VERSION)
> > > > +HOST_OPENOCD_SOURCE	:= $(SRCDIR)/$(HOST_OPENOCD).$(HOST_OPENOCD_SUFFIX)
> > > > +HOST_OPENOCD_DIR	:= $(HOST_BUILDDIR)/$(HOST_OPENOCD)
> > > > +
> > > > +# ----------------------------------------------------------------------------
> > > > +# Prepare
> > > > +# ----------------------------------------------------------------------------
> > > > +
> > > > +#
> > > > +# autoconf
> > > > +#
> > > > +HOST_OPENOCD_CONF_TOOL	:= autoconf
> > > > +HOST_OPENOCD_CONF_ENV	:= \
> > > > +		CCACHE=none \
> > > 
> > > Indent with on tab.
> > 
> > Right, will fix.
> > > 
> > > > +		LDFLAGS="-L$(PTXDIST_SYSROOT_HOST)/usr/lib" \
> > > > +		CFLAGS="-I$(PTXDIST_SYSROOT_HOST)/usr/include"
> > > 
> > > The flags should be added via HOST_OPENOCD_LDFLAGS / HOST_OPENOCD_CPPFLAGS.
> > > However, why do you need sysroot-host/usr/...? These directories should be
> > > empty.
> > 
> > Why should they be empty? Aren't there all host packages installed? This
> > is needed because otherwise openocd won't find libjim and headers to
> > compile and link against. I did not see any other way, then setting
> > these variables.
> 
> It should be (PTXDIST_SYSROOT_HOST)/lib (without /usr). I think host-jimtcl
> needs to be fixed. I'm not sure why the prefix is /usr there. I'll run a
> build-test to see if it works without /.

I've done this in master. I've not seen any issues with it. So the flags
can be removed now.

Michael

> > > 
> > > > +HOST_OPENOCD_CONF_OPT	:= \
> > > > +		$(HOST_AUTOCONF) \
> > > 
> > > One tab.
> > 
> > will fix
> > 
> > > Michael
> > > 
> > > > +		--enable-shared \
> > > > +		--disable-static \
> > > > +		--disable-werror \
> > > > +		--disable-internal-jimtcl \
> > > > +		--disable-internal-libjaylink \
> > > > +		--enable-dummy \
> > > > +		--enable-ftdi \
> > > > +		--enable-stlink \
> > > > +		--disable-ti-icdi \
> > > > +		--disable-ulink \
> > > > +		--disable-usb-blaster-2 \
> > > > +		--disable-ft232r \
> > > > +		--disable-vsllink \
> > > > +		--disable-xds110 \
> > > > +		--disable-osbdm \
> > > > +		--disable-opendous \
> > > > +		--disable-aice \
> > > > +		--disable-usbprog \
> > > > +		--disable-rlink \
> > > > +		--disable-armjtagew \
> > > > +		--disable-cmsis-dap \
> > > > +		--disable-kitprog \
> > > > +		--disable-usb_blaster \
> > > > +		--disable-presto\
> > > > +		--disable-openjtag \
> > > > +		--disable-jlink \
> > > > +		--disable-parport \
> > > > +		--disable-parport-ppdev \
> > > > +		--disable-parport-giveio \
> > > > +		--disable-jtag_vpi \
> > > > +		--disable-amtjtagaccel \
> > > > +		--disable-zy1000 \
> > > > +		--disable-zy1000-master \
> > > > +		--disable-ioutil \
> > > > +		--disable-ep93xx \
> > > > +		--disable-at91rm9200 \
> > > > +		--disable-bcm2835gpio \
> > > > +		--disable-imx_gpio \
> > > > +		--disable-gw16012 \
> > > > +		--disable-oocd_trace \
> > > > +		--disable-buspirate \
> > > > +		--disable-sysfsgpio \
> > > > +		--disable-minidriver-dummy \
> > > > +		--disable-target-64 \
> > > > +		--disable-remote-bitbang \
> > > > +		--disable-doxygen-pdf \
> > > > +		--disable-doxygen-html
> > > > +
> > > > +# vim: syntax=make
> > > > -- 
> > > > 2.20.1
> > > > 
> > > > 
> > > > _______________________________________________
> > > > ptxdist mailing list
> > > > ptxdist@pengutronix.de
> > > 
> > > -- 
> > > Pengutronix e.K.                           |                             |
> > > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 
> 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de