Re: [ptxdist] [PATCH 17/20] minicoredumper: adapt package's '/var/cache' requirements

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jun 05, 2019 at 02:54:18PM +0200, Juergen Borleis wrote:
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
>  rules/minicoredumper.in | 4 ++++
>  rules/rootfs.in         | 7 +++++++
>  rules/rootfs.make       | 3 +++
>  3 files changed, 14 insertions(+)
> 
> diff --git a/rules/minicoredumper.in b/rules/minicoredumper.in
> index cc8008d1c..9fc3b63ed 100644
> --- a/rules/minicoredumper.in
> +++ b/rules/minicoredumper.in
> @@ -5,6 +5,7 @@ config MINICOREDUMPER
>  	prompt "minicoredumper"
>  	select LIBELF
>  	select JSON_C
> +	select ROOTFS_VAR_CRASH	if RUNTIME
>  	help
>  	  The minicoredumper project provides a program that handles the
>  	  creation of core dump files on Linux. It can produce much smaller
> @@ -19,3 +20,6 @@ config MINICOREDUMPER
>  	  	echo '|/usr/sbin/minicoredumper %P %u %g %s %t %h %e' > /proc/sys/kernel/core_pattern
>  
>  	  by hand to actually make use of it.
> +
> +	  Note: on a read-only root filesystem this package still requires a
> +	  writable '/var/crash'.
> diff --git a/rules/rootfs.in b/rules/rootfs.in
> index 3ea4bde60..2ec7104c2 100644
> --- a/rules/rootfs.in
> +++ b/rules/rootfs.in
> @@ -226,6 +226,13 @@ config ROOTFS_VAR_CACHE
>  	  This directory is intended for application cache data. Say 'y' here
>  	  to ensure a '/var/cache' directory is available at run-time.
>  
> +config ROOTFS_VAR_CRASH
> +	bool
> +	prompt "/var/crash"
> +	help
> +	  This directory is intended for core dumps. Say 'y' here to ensure a
> +	  '/var/crash' directory is available at run-time.
> +

No, this is not LSB or otherwise used by different packages. minicoredumper
should just create it directly.

Michael

>  config ROOTFS_VAR_SPOOL
>  	bool
>  	prompt "/var/spool"
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 8183d0288..a1002cfcd 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -112,6 +112,9 @@ endif
>  ifdef PTXCONF_ROOTFS_VAR_CACHE
>  	@$(call install_copy, rootfs, 0, 0, 0755, /var/cache)
>  endif
> +ifdef PTXCONF_ROOTFS_VAR_CRASH
> +	@$(call install_copy, rootfs, 0, 0, 0755, /var/crash)
> +endif
>  ifdef PTXCONF_ROOTFS_VAR_SPOOL
>  	@$(call install_copy, rootfs, 0, 0, 0755, /var/spool)
>  endif
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de