mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH v1 2/2] pre/barebox: barebox-opts doesn't need any parameters
Date: Wed,  5 Jun 2019 16:51:40 +0200	[thread overview]
Message-ID: <20190605145140.757-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20190605145140.757-1-rhi@pengutronix.de>

$(1) is never used in the barebox/opts macro, so barebox-opts doesn't
need to pass it around.

Also adjust the package template accordingly.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/pre/barebox.make                | 2 +-
 rules/templates/template-barebox-make | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/pre/barebox.make b/rules/pre/barebox.make
index 7875442cf935..bc7fe4340f87 100644
--- a/rules/pre/barebox.make
+++ b/rules/pre/barebox.make
@@ -12,17 +12,17 @@
 barebox/opts = \
 	$(PARALLELMFLAGS) \
 	V=$(PTXDIST_VERBOSE) \
 	HOSTCC=$(HOSTCC) \
 	ARCH=$(PTXCONF_BAREBOX_ARCH_STRING) \
 	CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE)
 
 barebox-opts = \
-	$(call barebox/opts,$(strip $(1)))
+	$(call barebox/opts)
 
 barebox/url = \
 	http://www.barebox.org/download/barebox-$($(1)_VERSION).$($(1)_SUFFIX)
 
 barebox-url = \
 	$(call barebox/url,$(strip $(1)))
 
 # vim: syntax=make
diff --git a/rules/templates/template-barebox-make b/rules/templates/template-barebox-make
index 7493b849b6ab..4ada3c20bf00 100644
--- a/rules/templates/template-barebox-make
+++ b/rules/templates/template-barebox-make
@@ -36,17 +36,17 @@ BAREBOX_@PACKAGE@_PATH := PATH=$(HOST_PATH)
 BAREBOX_@PACKAGE@_WRAPPER_BLACKLIST := \
 	TARGET_HARDEN_STACKCLASH \
 	TARGET_HARDEN_RELRO \
 	TARGET_HARDEN_BINDNOW \
 	TARGET_HARDEN_PIE \
 	TARGET_DEBUG \
 	TARGET_BUILD_ID
 
-BAREBOX_@PACKAGE@_CONF_OPT := $(call barebox-opts, BAREBOX_@PACKAGE@)
+BAREBOX_@PACKAGE@_CONF_OPT := $(call barebox-opts)
 BAREBOX_@PACKAGE@_MAKE_OPT := $(BAREBOX_@PACKAGE@_CONF_OPT)
 
 BAREBOX_@PACKAGE@_IMAGES := @image@
 BAREBOX_@PACKAGE@_IMAGES := $(addprefix $(BAREBOX_@PACKAGE@_DIR)/,$(BAREBOX_@PACKAGE@_IMAGES))
 
 ifdef PTXCONF_BAREBOX_@PACKAGE@
 $(BAREBOX_@PACKAGE@_CONFIG):
 	@echo
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2019-06-05 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 14:51 [ptxdist] [PATCH v1 1/2] pre/barebox: only use <PKG>_VERSION to build the URL Roland Hieber
2019-06-05 14:51 ` Roland Hieber [this message]
2019-06-14  7:14   ` [ptxdist] [PATCH v1 2/2] pre/barebox: barebox-opts doesn't need any parameters Michael Olbrich
2019-06-14  8:27     ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605145140.757-2-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox