Re: [ptxdist] [PATCH] rauc: select on-target tools depending on bootloader

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, May 31, 2019 at 07:01:58PM +0200, Andreas Pretzsch wrote:
> RAUC relies on tools on the target to interact with the bootloader.
> As the bootloader selection is not part of ptxconfig, but platformconfig,
> have the user select the bootloader used on the target.
> Based on this choice, auto-select the appropriate packages:
>   barebox: dt-utils (barebox-state)
>   U-Boot: u-boot-tools (fw_printenv, fw_setenv)
>   GRUB: none (grub-editenv already part of GRUB package)
>   EFI: efibootmgr (efibootmgr)
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
>  rules/rauc.in | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/rules/rauc.in b/rules/rauc.in
> index 213a1211e..62977a0cb 100644
> --- a/rules/rauc.in
> +++ b/rules/rauc.in
> @@ -7,6 +7,9 @@ menuconfig RAUC
>  	select GLIB
>  	select GLIB_LIBMOUNT
>  	select HOST_GLIB
> +	select DT_UTILS		if RAUC_BAREBOX
> +	select U_BOOT_TOOLS	if RAUC_U_BOOT
> +	select EFIBOOTMGR	if RAUC_EFI

These are runtime dependencies, so:

	select xxx		if RAUC_xxxx && RUNTIME

Michael

>  	select BUSYBOX_FEATURE_TAR_LONG_OPTIONS	if BUSYBOX_TAR
>  	select BUSYBOX_FEATURE_TAR_AUTODETECT 	if BUSYBOX_TAR
>  	select BUSYBOX_FEATURE_SEAMLESS_XZ 		if BUSYBOX_TAR
> @@ -19,6 +22,18 @@ menuconfig RAUC
>  
>  if RAUC
>  
> +choice
> +	prompt "Bootloader used on target"
> +	config RAUC_BAREBOX
> +		bool "barebox"
> +	config RAUC_U_BOOT
> +		bool "U-Boot "
> +	config RAUC_GRUB
> +		bool "GRUB   "
> +	config RAUC_EFI
> +		bool "EFI    "
> +endchoice
> +
>  config RAUC_SERVICE
>  	bool
>  	prompt "Enable service (D-Bus) support"
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de