Re: [ptxdist] [PATCH v2] ptxd_lib_dgen: warn if host or image packages have targetinstall stage

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Apr 23, 2019 at 05:39:24PM +0200, Roland Hieber wrote:
> On Fri, Apr 12, 2019 at 09:10:14AM +0200, Michael Olbrich wrote:
> > On Mon, Apr 08, 2019 at 11:39:50AM +0200, Roland Hieber wrote:
> > > This point came up multiple times in the past and the special handling
> > > of targetinstall stages lead to confusion when trying to depend on image
> > > packages. Document it to prevent further confusion in that matter, and
> > > warn the user if such a make target exists.
> > > 
> > > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > > ---
> [...]
> > > diff --git a/scripts/lib/ptxd_lib_dgen.awk b/scripts/lib/ptxd_lib_dgen.awk
> > > index f7143c02885f..4d97cbd2fa28 100644
> > > --- a/scripts/lib/ptxd_lib_dgen.awk
> > > +++ b/scripts/lib/ptxd_lib_dgen.awk
> > > @@ -94,6 +94,16 @@ function dump_file(src, dst, tmp) {
> > >  }
> > >  
> > >  
> > > +#
> > > +# warn user if an image-* or host-* package contains a targetinstall rule
> > > +# which will not be executed
> > > +#
> > > +match($0, /\$\(STATEDIR\)\/((image-.*|host-.*)\.targetinstall(.post)?):/, m) {

Check cross- as well.

> > Please use the same syntax as everywhere else in the file. It's complicated
> > enough.
> 
> I don't fully understand what you meant by this. If it's about using
> match(), I was using that explicitely here so I'm able to use m[1] in
> the lines below without having to go through another gensub() which
> would effectively use the same regex again.

I know, but the extra gensub is what we do elsewhere in the file as well.
I'd like to use the same pattern everywhere to make this more readable.
Feel free to send a patch to convert the other places to use match as well.
Then I'll accept it here too.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de