Re: [ptxdist] [PATCH 1/2] ptxdist: introduce the "clean target" subcommand

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, May 17, 2019 at 12:12:33PM +0200, Roland Hieber wrote:
> From: Roland Hieber <rhi@pengutronix.de>
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  bin/ptxdist           | 17 +++++++++++++++++
>  doc/ref_parameter.inc |  6 ++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index f52a668d3..a7be5cb3e 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -963,6 +963,7 @@ Clean Actions:
>  
>    clean				cleanup build-host and build-cross dirs
>    clean root			cleanup root directory for target
> +  clean target			cleanup all target packages
>    distclean			cleanup everything
>  
>  Misc:
> @@ -1059,6 +1060,22 @@ clean() {
>  		return
>  	fi
>  
> +	# we want to clean all target packages
> +	if [ "${1}" = "target" ]; then
> +		if [ ! -n "${PTXDIST_FORCE}${PTXDIST_QUIET}${PTXCONF_SETUP_DIRECT_CLEAN}" ]; then
> +			read -e -p "really clean all target packages? [y/N] " r
> +			case "${r}" in
> +				y|Y) ;;
> +				*) exit 1 ;;
> +			esac
> +		fi
> +		check_premake_compiler &&
> +		pkgs=($(ptxd_make "/print-PACKAGES /print-EXTRA_PACKAGES /print-LAZY_PACKAGES")) &&
> +		ptxd_make_log "${pkgs[@]/%/_clean}" &&
> +		clean root

Maybe move this section above the 'root' part. Then we can do a
'fall-through' instead of calling 'clean' recursively.

Michael

> +		return
> +	fi
> +
>  	# we want to clean a single package
>  	if [ -n "${1}" ]; then
>  		check_if_selected "${@}" &&
> diff --git a/doc/ref_parameter.inc b/doc/ref_parameter.inc
> index 0b11563c9..4aecb0471 100644
> --- a/doc/ref_parameter.inc
> +++ b/doc/ref_parameter.inc
> @@ -162,6 +162,12 @@ Clean Actions
>    The ``clean root`` and ``go`` action is useful if the
>    *targetinstall* stage for all packages should run again.
>  
> +``clean target``
> +  this action will call the ``clean`` action for each target package,
> +  and also clean the root file system afterwards.
> +  This can be useful if you want to rebuild the target file system from
> +  scratch, without throwing away the already built host and cross packages.
> +
>  ``clean <package>``
>    this action will only clean the dedicated
>    <package>. It will remove its build directory and all installed files
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de