Re: [ptxdist] [PATCH 2/2] m4: make it build with ICECC again

[Roland Hieber <rhi@pengutronix.de>]

On Fri, Apr 26, 2019 at 09:08:55PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> I brought this up on IRC yesterday, I just tried to compile DistroKit
> master on Debian 10 (buster) on an amd64 host, with some Debian 9
> (stretch) icecc nodes on the local net.
> 
> On Fri, Apr 26, 2019 at 08:42:53PM +0200, Roland Hieber wrote:
> > On Fri, Apr 26, 2019 at 07:49:44PM +0200, Roland Hieber wrote:
> > > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > > ---
> > >  ...nt-warnings-when-building-with-ICECC.patch | 39 +++++++++++++++++++
> > >  patches/m4-1.4.18/series                      |  3 +-
> > >  2 files changed, 41 insertions(+), 1 deletion(-)
> > >  create mode 100644 patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > > 
> > > diff --git a/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > > new file mode 100644
> > > index 000000000..979106910
> > > --- /dev/null
> > > +++ b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > > @@ -0,0 +1,39 @@
> > > +From: Roland Hieber <rohieb@rohieb.name>
> > > +Date: Fri, 26 Apr 2019 19:11:19 +0200
> > > +Subject: [PATCH] HACK: prevent warnings when building with ICECC
> > > +
> > > +If ICECC is enabled, -fdirectives-only is apparently always used, which
> > > +leads to errors like
> > > +
> > > +    verify.h:161:31: error: __COUNTER__ expanded inside directive with -fdirectives-only
> > 
> > Strange, I see the same issue with glib too, and libtasn1, and
> > host-gettext, and gdbserver. All of them seem to have forked the same
> > verify.h... :) But I don't think patching all of them is the right way
> > to approach this.
> 
> I only saw the issue with host-m4.

Well, host-m4 is probably the first of those packages that gets compiled,
because autotools depend on m4, and therefore most other packages :)

> > Debian testing/unstable, ptxdist master, ICECC 1.2.0, host-gcc 8.2.0,
> > but I also saw this with an old host-gcc 5.4.0, so I guess it's
> > independent of the host compiler version.
> 
> Could the difference be in the icecc version on the host? Debian 9 has
> ICECC 1.0.1 and does not fail. Debian 10 has ICECC 1.2.0 and fails.

Indeed, there is this commit between ICECC 1.1 and 1.2 that adds
-fdirectives-only to the gcc command line:

https://github.com/icecc/icecream/commit/7ab429b5f3405ec8451c31f80573658c8818b972

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de