From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Fri, 26 Apr 2019 21:08:55 +0200 From: Alexander Dahl Message-ID: <20190426190855.iuw6bpc7faj5lwqd@falbala.home.lespocky.de> References: <20190426174944.20947-1-rohieb@rohieb.name> <20190426174944.20947-2-rohieb@rohieb.name> <20190426184253.ex43p36lh577v2yo@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20190426184253.ex43p36lh577v2yo@pengutronix.de> Subject: Re: [ptxdist] [PATCH 2/2] m4: make it build with ICECC again List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0480254186==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Roland Hieber Cc: Alexander Dahl , ptxdist@pengutronix.de --===============0480254186== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="job5bt5kuq5lulxg" Content-Disposition: inline --job5bt5kuq5lulxg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hei hei, I brought this up on IRC yesterday, I just tried to compile DistroKit master on Debian 10 (buster) on an amd64 host, with some Debian 9 (stretch) icecc nodes on the local net. On Fri, Apr 26, 2019 at 08:42:53PM +0200, Roland Hieber wrote: > On Fri, Apr 26, 2019 at 07:49:44PM +0200, Roland Hieber wrote: > > Signed-off-by: Roland Hieber > > --- > > ...nt-warnings-when-building-with-ICECC.patch | 39 +++++++++++++++++++ > > patches/m4-1.4.18/series | 3 +- > > 2 files changed, 41 insertions(+), 1 deletion(-) > > create mode 100644 patches/m4-1.4.18/0002-HACK-prevent-warnings-when-b= uilding-with-ICECC.patch > >=20 > > diff --git a/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building= -with-ICECC.patch b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-build= ing-with-ICECC.patch > > new file mode 100644 > > index 000000000..979106910 > > --- /dev/null > > +++ b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-I= CECC.patch > > @@ -0,0 +1,39 @@ > > +From: Roland Hieber > > +Date: Fri, 26 Apr 2019 19:11:19 +0200 > > +Subject: [PATCH] HACK: prevent warnings when building with ICECC > > + > > +If ICECC is enabled, -fdirectives-only is apparently always used, which > > +leads to errors like > > + > > + verify.h:161:31: error: __COUNTER__ expanded inside directive with= -fdirectives-only >=20 > Strange, I see the same issue with glib too, and libtasn1, and > host-gettext, and gdbserver. All of them seem to have forked the same > verify.h... :) But I don't think patching all of them is the right way > to approach this. I only saw the issue with host-m4. > Debian testing/unstable, ptxdist master, ICECC 1.2.0, host-gcc 8.2.0, > but I also saw this with an old host-gcc 5.4.0, so I guess it's > independent of the host compiler version. Could the difference be in the icecc version on the host? Debian 9 has ICECC 1.0.1 and does not fail. Debian 10 has ICECC 1.2.0 and fails. Greets Alex --=20 /"\ ASCII RIBBON | =BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --job5bt5kuq5lulxg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAlzDV0IACgkQNK3NAHIh XMbM+A//aBFVNTEB996uRuM51j2/EB4/JvLRfx7/eV0Voz9g+3hTmVXzKAxDcDuV G0bbQSAef+eugACcUyVzpggVsGHen3mRmEhjYP+KwWCQkdZAdOr+1jhcnId3kdV/ 0f3PUsVKVk0DiDN4lMi0TFk1A84X323W5ub9y5NNKjgpbA/e3dpFp9QoJ9pBVUx1 R2OZ/iLWppPMMqeVSCVMZRMIelrehgftzSsw2gRJnYufxmqRNu11D21zxFaQdNlG /qo63Qb9MmYORPnX+MzFZdCbj6uuuTARrJDqMii2gg1wgIMpH8dzjcyxlh4snMrh qnO94VkWhj+A9/cEPJ8T83NNTjaZ4OcTTCzQuJJNkmk3RK6yZTWa+INFTMZ0S/BW GpoyskmgXf5xP3FrpiBYw4buMOtUrG+oYGfKEEbdk/nfCPlBsIj6+1zJ1QCWANkU Px65DGGWm9aOmdNWYqIWQ63L+Z+JQIkE5mbElA5638xzWjptJDtvtSkmgxopoMOO WedtrK8+FAOtIgs5IdUTqpkeJoY2iFZnTkkBzhk2JwUeHJxTQyP1oL/vYU+j0gOp pRLPSCsDgrpzp6WdxzzlGrSGF8L/UFwctDlaJw+yH42Ux/tkC/JkwNqlYCdetMj7 JVWsuzf1w4zT1ZM/UO1NUPVFRq+pUW5FHX9tAujsBWvbRAMeqJ0= =5NXZ -----END PGP SIGNATURE----- --job5bt5kuq5lulxg-- --===============0480254186== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0480254186==--