Re: [ptxdist] [PATCH 2/2] m4: make it build with ICECC again

[Alexander Dahl <post@lespocky.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2327 bytes --]

Hei hei,

I brought this up on IRC yesterday, I just tried to compile DistroKit
master on Debian 10 (buster) on an amd64 host, with some Debian 9
(stretch) icecc nodes on the local net.

On Fri, Apr 26, 2019 at 08:42:53PM +0200, Roland Hieber wrote:
> On Fri, Apr 26, 2019 at 07:49:44PM +0200, Roland Hieber wrote:
> > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > ---
> >  ...nt-warnings-when-building-with-ICECC.patch | 39 +++++++++++++++++++
> >  patches/m4-1.4.18/series                      |  3 +-
> >  2 files changed, 41 insertions(+), 1 deletion(-)
> >  create mode 100644 patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > 
> > diff --git a/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > new file mode 100644
> > index 000000000..979106910
> > --- /dev/null
> > +++ b/patches/m4-1.4.18/0002-HACK-prevent-warnings-when-building-with-ICECC.patch
> > @@ -0,0 +1,39 @@
> > +From: Roland Hieber <rohieb@rohieb.name>
> > +Date: Fri, 26 Apr 2019 19:11:19 +0200
> > +Subject: [PATCH] HACK: prevent warnings when building with ICECC
> > +
> > +If ICECC is enabled, -fdirectives-only is apparently always used, which
> > +leads to errors like
> > +
> > +    verify.h:161:31: error: __COUNTER__ expanded inside directive with -fdirectives-only
> 
> Strange, I see the same issue with glib too, and libtasn1, and
> host-gettext, and gdbserver. All of them seem to have forked the same
> verify.h... :) But I don't think patching all of them is the right way
> to approach this.

I only saw the issue with host-m4.

> Debian testing/unstable, ptxdist master, ICECC 1.2.0, host-gcc 8.2.0,
> but I also saw this with an old host-gcc 5.4.0, so I guess it's
> independent of the host compiler version.

Could the difference be in the icecc version on the host? Debian 9 has
ICECC 1.0.1 and does not fail. Debian 10 has ICECC 1.2.0 and fails.

Greets
Alex

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de