Re: [ptxdist] [PATCH v2 1/5] ptxdist: add host autotools macro archive for tpm2

[Roland Hieber <rhi@pengutronix.de>]

Hi Thorsten,

On Fri, Mar 15, 2019 at 04:09:02PM +0100, Thorsten Scherer wrote:
> thank you for your explanations.  I will follow them in the next
> version of the patchset.
> 
> Maybe you could help me with some additional questions.
> 
> - As this patchset is a little old, would it be better to keep the
>   versions of the libraries as they are and bump them after the
>   patchset got applied (if it will be) or should they be bumped with the
>   next set of patches.
> 
> - Would it make sense to break the patchset up into single patches?

In general I think it's better to make smaller, atomic commits, than
larger commits that do too much at once, and which are then harder to
review. So I would tend tomake one commit for the version bump and then
the other things.

 - Roland

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de