Re: [ptxdist] [ptxdist-commit] [public/ptxdist] 02/03: template-src-linux-driver-make: modernise

Re: [ptxdist] [ptxdist-commit] [public/ptxdist] 02/03: template-src-linux-driver-make: modernise

[Roland Hieber]

Hi Michael,

On Fri, Mar 08, 2019 at 04:31:29PM +0100, Michael Olbrich via Gitolite wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> pengutronix.michael.olbrich pushed a commit to branch master
> in repository ptxdist.
> 
> commit dd6b6d23044fb4787a8a2afdb7cda474ea7e372c
> Author: Michael Olbrich <m.olbrich@pengutronix.de>
> AuthorDate: Fri Mar 8 11:25:16 2019 +0100
> 
>     template-src-linux-driver-make: modernise
>     
>     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>  rules/templates/template-src-linux-driver-make | 29 +++++++-------------------
>  1 file changed, 7 insertions(+), 22 deletions(-)
> 
[...]

> @@ -60,18 +56,7 @@ $(STATEDIR)/@package@.install:
>  
>  $(STATEDIR)/@package@.targetinstall:
>  	@$(call targetinfo)
> -	$(KERNEL_PATH) $(KERNEL_ENV) $(MAKE) $(KERNEL_MAKE_OPT) \
> -		-C $(KERNEL_DIR) \
> -		M=$(@PACKAGE@_DIR) \
> -		modules_install
> +	@$(call compile, CB1FPGA, $(CB1FPGA_MAKE_OPT)_install)

This looks like a missing @PACKAGE@ replacement?

 - Roland

>  	@$(call touch)
>  
> -# ----------------------------------------------------------------------------
> -# Clean
> -# ----------------------------------------------------------------------------
> -
> -#$(STATEDIR)/@package@.clean:
> -#	@$(call targetinfo)
> -#	@$(call clean_pkg, @PACKAGE@)
> -
>  # vim: syntax=make
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> 
> _______________________________________________
> ptxdist-commit mailing list
> ptxdist-commit@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [ptxdist-commit] [public/ptxdist] 02/03: template-src-linux-driver-make: modernise

[Michael Olbrich via Gitolite]

On Sun, Mar 10, 2019 at 09:10:54PM +0100, Roland Hieber wrote:
> On Fri, Mar 08, 2019 at 04:31:29PM +0100, Michael Olbrich via Gitolite wrote:
> > This is an automated email from the git hooks/post-receive script.
> > 
> > pengutronix.michael.olbrich pushed a commit to branch master
> > in repository ptxdist.
> > 
> > commit dd6b6d23044fb4787a8a2afdb7cda474ea7e372c
> > Author: Michael Olbrich <m.olbrich@pengutronix.de>
> > AuthorDate: Fri Mar 8 11:25:16 2019 +0100
> > 
> >     template-src-linux-driver-make: modernise
> >     
> >     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > ---
> >  rules/templates/template-src-linux-driver-make | 29 +++++++-------------------
> >  1 file changed, 7 insertions(+), 22 deletions(-)
> > 
> [...]
> 
> > @@ -60,18 +56,7 @@ $(STATEDIR)/@package@.install:
> >  
> >  $(STATEDIR)/@package@.targetinstall:
> >  	@$(call targetinfo)
> > -	$(KERNEL_PATH) $(KERNEL_ENV) $(MAKE) $(KERNEL_MAKE_OPT) \
> > -		-C $(KERNEL_DIR) \
> > -		M=$(@PACKAGE@_DIR) \
> > -		modules_install
> > +	@$(call compile, CB1FPGA, $(CB1FPGA_MAKE_OPT)_install)
> 
> This looks like a missing @PACKAGE@ replacement?

Right. Fixed in master.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de