* [ptxdist] [PATCH] poco: make poquito configurable
@ 2019-03-05 10:49 Baeuerle, Florian
2019-03-07 11:18 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Baeuerle, Florian @ 2019-03-05 10:49 UTC (permalink / raw)
To: ptxdist
This used to be the default configuration, saving a few kbytes on the
library. The features this omits might weigh heavier than a few kbytes,
so make this configurable.
Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
---
rules/poco.in | 6 ++++++
rules/poco.make | 5 ++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/rules/poco.in b/rules/poco.in
index 6f5afd804..7bd859a14 100644
--- a/rules/poco.in
+++ b/rules/poco.in
@@ -19,6 +19,12 @@ menuconfig POCO
if POCO
+config POCO_POQUITO
+ bool
+ prompt "smaller code-size"
+ help
+ Omit a few features for smaller codesize.
+
config POCO_ENCODINGS
bool
prompt "double-byte encodings library"
diff --git a/rules/poco.make b/rules/poco.make
index d280e08af..8226bc238 100644
--- a/rules/poco.make
+++ b/rules/poco.make
@@ -57,10 +57,13 @@ POCO_CONF_OPT := \
--no-tests \
--no-samples \
--omit=$(subst $(ptx/def/space),$(ptx/def/comma),$(POCO_LIBS-)) \
- --poquito \
--unbundled \
--shared
+ifdef PTXCONF_POCO_POQUITO
+POCO_CONF_OPT += --poquito
+endif
+
POCO_MAKE_ENV := \
$(CROSS_ENV) \
CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX) \
--
2.21.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] poco: make poquito configurable
2019-03-05 10:49 [ptxdist] [PATCH] poco: make poquito configurable Baeuerle, Florian
@ 2019-03-07 11:18 ` Michael Olbrich
2019-03-07 12:44 ` Baeuerle, Florian
2019-03-07 12:45 ` Baeuerle, Florian
0 siblings, 2 replies; 4+ messages in thread
From: Michael Olbrich @ 2019-03-07 11:18 UTC (permalink / raw)
To: ptxdist
On Tue, Mar 05, 2019 at 10:49:19AM +0000, Baeuerle, Florian wrote:
> This used to be the default configuration, saving a few kbytes on the
> library. The features this omits might weigh heavier than a few kbytes,
> so make this configurable.
>
> Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
> ---
> rules/poco.in | 6 ++++++
> rules/poco.make | 5 ++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/rules/poco.in b/rules/poco.in
> index 6f5afd804..7bd859a14 100644
> --- a/rules/poco.in
> +++ b/rules/poco.in
> @@ -19,6 +19,12 @@ menuconfig POCO
>
> if POCO
>
> +config POCO_POQUITO
> + bool
> + prompt "smaller code-size"
> + help
> + Omit a few features for smaller codesize.
> +
> config POCO_ENCODINGS
> bool
> prompt "double-byte encodings library"
> diff --git a/rules/poco.make b/rules/poco.make
> index d280e08af..8226bc238 100644
> --- a/rules/poco.make
> +++ b/rules/poco.make
> @@ -57,10 +57,13 @@ POCO_CONF_OPT := \
> --no-tests \
> --no-samples \
> --omit=$(subst $(ptx/def/space),$(ptx/def/comma),$(POCO_LIBS-)) \
> - --poquito \
This is a 'not really autoconf' package right?
Use this:
$(call ptx/ifdef/PTXCONF_POCO_POQUITO,--poquito)
Michael
> --unbundled \
> --shared
>
> +ifdef PTXCONF_POCO_POQUITO
> +POCO_CONF_OPT += --poquito
> +endif
> +
> POCO_MAKE_ENV := \
> $(CROSS_ENV) \
> CROSS_COMPILE=$(PTXCONF_COMPILER_PREFIX) \
> --
> 2.21.0
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] poco: make poquito configurable
2019-03-07 11:18 ` Michael Olbrich
@ 2019-03-07 12:44 ` Baeuerle, Florian
2019-03-07 12:45 ` Baeuerle, Florian
1 sibling, 0 replies; 4+ messages in thread
From: Baeuerle, Florian @ 2019-03-07 12:44 UTC (permalink / raw)
To: ptxdist
Am Donnerstag, den 07.03.2019, 12:18 +0100 schrieb Michael Olbrich:
> On Tue, Mar 05, 2019 at 10:49:19AM +0000, Baeuerle, Florian wrote:
> > +++ b/rules/poco.make
> > @@ -57,10 +57,13 @@ POCO_CONF_OPT := \
> > --no-tests \
> > --no-samples \
> > --omit=$(subst $(ptx/def/space),$(ptx/def/comma),$(POCO_LIBS-)) \
> > - --poquito \
>
> This is a 'not really autoconf' package right?
correct.
>
> Use this:
>
> $(call ptx/ifdef/PTXCONF_POCO_POQUITO,--poquito)
Okay.
- Florian
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ptxdist] [PATCH] poco: make poquito configurable
2019-03-07 11:18 ` Michael Olbrich
2019-03-07 12:44 ` Baeuerle, Florian
@ 2019-03-07 12:45 ` Baeuerle, Florian
1 sibling, 0 replies; 4+ messages in thread
From: Baeuerle, Florian @ 2019-03-07 12:45 UTC (permalink / raw)
To: ptxdist
This used to be the default configuration, saving a few kbytes on the
library. The features this omits might weigh heavier than a few kbytes,
so make this configurable.
Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
---
rules/poco.in | 6 ++++++
rules/poco.make | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/rules/poco.in b/rules/poco.in
index 6f5afd804..7bd859a14 100644
--- a/rules/poco.in
+++ b/rules/poco.in
@@ -19,6 +19,12 @@ menuconfig POCO
if POCO
+config POCO_POQUITO
+ bool
+ prompt "smaller code-size"
+ help
+ Omit a few features for smaller codesize.
+
config POCO_ENCODINGS
bool
prompt "double-byte encodings library"
diff --git a/rules/poco.make b/rules/poco.make
index d280e08af..c60802b2e 100644
--- a/rules/poco.make
+++ b/rules/poco.make
@@ -57,7 +57,7 @@ POCO_CONF_OPT := \
--no-tests \
--no-samples \
--omit=$(subst $(ptx/def/space),$(ptx/def/comma),$(POCO_LIBS-)) \
- --poquito \
+ $(call ptx/ifdef/PTXCONF_POCO_POQUITO,--poquito) \
--unbundled \
--shared
--
2.21.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 10:49 [ptxdist] [PATCH] poco: make poquito configurable Baeuerle, Florian
2019-03-07 11:18 ` Michael Olbrich
2019-03-07 12:44 ` Baeuerle, Florian
2019-03-07 12:45 ` Baeuerle, Florian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox