Re: [ptxdist] [PATCH] jsoncpp: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Mar 05, 2019 at 08:31:22AM +0000, Baeuerle, Florian wrote:
> Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
> ---
>  rules/jsoncpp.in   | 10 ++++++++
>  rules/jsoncpp.make | 57 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 rules/jsoncpp.in
>  create mode 100644 rules/jsoncpp.make
> 
> diff --git a/rules/jsoncpp.in b/rules/jsoncpp.in
> new file mode 100644
> index 000000000..c32e2d91c
> --- /dev/null
> +++ b/rules/jsoncpp.in
> @@ -0,0 +1,10 @@
> +## SECTION=system_libraries
> +
> +config JSONCPP
> +	tristate
> +	prompt "jsoncpp"
> +	help
> +	  JsonCpp is a C++ library that allows manipulating JSON values,
> +	  including serialization and deserialization to and from strings. It
> +	  can also preserve existing comment in unserialization/serialization
> +	  steps, making it a convenient format to store user input files.
> diff --git a/rules/jsoncpp.make b/rules/jsoncpp.make
> new file mode 100644
> index 000000000..99f5053f6
> --- /dev/null
> +++ b/rules/jsoncpp.make
> @@ -0,0 +1,57 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2009 by Michael Olbrich <m.olbrich@pengutronix.de>

I don't think I contributed to this file.

> +#               2019 by Florian Baeuerle <florian.baeuerle@allegion.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_JSONCPP) += jsoncpp
> +
> +#
> +# Paths and names
> +#
> +JSONCPP_VERSION		:= 1.8.4
> +JSONCPP_MD5		:= fa47a3ab6b381869b6a5f20811198662
> +JSONCPP			:= jsoncpp-$(JSONCPP_VERSION)
> +JSONCPP_SUFFIX		:= tar.gz
> +

No empty line here.

> +JSONCPP_URL		:= https://github.com/open-source-parsers/jsoncpp/archive/$(JSONCPP_VERSION).tar.gz
> +JSONCPP_SOURCE		:= $(SRCDIR)/jsoncpp-src-$(JSONCPP_VERSION).$(JSONCPP_SUFFIX)
> +JSONCPP_DIR		:= $(BUILDDIR)/$(JSONCPP)
> +JSONCPP_LICENSE		:= MIT
> +JSONCPP_LICENSE_FILES	:= file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +JSONCPP_CONF_TOOL	:= meson
> +JSONCPP_CONF_OPT	:= \
> +	$(CROSS_MESON_USR) \
> +	--buildtype=release \

Why 'release'? We set debugoptimized int CROSS_MESON_USR. This is '-g -O2'
which is the same as the default for autoconf.

> +	--default-library=shared

This is the meson default and should not be needed.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/jsoncpp.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, jsoncpp)
> +	@$(call install_fixup, jsoncpp,PRIORITY,optional)
> +	@$(call install_fixup, jsoncpp,SECTION,base)
> +	@$(call install_fixup, jsoncpp,AUTHOR,"Florian Baeuerle <florian.baeuerle@allegion.com>")
> +	@$(call install_fixup, jsoncpp,DESCRIPTION,missing)
> +
> +	@$(call install_lib, jsoncpp, 0, 0, 0644, libjsoncpp)
> +	@$(call install_finish, jsoncpp)
> +
> +	@$(call touch)
> -- 
> 2.21.0
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de