From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] busybox version bump 1.30.1 PATCH
Date: Mon, 25 Feb 2019 14:20:19 +0100 [thread overview]
Message-ID: <20190225132019.GA27054@lenoch> (raw)
In-Reply-To: <011885a4e48911e176bfa706e8ab8ccc@zutroll.de>
On Mon, Feb 25, 2019 at 01:31:57PM +0100, webmaster@zutroll.de wrote:
> From 3768b2dcb69ff2424656ce8f44eb04b38a1e6f93 Mon Sep 17 00:00:00 2001
> From: Simon <webmaster@zutroll.de>
> Date: Fri, 22 Feb 2019 14:45:51 +0100
> Subject: [PATCH] busybox 1.30.1 configs
> Signed-off-by: Simon Agostini <webmaster@zutroll.de>
> ---
> config/busybox/Config.in | 4 ++++
> config/busybox/coreutils/Config.in | 6 ++++++
> config/busybox/findutils/Config.in | 12 ++++++++++++
> config/busybox/libbb/Config.in | 18 ++++++++++++++++++
> config/busybox/miscutils/Config.in | 33 +++++++++++++++++++++++++++++++++
> config/busybox/networking/Config.in | 11 +++++++++++
> config/busybox/shell/Config.in | 14 ++++++++++++++
> config/busybox/util-linux/Config.in | 23 ++++++++++++++++++++++-
> 8 files changed, 120 insertions(+), 1 deletion(-)
Hello Simon,
seems your patches have increasing quality and you are almost here :)
It is important not to break bisecting (https://git-scm.com/docs/git-bisect)
as unlike CVS, git is able to group changes into commits (chagesets), so
all related changes can be eventually undone together. Here it would make
sense to combine version bump with config update as those are tightly
related. Also "[PATCH] busybox: version bump 1.29.3 -> 1.30.1" is prefered
Subject for such change.
Thank you and keep going,
ladis
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2019-02-25 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 6:45 webmaster
2019-02-25 12:31 ` webmaster
2019-02-25 13:20 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225132019.GA27054@lenoch \
--to=ladis@linux-mips.org \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox