* [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch @ 2019-02-25 6:39 webmaster 2019-02-25 10:02 ` Michael Olbrich 0 siblings, 1 reply; 4+ messages in thread From: webmaster @ 2019-02-25 6:39 UTC (permalink / raw) To: ptxdist [-- Attachment #1: Type: text/plain, Size: 23 bytes --] UNZIP_VERSION-bump-6.00 [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-UNZIP_VERSION-bump-6.00.patch --] [-- Type: text/x-diff; name=0001-UNZIP_VERSION-bump-6.00.patch, Size: 1309 bytes --] From c56effd00f8f9292ba4d8271692463280838ba62 Mon Sep 17 00:00:00 2001 From: Simon <webmaster@zutroll.de> Date: Fri, 22 Feb 2019 14:41:40 +0100 Subject: [PATCH 098/100] UNZIP_VERSION bump 6.00 --- rules/unzip.make | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rules/unzip.make b/rules/unzip.make index 47380ba31..f6c5f4ef0 100644 --- a/rules/unzip.make +++ b/rules/unzip.make @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip # Paths and names # (unzip is packaged a bit unusual way, that's why two version variables exist) # -UNZIP_VERSION := 5.52 -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 -UNZIP_AVERSION := 552 +UNZIP_VERSION := 6.00 +UNZIP_MD5 := 62b490407489521db863b523a7f86375 +UNZIP_AVERSION := 60 UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz UNZIP := unzip-$(UNZIP_VERSION) UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) UNZIP_DIR := $(BUILDDIR)/$(UNZIP) -UNZIP_LICENSE := Info-ZIP -UNZIP_LICENSE_FILES := file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f +UNZIP_LICENSE := Info-ZIP, BSD-like +UNZIP_LICENSE_FILES := file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 # ---------------------------------------------------------------------------- # Compile -- 2.14.1.windows.1 [-- Attachment #3: Type: text/plain, Size: 91 bytes --] _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch 2019-02-25 6:39 [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch webmaster @ 2019-02-25 10:02 ` Michael Olbrich 2019-02-25 12:26 ` webmaster 0 siblings, 1 reply; 4+ messages in thread From: Michael Olbrich @ 2019-02-25 10:02 UTC (permalink / raw) To: ptxdist On Mon, Feb 25, 2019 at 07:39:32AM +0100, webmaster@zutroll.de wrote: > UNZIP_VERSION-bump-6.00 > From c56effd00f8f9292ba4d8271692463280838ba62 Mon Sep 17 00:00:00 2001 > From: Simon <webmaster@zutroll.de> > Date: Fri, 22 Feb 2019 14:41:40 +0100 > Subject: [PATCH 098/100] UNZIP_VERSION bump 6.00 > As Alex noted, The SOB is missing. And while text attachments are acceptable, I prefer the patches inline. And less work for me means, that your patch is applied faster. > --- > rules/unzip.make | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/rules/unzip.make b/rules/unzip.make > index 47380ba31..f6c5f4ef0 100644 > --- a/rules/unzip.make > +++ b/rules/unzip.make > @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip > # Paths and names > # (unzip is packaged a bit unusual way, that's why two version variables exist) > # > -UNZIP_VERSION := 5.52 > -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 > -UNZIP_AVERSION := 552 > +UNZIP_VERSION := 6.00 > +UNZIP_MD5 := 62b490407489521db863b523a7f86375 > +UNZIP_AVERSION := 60 > UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz > UNZIP := unzip-$(UNZIP_VERSION) > UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) > UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) > UNZIP_DIR := $(BUILDDIR)/$(UNZIP) > -UNZIP_LICENSE := Info-ZIP > -UNZIP_LICENSE_FILES := file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f > +UNZIP_LICENSE := Info-ZIP, BSD-like > +UNZIP_LICENSE_FILES := file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 For license changes like this, I'd like a comment in the commit message. Also, BSD-like is not a proper SPDX identifier and the ',' is not acceptable either: You need to choose the correct operator. 'AND' if both licenses apply at the same time, 'OR' if the user can pick on of the two. Michael > > # ---------------------------------------------------------------------------- > # Compile > -- > 2.14.1.windows.1 > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch 2019-02-25 10:02 ` Michael Olbrich @ 2019-02-25 12:26 ` webmaster 2019-03-01 11:00 ` Michael Olbrich 0 siblings, 1 reply; 4+ messages in thread From: webmaster @ 2019-02-25 12:26 UTC (permalink / raw) To: ptxdist HI, I hope this matches your expectations: Signed-off-by: Simon Agostini <webmaster@zutroll.de> --- rules/unzip.make | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rules/unzip.make b/rules/unzip.make index 47380ba31..f6c5f4ef0 100644 --- a/rules/unzip.make +++ b/rules/unzip.make @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip # Paths and names # (unzip is packaged a bit unusual way, that's why two version variables exist) # -UNZIP_VERSION := 5.52 -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 -UNZIP_AVERSION := 552 +UNZIP_VERSION := 6.00 +UNZIP_MD5 := 62b490407489521db863b523a7f86375 +UNZIP_AVERSION := 60 UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz UNZIP := unzip-$(UNZIP_VERSION) UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) UNZIP_DIR := $(BUILDDIR)/$(UNZIP) -UNZIP_LICENSE := Info-ZIP -UNZIP_LICENSE_FILES := file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f +UNZIP_LICENSE := Info-ZIP, BSD-like +UNZIP_LICENSE_FILES := file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 # ---------------------------------------------------------------------------- # Compile -- 2.14.1.windows.1 Am 2019-02-25 11:02, schrieb Michael Olbrich: > On Mon, Feb 25, 2019 at 07:39:32AM +0100, webmaster@zutroll.de wrote: >> UNZIP_VERSION-bump-6.00 > >> From c56effd00f8f9292ba4d8271692463280838ba62 Mon Sep 17 00:00:00 2001 >> From: Simon <webmaster@zutroll.de> >> Date: Fri, 22 Feb 2019 14:41:40 +0100 >> Subject: [PATCH 098/100] UNZIP_VERSION bump 6.00 >> > > As Alex noted, The SOB is missing. And while text attachments are > acceptable, I prefer the patches inline. And less work for me means, > that > your patch is applied faster. > >> --- >> rules/unzip.make | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/rules/unzip.make b/rules/unzip.make >> index 47380ba31..f6c5f4ef0 100644 >> --- a/rules/unzip.make >> +++ b/rules/unzip.make >> @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip >> # Paths and names >> # (unzip is packaged a bit unusual way, that's why two version >> variables exist) >> # >> -UNZIP_VERSION := 5.52 >> -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 >> -UNZIP_AVERSION := 552 >> +UNZIP_VERSION := 6.00 >> +UNZIP_MD5 := 62b490407489521db863b523a7f86375 >> +UNZIP_AVERSION := 60 >> UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz >> UNZIP := unzip-$(UNZIP_VERSION) >> UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) >> UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) >> UNZIP_DIR := $(BUILDDIR)/$(UNZIP) >> -UNZIP_LICENSE := Info-ZIP >> -UNZIP_LICENSE_FILES := >> file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f >> +UNZIP_LICENSE := Info-ZIP, BSD-like >> +UNZIP_LICENSE_FILES := >> file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 > > For license changes like this, I'd like a comment in the commit > message. > Also, BSD-like is not a proper SPDX identifier and the ',' is not > acceptable either: You need to choose the correct operator. 'AND' if > both > licenses apply at the same time, 'OR' if the user can pick on of the > two. > > Michael > >> >> # >> ---------------------------------------------------------------------------- >> # Compile >> -- >> 2.14.1.windows.1 >> > >> _______________________________________________ >> ptxdist mailing list >> ptxdist@pengutronix.de _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch 2019-02-25 12:26 ` webmaster @ 2019-03-01 11:00 ` Michael Olbrich 0 siblings, 0 replies; 4+ messages in thread From: Michael Olbrich @ 2019-03-01 11:00 UTC (permalink / raw) To: ptxdist Hi, Please use a proper subject. On Mon, Feb 25, 2019 at 01:26:08PM +0100, webmaster@zutroll.de wrote: > HI, > > I hope this matches your expectations: Comments like this belong below the '---' line. That means, that they will be dropped when I apply the patch. Also, you did not address my other review comments. Michael > > Signed-off-by: Simon Agostini <webmaster@zutroll.de> > > --- > rules/unzip.make | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/rules/unzip.make b/rules/unzip.make > index 47380ba31..f6c5f4ef0 100644 > --- a/rules/unzip.make > +++ b/rules/unzip.make > @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip > # Paths and names > # (unzip is packaged a bit unusual way, that's why two version variables > exist) > # > -UNZIP_VERSION := 5.52 > -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 > -UNZIP_AVERSION := 552 > +UNZIP_VERSION := 6.00 > +UNZIP_MD5 := 62b490407489521db863b523a7f86375 > +UNZIP_AVERSION := 60 > UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz > UNZIP := unzip-$(UNZIP_VERSION) > UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) > UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) > UNZIP_DIR := $(BUILDDIR)/$(UNZIP) > -UNZIP_LICENSE := Info-ZIP > -UNZIP_LICENSE_FILES := file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f > +UNZIP_LICENSE := Info-ZIP, BSD-like > +UNZIP_LICENSE_FILES := file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 > > # > ---------------------------------------------------------------------------- > # Compile > -- > 2.14.1.windows.1 > > > > Am 2019-02-25 11:02, schrieb Michael Olbrich: > > On Mon, Feb 25, 2019 at 07:39:32AM +0100, webmaster@zutroll.de wrote: > > > UNZIP_VERSION-bump-6.00 > > > > > From c56effd00f8f9292ba4d8271692463280838ba62 Mon Sep 17 00:00:00 2001 > > > From: Simon <webmaster@zutroll.de> > > > Date: Fri, 22 Feb 2019 14:41:40 +0100 > > > Subject: [PATCH 098/100] UNZIP_VERSION bump 6.00 > > > > > > > As Alex noted, The SOB is missing. And while text attachments are > > acceptable, I prefer the patches inline. And less work for me means, > > that > > your patch is applied faster. > > > > > --- > > > rules/unzip.make | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/rules/unzip.make b/rules/unzip.make > > > index 47380ba31..f6c5f4ef0 100644 > > > --- a/rules/unzip.make > > > +++ b/rules/unzip.make > > > @@ -17,16 +17,16 @@ PACKAGES-$(PTXCONF_UNZIP) += unzip > > > # Paths and names > > > # (unzip is packaged a bit unusual way, that's why two version > > > variables exist) > > > # > > > -UNZIP_VERSION := 5.52 > > > -UNZIP_MD5 := 9d23919999d6eac9217d1f41472034a9 > > > -UNZIP_AVERSION := 552 > > > +UNZIP_VERSION := 6.00 > > > +UNZIP_MD5 := 62b490407489521db863b523a7f86375 > > > +UNZIP_AVERSION := 60 > > > UNZIP_ARCHIVE := unzip$(UNZIP_AVERSION).tar.gz > > > UNZIP := unzip-$(UNZIP_VERSION) > > > UNZIP_URL := $(call ptx/mirror, SF, infozip/$(UNZIP_ARCHIVE)) > > > UNZIP_SOURCE := $(SRCDIR)/$(UNZIP_ARCHIVE) > > > UNZIP_DIR := $(BUILDDIR)/$(UNZIP) > > > -UNZIP_LICENSE := Info-ZIP > > > -UNZIP_LICENSE_FILES := > > > file://LICENSE;md5=28dcc51d0d279f531e4be676efb0071f > > > +UNZIP_LICENSE := Info-ZIP, BSD-like > > > +UNZIP_LICENSE_FILES := > > > file://LICENSE;md5=94caec5a51ef55ef711ee4e8b1c69e29 > > > > For license changes like this, I'd like a comment in the commit message. > > Also, BSD-like is not a proper SPDX identifier and the ',' is not > > acceptable either: You need to choose the correct operator. 'AND' if > > both > > licenses apply at the same time, 'OR' if the user can pick on of the > > two. > > > > Michael > > > > > > > > # ---------------------------------------------------------------------------- > > > # Compile > > > -- > > > 2.14.1.windows.1 > > > > > > > > _______________________________________________ > > > ptxdist mailing list > > > ptxdist@pengutronix.de > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-01 11:00 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-02-25 6:39 [ptxdist] 0001-UNZIP_VERSION-bump-6.00.patch webmaster 2019-02-25 10:02 ` Michael Olbrich 2019-02-25 12:26 ` webmaster 2019-03-01 11:00 ` Michael Olbrich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox