[ptxdist] Append Make Options to Compile Stage of Rule File

[ptxdist] Append Make Options to Compile Stage of Rule File

[Chin You Wen (WMSC-HW)]

[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]

Hello,

I am writing a rule to compile the libsepol package that comes with plain
Makefiles. I am trying to pass *-Wno-error* option through the
<PKG>_MAKE_OPT variable to override the *-Werror *option specified in the
package Makefile.

I have set
 LIBSEPOL_CONF_TOOL      := NO

and also
LIBSEPOL_MAKE_ENV := $(CROSS_ENV)
LIBSEPOL_MAKE_OPT := \
                -Wno-error=shadow

The make still runs without the *-Wno-error *option during compilation.

In the Quickstart guide, it is noted that "*in the rule file only the two
variables FOO_MAKE_ENV and FOO_MAKE_OPT must be set, to forward the
required settings to the package’s buildsystem.*"

What am I missing? Thanks in advance.

[-- Attachment #1.2: Type: text/html, Size: 982 bytes --]

[-- Attachment #2: libsepol.make --]
[-- Type: application/octet-stream, Size: 3156 bytes --]

# -*-makefile-*-
#
# Copyright (C) 2019 by WMSC
#
# See CREDITS for details about who has contributed to this project.
#
# For further information about the PTXdist project and license conditions
# see the README file.
#

#
# We provide this package
#
PACKAGES-$(PTXCONF_LIBSEPOL) += libsepol

#
# Paths and names
#
LIBSEPOL_VERSION        := 2.8
LIBSEPOL_MD5            := a7a8f0e4e2818000a546b030c15b8401
LIBSEPOL                := libsepol_$(LIBSEPOL_VERSION)
LIBSEPOL_SUFFIX         := orig.tar.gz
LIBSEPOL_URL            := http://cdn-fastly.deb.debian.org/debian/pool/main/libs/libsepol/$(LIBSEPOL).$(LIBSEPOL_SUFFIX)
LIBSEPOL_SOURCE         := $(SRCDIR)/$(LIBSEPOL).$(LIBSEPOL_SUFFIX)
LIBSEPOL_DIR            := $(BUILDDIR)/$(LIBSEPOL)
LIBSEPOL_LICENSE        := LGPL2.1

# ----------------------------------------------------------------------------
# Get
# ----------------------------------------------------------------------------

#$(LIBSEPOL_SOURCE):
#       @$(call targetinfo)
#       @$(call get, LIBSEPOL)

# ----------------------------------------------------------------------------
# Prepare
# ----------------------------------------------------------------------------

#
# autoconf
#
LIBSEPOL_CONF_TOOL      := NO
#LIBSEPOL_CONF_OPT      := $(CROSS_AUTOCONF_USR)

#$(STATEDIR)/libsepol.prepare:
#       @$(call targetinfo)
#       @$(call clean, $(LIBSEPOL_DIR)/config.cache)
#       cd $(LIBSEPOL_DIR) && \
#               $(LIBSEPOL_PATH) $(LIBSEPOL_ENV) \
#               ./configure $(LIBSEPOL_CONF_OPT)
#       @$(call touch)

# ----------------------------------------------------------------------------
# Compile
# ----------------------------------------------------------------------------

LIBSEPOL_MAKE_ENV := $(CROSS_ENV)

LIBSEPOL_MAKE_OPT := \
                -Wno-error=shadow

#$(STATEDIR)/libsepol.compile:
#       @$(call targetinfo)
#       @$(call world/compile, LIBSEPOL)
#       @$(call touch)

# ----------------------------------------------------------------------------
# Install
# ----------------------------------------------------------------------------

#$(STATEDIR)/libsepol.install:
#       @$(call targetinfo)
#       @$(call world/install, LIBSEPOL)
#       @$(call touch)

# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------

$(STATEDIR)/libsepol.targetinstall:
        @$(call targetinfo)

        @$(call install_init, libsepol)
        @$(call install_fixup, libsepol,PRIORITY,optional)
        @$(call install_fixup, libsepol,SECTION,base)
        @$(call install_fixup, libsepol,AUTHOR,"WMSC")
        @$(call install_fixup, libsepol,DESCRIPTION,missing)

        @$(call install_lib, libsepol, 0, 0, 0644, libsepol)
        @$(call install_finish, libsepol)

        @$(call touch)

# ----------------------------------------------------------------------------
# Clean
# ----------------------------------------------------------------------------

#$(STATEDIR)/libsepol.clean:
#       @$(call targetinfo)
#       @$(call clean_pkg, LIBSEPOL)

# vim: syntax=make

[-- Attachment #3: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Append Make Options to Compile Stage of Rule File

[Juergen Borleis]

Hi You Wen,

On Monday 18 February 2019 10:43:59 Chin You Wen (WMSC-HW) wrote:
> I am writing a rule to compile the libsepol package that comes with plain
> Makefiles. I am trying to pass *-Wno-error* option through the
> <PKG>_MAKE_OPT variable to override the *-Werror *option specified in the
> package Makefile.
>
> I have set
>  LIBSEPOL_CONF_TOOL      := NO
>
> and also
> LIBSEPOL_MAKE_ENV := $(CROSS_ENV)
> LIBSEPOL_MAKE_OPT := \
>                 -Wno-error=shadow
>
> The make still runs without the *-Wno-error *option during compilation.

Hmm, the "-Wno-error=shadow" must be forwarded to the compiler. You may need 
something like "CFLAGS=-Wno-error=shadow" in your case instead. This 
variable is used in the project's Makefiles (like in src/Makefile, line 50 
for example).

Cheers,
Jürgen

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Append Make Options to Compile Stage of Rule File

[Chin You Wen (WMSC-HW)]

[-- Attachment #1.1: Type: text/plain, Size: 3372 bytes --]

Hi Jürgen,

I tried that and also with some variations such as "CFLAGS+=-Wno-error" but
nothing changes in the compiler output. I am compiling for Phycore-AM335x
SOM, if that matters.


make[1]: Entering directory
`/export/home/oyouwen/phyCORE-AM335x-PD13.1.2/platform-phyCORE-AM335x/build-target/libsepol_2.8'
make -C src
make[2]: Entering directory
`/export/home/oyouwen/phyCORE-AM335x-PD13.1.2/platform-phyCORE-AM335x/build-target/libsepol_2.8/src'
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o assertion.o
assertion.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o avrule_block.o
avrule_block.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o avtab.o avtab.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o boolean_record.o
boolean_record.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o booleans.o
booleans.c

...

cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o interfaces.o
interfaces.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o kernel_to_cil.o
kernel_to_cil.c
cc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I.
-I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o kernel_to_common.o
kernel_to_common.c
kernel_to_common.c: In function 'strs_add_at_index':
kernel_to_common.c:212:60: error: declaration of 'index' shadows a global
declaration [-Werror=shadow]
kernel_to_common.c: In function 'strs_read_at_index':
kernel_to_common.c:237:54: error: declaration of 'index' shadows a global
declaration [-Werror=shadow]
cc1: all warnings being treated as errors
make[2]: *** [kernel_to_common.o] Error 1
make[2]: *** Waiting for unfinished jobs....


Regards,
You Wen


On Mon, Feb 18, 2019 at 5:56 PM Juergen Borleis <jbe@pengutronix.de> wrote:

> Hi You Wen,
>
> On Monday 18 February 2019 10:43:59 Chin You Wen (WMSC-HW) wrote:
> > I am writing a rule to compile the libsepol package that comes with plain
> > Makefiles. I am trying to pass *-Wno-error* option through the
> > <PKG>_MAKE_OPT variable to override the *-Werror *option specified in the
> > package Makefile.
> >
> > I have set
> >  LIBSEPOL_CONF_TOOL      := NO
> >
> > and also
> > LIBSEPOL_MAKE_ENV := $(CROSS_ENV)
> > LIBSEPOL_MAKE_OPT := \
> >                 -Wno-error=shadow
> >
> > The make still runs without the *-Wno-error *option during compilation.
>
> Hmm, the "-Wno-error=shadow" must be forwarded to the compiler. You may
> need
> something like "CFLAGS=-Wno-error=shadow" in your case instead. This
> variable is used in the project's Makefiles (like in src/Makefile, line 50
> for example).
>
> Cheers,
> Jürgen
>
> --
> Pengutronix e.K.                             | Juergen Borleis
> |
> Industrial Linux Solutions                   | http://www.pengutronix.de/
>  |
>


-- 
Regards,
You Wen

[-- Attachment #1.2: Type: text/html, Size: 4476 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Append Make Options to Compile Stage of Rule File

[Juergen Borleis]

Hi You Wen,

On Monday 18 February 2019 11:29:31 Chin You Wen (WMSC-HW) wrote:
> I tried that and also with some variations such as "CFLAGS+=-Wno-error"
> but nothing changes in the compiler output. I am compiling for
> Phycore-AM335x SOM, if that matters.

Okay, without:

------------------------
target: libsepol.compile
------------------------

make[1]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8'
make -C src
make[2]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8/src'
arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o assertion.o assertion.c
arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o avrule_block.o avrule_block.c
[...]
arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o mls.o mls.c
In file included from ibpkeys.c:4:0:
ibpkeys.c: In function 'sepol_ibpkey_query':
ibpkeys.c:179:14: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
debug.h:36:330: note: in definition of macro 'msg_write'
ibpkeys.c:179:2: note: in expansion of macro 'ERR'
ibpkeys.c: In function 'sepol_ibpkey_modify':
ibpkeys.c:206:14: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
debug.h:36:330: note: in definition of macro 'msg_write'
ibpkeys.c:206:2: note: in expansion of macro 'ERR'
cc1: all warnings being treated as errors
ICECC[25965] 2019-02-18 11:38:50: Compiled on 10.1.0.69
Makefile:76: recipe for target 'ibpkeys.o' failed

And with

LIBSEPOL_MAKE_OPT := \
                "CFLAGS=-Wno-error=shadow"

in the libsepol.make rule file:

------------------------
target: libsepol.compile
------------------------

make[1]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8'
make -C src
make[2]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8/src'
arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o assertion.o assertion.c
arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o avrule_block.o avrule_block.c
arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o avtab.o avtab.c
arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include -D_GNU_SOURCE -I../cil/include -fPIC -c -o boolean_record.o boolean_record.c
[...]
arm-v7a-linux-gnueabihf-ar rcs libsepol.a assertion.o avrule_block.o avtab.o boolean_record.o booleans.o conditional.o constraint.o context.o context_record.o debug.o ebitmap.o expand.o genbools.o genusers.o handle.o hashtab.o hierarchy.o ibendport_record.o ibendports.o ibpkey_record.o ibpkeys.o iface_record.o 
interfaces.o kernel_to_cil.o kernel_to_common.o kernel_to_conf.o link.o mls.o module.o module_to_cil.o node_record.o nodes.o polcaps.o policydb.o policydb_convert.o policydb_public.o port_record.o ports.o roles.o services.o sidtab.o symtab.o user_record.o users.o util.o 
write.o ../cil/src/cil.o ../cil/src/cil_binary.o ../cil/src/cil_build_ast.o ../cil/src/cil_copy_ast.o ../cil/src/cil_find.o ../cil/src/cil_fqn.o ../cil/src/cil_lexer.o ../cil/src/cil_list.o ../cil/src/cil_log.o ../cil/src/cil_mem.o ../cil/src/cil_parser.o ../cil/src/cil_policy.o ../cil/src/cil_post.o ../cil/src/cil_reset_ast.o ../cil/src/cil_resolve_ast.o ../cil/src/cil_stack.o ../cil/src/cil_strpool.o ../cil/src/cil_symtab.o ../cil/src/cil_tree.o ../cil/src/cil_verify.o
arm-v7a-linux-gnueabihf-ranlib libsepol.a
ln -sf libsepol.so.1 libsepol.so
make[2]: Leaving directory '[...]/platform-v7a/build-target/libsepol_2.8/src'
make -C utils
make[2]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8/utils'
arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I../include  -L../src  chkcon.c  -lsepol -o chkcon
make[2]: Leaving directory '[...]/platform-v7a/build-target/libsepol_2.8/utils'
make[1]: Leaving directory '[...]/platform-v7a/build-target/libsepol_2.8'
finished target libsepol.compile

It works as expected (and removes all options from the Makefile, which isn't
a good idea). Maybe this would be better:

LIBSEPOL_MAKE_OPT := \
		CFLAGS="-Wall -Wextra -W -Wundef -Wshadow -Wmissing-format-attribute -O2"

Regards,
Jürgen

BTW: You should fix the warnings. They are serious.

-- 
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] Append Make Options to Compile Stage of Rule File

[Chin You Wen (WMSC-HW)]

[-- Attachment #1.1: Type: text/plain, Size: 5642 bytes --]

Hi Jürgen,

You were right about the specifying the CFLAGS variable in your first
reply. It didn't work at first because I commented a line like below, and
subsequent lines are not being parsed properly.

LIBSEPOL_MAKE_OPT := \
# -Wno-error=shadow
                "CFLAGS=-Wno-error=shadow"

Also I will fix these non-trivial warnings. Thanks for your help!

Regards,
You Wen


On Mon, Feb 18, 2019 at 6:50 PM Juergen Borleis <jbe@pengutronix.de> wrote:

> Hi You Wen,
>
> On Monday 18 February 2019 11:29:31 Chin You Wen (WMSC-HW) wrote:
> > I tried that and also with some variations such as "CFLAGS+=-Wno-error"
> > but nothing changes in the compiler output. I am compiling for
> > Phycore-AM335x SOM, if that matters.
>
> Okay, without:
>
> ------------------------
> target: libsepol.compile
> ------------------------
>
> make[1]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8'
> make -C src
> make[2]: Entering directory
> '[...]/platform-v7a/build-target/libsepol_2.8/src'
> arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow
> -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE
> -I../cil/include -fPIC -c -o assertion.o assertion.c
> arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow
> -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE
> -I../cil/include -fPIC -c -o avrule_block.o avrule_block.c
> [...]
> arm-v7a-linux-gnueabihf-gcc -Werror -Wall -W -Wundef -Wshadow
> -Wmissing-format-attribute -O2 -I. -I../include -D_GNU_SOURCE
> -I../cil/include -fPIC -c -o mls.o mls.c
> In file included from ibpkeys.c:4:0:
> ibpkeys.c: In function 'sepol_ibpkey_query':
> ibpkeys.c:179:14: error: format '%lx' expects argument of type 'long
> unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned
> int}' [-Werror=format=]
> debug.h:36:330: note: in definition of macro 'msg_write'
> ibpkeys.c:179:2: note: in expansion of macro 'ERR'
> ibpkeys.c: In function 'sepol_ibpkey_modify':
> ibpkeys.c:206:14: error: format '%lx' expects argument of type 'long
> unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned
> int}' [-Werror=format=]
> debug.h:36:330: note: in definition of macro 'msg_write'
> ibpkeys.c:206:2: note: in expansion of macro 'ERR'
> cc1: all warnings being treated as errors
> ICECC[25965] 2019-02-18 11:38:50: Compiled on 10.1.0.69
> Makefile:76: recipe for target 'ibpkeys.o' failed
>
> And with
>
> LIBSEPOL_MAKE_OPT := \
>                 "CFLAGS=-Wno-error=shadow"
>
> in the libsepol.make rule file:
>
> ------------------------
> target: libsepol.compile
> ------------------------
>
> make[1]: Entering directory '[...]/platform-v7a/build-target/libsepol_2.8'
> make -C src
> make[2]: Entering directory
> '[...]/platform-v7a/build-target/libsepol_2.8/src'
> arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include
> -D_GNU_SOURCE -I../cil/include -fPIC -c -o assertion.o assertion.c
> arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include
> -D_GNU_SOURCE -I../cil/include -fPIC -c -o avrule_block.o avrule_block.c
> arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include
> -D_GNU_SOURCE -I../cil/include -fPIC -c -o avtab.o avtab.c
> arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I. -I../include
> -D_GNU_SOURCE -I../cil/include -fPIC -c -o boolean_record.o boolean_record.c
> [...]
> arm-v7a-linux-gnueabihf-ar rcs libsepol.a assertion.o avrule_block.o
> avtab.o boolean_record.o booleans.o conditional.o constraint.o context.o
> context_record.o debug.o ebitmap.o expand.o genbools.o genusers.o handle.o
> hashtab.o hierarchy.o ibendport_record.o ibendports.o ibpkey_record.o
> ibpkeys.o iface_record.o
> interfaces.o kernel_to_cil.o kernel_to_common.o kernel_to_conf.o link.o
> mls.o module.o module_to_cil.o node_record.o nodes.o polcaps.o policydb.o
> policydb_convert.o policydb_public.o port_record.o ports.o roles.o
> services.o sidtab.o symtab.o user_record.o users.o util.o
> write.o ../cil/src/cil.o ../cil/src/cil_binary.o
> ../cil/src/cil_build_ast.o ../cil/src/cil_copy_ast.o ../cil/src/cil_find.o
> ../cil/src/cil_fqn.o ../cil/src/cil_lexer.o ../cil/src/cil_list.o
> ../cil/src/cil_log.o ../cil/src/cil_mem.o ../cil/src/cil_parser.o
> ../cil/src/cil_policy.o ../cil/src/cil_post.o ../cil/src/cil_reset_ast.o
> ../cil/src/cil_resolve_ast.o ../cil/src/cil_stack.o
> ../cil/src/cil_strpool.o ../cil/src/cil_symtab.o ../cil/src/cil_tree.o
> ../cil/src/cil_verify.o
> arm-v7a-linux-gnueabihf-ranlib libsepol.a
> ln -sf libsepol.so.1 libsepol.so
> make[2]: Leaving directory
> '[...]/platform-v7a/build-target/libsepol_2.8/src'
> make -C utils
> make[2]: Entering directory
> '[...]/platform-v7a/build-target/libsepol_2.8/utils'
> arm-v7a-linux-gnueabihf-gcc -Wno-error=shadow -I../include  -L../src
> chkcon.c  -lsepol -o chkcon
> make[2]: Leaving directory
> '[...]/platform-v7a/build-target/libsepol_2.8/utils'
> make[1]: Leaving directory '[...]/platform-v7a/build-target/libsepol_2.8'
> finished target libsepol.compile
>
> It works as expected (and removes all options from the Makefile, which
> isn't
> a good idea). Maybe this would be better:
>
> LIBSEPOL_MAKE_OPT := \
>                 CFLAGS="-Wall -Wextra -W -Wundef -Wshadow
> -Wmissing-format-attribute -O2"
>
> Regards,
> Jürgen
>
> BTW: You should fix the warnings. They are serious.
>
> --
> Pengutronix e.K.                             | Juergen Borleis
> |
> Industrial Linux Solutions                   | http://www.pengutronix.de/
>  |
>


-- 
Regards,
You Wen

[-- Attachment #1.2: Type: text/html, Size: 6716 bytes --]

[-- Attachment #2: Type: text/plain, Size: 91 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de