From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/5] optee: add the OP-TEE as new target package
Date: Mon, 4 Feb 2019 15:51:26 +0100 [thread overview]
Message-ID: <20190204145126.pyx3vrpjdqcpkcxe@pengutronix.de> (raw)
In-Reply-To: <87ftt3d3zs.fsf@czerwinskis.de>
On Mon, Feb 04, 2019 at 03:26:15PM +0100, Rouven Czerwinski wrote:
> Michael Olbrich <m.olbrich@pengutronix.de> writes:
> > On Mon, Feb 04, 2019 at 10:56:00AM +0100, Rouven Czerwinski wrote:
> >> Provide two KConfig files to allow inclusion of OP-TEE for userspace libraries
> >> and applications.
> >>
> >> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> >> ---
> >> platforms/optee.in | 54 ++++++++++++++++++++++-
> >> rules/optee.in | 7 +++-
> >> rules/optee.make | 113 ++++++++++++++++++++++++++++++++++++++++++++++-
> >> 3 files changed, 174 insertions(+)
> >> create mode 100644 platforms/optee.in
> >> create mode 100644 rules/optee.in
> >> create mode 100644 rules/optee.make
> >> +endif
> >> +ifneq ($(shell test -x $(PTXDIST_WORKSPACE)/selected_toolchain_optee_aarch32/$(PTXCONF_OPTEE_AARCH32_CC_PREFIX)gcc && echo ok),ok)
> >> + $(warning *** $(PTXDIST_WORKSPACE)/selected_toolchain_optee_aarch32/$(PTXCONF_OPTEE_AARCH32_CC_PREFIX)gcc not found)
> >> + $(error )
> >> +endif
> >> +endif
> >
> > And why do we need the extra toolchain anyways?
> Due to OP-TEEs build system, see
> https://github.com/OP-TEE/optee_website/tree/master/build_system#cross_compile-cross-compiler-selection
Is the 32bit stuff actually used anywhere, or it this just a broken build
system? Could use use the aarch64 toolchain with -mabi=ilp32 ?
> >> +
> >> +# ----------------------------------------------------------------------------
> >> +# Compile
> >> +# ----------------------------------------------------------------------------
> >> +
> >> +ifdef PTXCONF_ARCH_ARM64
> >> +OPTEE_CROSS_COMPILE32= $(PTXDIST_WORKSPACE)/selected_toolchain_optee_aarch32/$(call remove_quotes,$(PTXCONF_OPTEE_AARCH32_CC_PREFIX))
> >> +OPTEE_MAKE_ENV += CROSS_COMPILE32=$(OPTEE_CROSS_COMPILE32)
> >> +OPTEE_MAKE_OPT += CFG_ARM64_core=y
> >> +OPTEE_MAKE_ENV += CROSS_COMPILE64=$(call remove_quotes,$(PTXCONF_COMPILER_PREFIX))
As noted elsewhere: PTXCONF_COMPILER_PREFIX has no quotes
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2019-02-04 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 9:55 [ptxdist] [PATCH 0/5] Support for OP-TEE (Open Portable Trusted Execution Environment) Rouven Czerwinski
2019-02-04 9:55 ` [ptxdist] [PATCH 1/5] optee-client: bump to 3.4.0 Rouven Czerwinski
2019-02-04 9:55 ` [ptxdist] [PATCH 2/5] optee-client: add tee-supplicant service file Rouven Czerwinski
2019-02-04 13:22 ` Michael Olbrich
2019-02-04 14:28 ` Rouven Czerwinski
2019-02-04 9:56 ` [ptxdist] [PATCH 3/5] optee: add the OP-TEE as new target package Rouven Czerwinski
2019-02-04 14:03 ` Michael Olbrich
2019-02-04 14:26 ` Rouven Czerwinski
2019-02-04 14:51 ` Michael Olbrich [this message]
2019-02-04 9:56 ` [ptxdist] [PATCH 4/5] optee_test: add new optee_test " Rouven Czerwinski
2019-02-04 14:43 ` Michael Olbrich
2019-02-04 9:56 ` [ptxdist] [PATCH 5/5] optee_examples: add as new " Rouven Czerwinski
2019-02-04 14:54 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204145126.pyx3vrpjdqcpkcxe@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox