mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/5] optee-client: add tee-supplicant service file
Date: Mon, 4 Feb 2019 14:22:32 +0100	[thread overview]
Message-ID: <20190204132232.7pvpzq7acoi4ieuz@pengutronix.de> (raw)
In-Reply-To: <6f2be855d198c2e0a98735b54c3a9cc9d442245c.1549274148.git-series.r.czerwinski@pengutronix.de>

On Mon, Feb 04, 2019 at 10:55:59AM +0100, Rouven Czerwinski wrote:
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  projectroot/usr/lib/systemd/system/tee-supplicant.service |  9 ++++++-
>  rules/optee-client.in                                     | 13 +++++++-
>  rules/optee-client.make                                   |  8 +++++-
>  3 files changed, 29 insertions(+), 1 deletion(-)
>  create mode 100644 projectroot/usr/lib/systemd/system/tee-supplicant.service
> 
> diff --git a/projectroot/usr/lib/systemd/system/tee-supplicant.service b/projectroot/usr/lib/systemd/system/tee-supplicant.service
> new file mode 100644
> index 0000000..f8eacff
> --- /dev/null
> +++ b/projectroot/usr/lib/systemd/system/tee-supplicant.service
> @@ -0,0 +1,9 @@
> +[Unit]
> +Description=TEE Supplicant
> +
> +[Service]
> +Type=simple
> +ExecStart=/usr/bin/tee-supplicant
> +
> +[Install]
> +WantedBy=multi-user.target
> \ No newline at end of file

Add newline.

> diff --git a/rules/optee-client.in b/rules/optee-client.in
> index 9099b4c..0ed2511 100644
> --- a/rules/optee-client.in
> +++ b/rules/optee-client.in
> @@ -1,8 +1,9 @@
>  ## SECTION=security
>  
> -config OPTEE_CLIENT
> +menuconfig OPTEE_CLIENT
>  	tristate
>  	prompt "optee-client"

Add spaces to align the '-->' in the menu.


> +	select OPTEE
>  	help
>  	  Open Portable Trusted Execution Environment Client API.
>  
> @@ -11,3 +12,13 @@ config OPTEE_CLIENT
>  	  a binary tee-supplicant which is a daemon serving the
>  	  Trusted OS in secure world with miscellaneous features, such
>  	  as file system access.
> +
> +if OPTEE_CLIENT
> +
> +config OPTEE_CLIENT_SYSTEMD_UNIT
> +	bool
> +	default y
> +	depends on SYSTEMD
> +	prompt "install systemd service file for tee-supplicant"
> +
> +endif
> diff --git a/rules/optee-client.make b/rules/optee-client.make
> index 09cae7e..9c5d30b 100644
> --- a/rules/optee-client.make
> +++ b/rules/optee-client.make
> @@ -54,6 +54,14 @@ $(STATEDIR)/optee-client.targetinstall:
>  
>  	@$(call install_lib, optee-client, 0, 0, 0644, libteec)
>  	@$(call install_copy, optee-client, 0, 0, 0755, -, /usr/bin/tee-supplicant)
> +ifdef PTXCONF_INITMETHOD_SYSTEMD

Not necessary.

Michael

> +ifdef PTXCONF_OPTEE_CLIENT_SYSTEMD_UNIT
> +	@$(call install_alternative, optee-client, 0, 0, 0644, \
> +		/usr/lib/systemd/system/tee-supplicant.service)
> +	@$(call install_link, optee-client, ../tee-supplicant.service,\
> +		/usr/lib/systemd/system/multi-user.target.wants/tee-supplicant.service)
> +endif
> +endif
>  
>  	@$(call install_finish, optee-client)
>  
> -- 
> git-series 0.9.1
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2019-02-04 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04  9:55 [ptxdist] [PATCH 0/5] Support for OP-TEE (Open Portable Trusted Execution Environment) Rouven Czerwinski
2019-02-04  9:55 ` [ptxdist] [PATCH 1/5] optee-client: bump to 3.4.0 Rouven Czerwinski
2019-02-04  9:55 ` [ptxdist] [PATCH 2/5] optee-client: add tee-supplicant service file Rouven Czerwinski
2019-02-04 13:22   ` Michael Olbrich [this message]
2019-02-04 14:28     ` Rouven Czerwinski
2019-02-04  9:56 ` [ptxdist] [PATCH 3/5] optee: add the OP-TEE as new target package Rouven Czerwinski
2019-02-04 14:03   ` Michael Olbrich
2019-02-04 14:26     ` Rouven Czerwinski
2019-02-04 14:51       ` Michael Olbrich
2019-02-04  9:56 ` [ptxdist] [PATCH 4/5] optee_test: add new optee_test " Rouven Czerwinski
2019-02-04 14:43   ` Michael Olbrich
2019-02-04  9:56 ` [ptxdist] [PATCH 5/5] optee_examples: add as new " Rouven Czerwinski
2019-02-04 14:54   ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190204132232.7pvpzq7acoi4ieuz@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox