Re: [ptxdist] [PATCH] templates: file: update comments and improve wording

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jan 16, 2019 at 11:22:14AM +0100, Roland Hieber wrote:
> On Wed, Dec 12, 2018 at 02:35:16PM +0100, Michael Olbrich wrote:
> > On Wed, Dec 12, 2018 at 12:29:26AM +0100, Roland Hieber wrote:
> > > The way of building target packages has changed over the years, and
> > > SYSROOT_TARGET is no longer filled in the install stage. But all of this
> > > is also explained in the Reference Manual, so we don't have to duplicate
> > > that here.
> > > 
> > > Also add the definition of @PACKAGE@_DIR at the top, which is used in
> > > the targetinstall stage later.
> > > 
> > > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > > ---
> > >  rules/templates/template-file-make | 45 ++++++------------------------
> > >  1 file changed, 9 insertions(+), 36 deletions(-)
> > > 
> > > diff --git a/rules/templates/template-file-make b/rules/templates/template-file-make
> > > index ee2a612ef..4e322a39c 100644
> > > --- a/rules/templates/template-file-make
> > > +++ b/rules/templates/template-file-make
> > > @@ -4,25 +4,27 @@
> > >  #
> > >  # See CREDITS for details about who has contributed to this project.
> > >  #
> > >  # For further information about the PTXdist project and license conditions
> > >  # see the README file.
> > >  #
> > >  
> > >  #
> > >  # We provide this package
> > >  #
> > >  PACKAGES-$(PTXCONF_@PACKAGE@) += @package@
> > >  
> > > +@PACKAGE@		:= @package@
> > >  @PACKAGE@_VERSION	:= @VERSION@
> > > +@PACKAGE@_DIR		:= $(PKGDIR)/$(@PACKAGE@)-$(@PACKAGE@_VERSION)
> > 
> > No, if <PKG>_DIR is defined then the default compile and install stages are
> > no longer no-ops. Change the example in targetinstall to
> > install_alternative.
> 
> Yes indeed. I'll try to rework it with your comments in mind. Can you
> drop this patch for now, and apply the other two if there are no
> problems with them?

You mean the two documentation patches, right? I've applied those.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de