[ptxdist] [PATCH] gcclibs: typo: don't install liblsan.so when GCCLIBS_LIBTSAN is enabled

[ptxdist] [PATCH] gcclibs: typo: don't install liblsan.so when GCCLIBS_LIBTSAN is enabled

[Roland Hieber]

As mentioned in gcclibs.in, the GCCLIBS_LIBTSAN symbol is meant to
install the ThreadSanitizer library, libtsan.so. The typo here,
"liblsan.so" was probably copied from the rule above it.

Reported-by: horizon on irc://chat.freenode.net/#ptxdist
Fixes: 60ae2f93bed3a1d5a7e6 ("gcclibs: add more sanitizer")
Signed-off-by: Roland Hieber <rohieb@rohieb.name>
---
 rules/gcclibs.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/gcclibs.make b/rules/gcclibs.make
index 6b1a31ebf..187c80c15 100644
--- a/rules/gcclibs.make
+++ b/rules/gcclibs.make
@@ -56,11 +56,11 @@ endif
 ifdef PTXCONF_GCCLIBS_LIBLSAN
 	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
 endif
 
 ifdef PTXCONF_GCCLIBS_LIBTSAN
-	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
+	@$(call install_copy_toolchain_lib, gcclibs, libtsan.so)
 endif
 
 ifdef PTXCONF_GCCLIBS_LIBUBSAN
 	@$(call install_copy_toolchain_lib, gcclibs, libubsan.so)
 endif
-- 
2.19.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] gcclibs: typo: don't install liblsan.so when GCCLIBS_LIBTSAN is enabled

[Roland Hieber]

Hi Michael,

are there problems with this, or did it fall through the cracks? :)

 - Roland

On Sat, Dec 22, 2018 at 03:07:37AM +0100, Roland Hieber wrote:
> As mentioned in gcclibs.in, the GCCLIBS_LIBTSAN symbol is meant to
> install the ThreadSanitizer library, libtsan.so. The typo here,
> "liblsan.so" was probably copied from the rule above it.
> 
> Reported-by: horizon on irc://chat.freenode.net/#ptxdist
> Fixes: 60ae2f93bed3a1d5a7e6 ("gcclibs: add more sanitizer")
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
>  rules/gcclibs.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/gcclibs.make b/rules/gcclibs.make
> index 6b1a31ebf..187c80c15 100644
> --- a/rules/gcclibs.make
> +++ b/rules/gcclibs.make
> @@ -56,11 +56,11 @@ endif
>  ifdef PTXCONF_GCCLIBS_LIBLSAN
>  	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
>  endif
>  
>  ifdef PTXCONF_GCCLIBS_LIBTSAN
> -	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
> +	@$(call install_copy_toolchain_lib, gcclibs, libtsan.so)
>  endif
>  
>  ifdef PTXCONF_GCCLIBS_LIBUBSAN
>  	@$(call install_copy_toolchain_lib, gcclibs, libubsan.so)
>  endif
> -- 
> 2.19.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] gcclibs: typo: don't install liblsan.so when GCCLIBS_LIBTSAN is enabled

[Roland Hieber]

Ah, sorry, I see it is on master now :-)

 - Roland

On Tue, Jan 08, 2019 at 02:54:03PM +0100, Roland Hieber wrote:
> Hi Michael,
> 
> are there problems with this, or did it fall through the cracks? :)
> 
>  - Roland
> 
> On Sat, Dec 22, 2018 at 03:07:37AM +0100, Roland Hieber wrote:
> > As mentioned in gcclibs.in, the GCCLIBS_LIBTSAN symbol is meant to
> > install the ThreadSanitizer library, libtsan.so. The typo here,
> > "liblsan.so" was probably copied from the rule above it.
> > 
> > Reported-by: horizon on irc://chat.freenode.net/#ptxdist
> > Fixes: 60ae2f93bed3a1d5a7e6 ("gcclibs: add more sanitizer")
> > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > ---
> >  rules/gcclibs.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/gcclibs.make b/rules/gcclibs.make
> > index 6b1a31ebf..187c80c15 100644
> > --- a/rules/gcclibs.make
> > +++ b/rules/gcclibs.make
> > @@ -56,11 +56,11 @@ endif
> >  ifdef PTXCONF_GCCLIBS_LIBLSAN
> >  	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
> >  endif
> >  
> >  ifdef PTXCONF_GCCLIBS_LIBTSAN
> > -	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
> > +	@$(call install_copy_toolchain_lib, gcclibs, libtsan.so)
> >  endif
> >  
> >  ifdef PTXCONF_GCCLIBS_LIBUBSAN
> >  	@$(call install_copy_toolchain_lib, gcclibs, libubsan.so)
> >  endif
> > -- 
> > 2.19.2
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> 
> -- 
> Roland Hieber                     | r.hieber@pengutronix.de     |
> Pengutronix e.K.                  | https://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de