mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] gcclibs: typo: don't install liblsan.so when GCCLIBS_LIBTSAN is enabled
Date: Thu, 10 Jan 2019 12:44:30 +0100	[thread overview]
Message-ID: <20190110114430.tep5drr4cgpnlktj@pengutronix.de> (raw)
In-Reply-To: <20190108135403.qubjktmjnuwq4u7g@pengutronix.de>

Ah, sorry, I see it is on master now :-)

 - Roland

On Tue, Jan 08, 2019 at 02:54:03PM +0100, Roland Hieber wrote:
> Hi Michael,
> 
> are there problems with this, or did it fall through the cracks? :)
> 
>  - Roland
> 
> On Sat, Dec 22, 2018 at 03:07:37AM +0100, Roland Hieber wrote:
> > As mentioned in gcclibs.in, the GCCLIBS_LIBTSAN symbol is meant to
> > install the ThreadSanitizer library, libtsan.so. The typo here,
> > "liblsan.so" was probably copied from the rule above it.
> > 
> > Reported-by: horizon on irc://chat.freenode.net/#ptxdist
> > Fixes: 60ae2f93bed3a1d5a7e6 ("gcclibs: add more sanitizer")
> > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > ---
> >  rules/gcclibs.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/gcclibs.make b/rules/gcclibs.make
> > index 6b1a31ebf..187c80c15 100644
> > --- a/rules/gcclibs.make
> > +++ b/rules/gcclibs.make
> > @@ -56,11 +56,11 @@ endif
> >  ifdef PTXCONF_GCCLIBS_LIBLSAN
> >  	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
> >  endif
> >  
> >  ifdef PTXCONF_GCCLIBS_LIBTSAN
> > -	@$(call install_copy_toolchain_lib, gcclibs, liblsan.so)
> > +	@$(call install_copy_toolchain_lib, gcclibs, libtsan.so)
> >  endif
> >  
> >  ifdef PTXCONF_GCCLIBS_LIBUBSAN
> >  	@$(call install_copy_toolchain_lib, gcclibs, libubsan.so)
> >  endif
> > -- 
> > 2.19.2
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> 
> -- 
> Roland Hieber                     | r.hieber@pengutronix.de     |
> Pengutronix e.K.                  | https://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2019-01-10 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22  2:07 Roland Hieber
2019-01-08 13:54 ` Roland Hieber
2019-01-10 11:44   ` Roland Hieber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110114430.tep5drr4cgpnlktj@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox