From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] kconfig: fix warnings on format
Date: Wed, 2 Jan 2019 15:03:48 +0100 [thread overview]
Message-ID: <20190102140348.o4gxkctubguc4ncq@pengutronix.de> (raw)
In-Reply-To: <1545139596.6178.3.camel@diehl.com>
On Tue, Dec 18, 2018 at 01:26:37PM +0000, Denis OSTERLAND wrote:
> Am Mittwoch, den 12.12.2018, 14:06 +0000 schrieb Denis OSTERLAND:
> > Am Mittwoch, den 12.12.2018, 14:29 +0100 schrieb Michael Olbrich:
> > >
> > > On Wed, Dec 12, 2018 at 10:31:27AM +0000, Denis OSTERLAND wrote:
> > > >
> > > >
> > > > Fixes warnings like:
> > > > conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
> > > > printf(_("aborted!\n\n"));
> > > > ^
> > > Can you elaborate what triggers this? I don't get this warning here.
> > > Please add this to the commit message.
> > Just call make clean all.
> > Maybe it depends on GCC.
> > I tested with:
> > - gcc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010
> > - gcc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0
> I have tested with Debian Buster and Ubuntu Bionic now.
> On Ubuntu I get these warnings, but on Debian not.
> Maybe Ubuntu configures GCC other than Debian on compile time.
Ok, I'll apply this. This code will be gone anyways once we update kconfig
to the latest version from Linux.
Michael
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2019-01-02 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:31 Denis OSTERLAND
2018-12-12 13:29 ` Michael Olbrich
2018-12-12 14:06 ` Denis OSTERLAND
2018-12-18 13:26 ` Denis OSTERLAND
2019-01-02 14:03 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102140348.o4gxkctubguc4ncq@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox