mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Cc: Gavin Schenk <g.schenk@eckelmann.de>
Subject: Re: [ptxdist] [PATCH v2] squashfs-tools: Use sysmacros fixes build with glib >2.28
Date: Tue, 18 Dec 2018 13:00:13 +0100	[thread overview]
Message-ID: <20181218120013.GA2995@lenoch> (raw)
In-Reply-To: <20181218111611.25259-1-g.schenk@eckelmann.de>

On Tue, Dec 18, 2018 at 12:16:11PM +0100, Gavin Schenk wrote:
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
> 
> changes since v1:
> 
> - Add include instead replacing it.
>   After a discussion with ukl in IRC, it turns out that it is more
>   compatible to add the include instead of replacing it. Additionally,
>   mksquashfs.c uses open that requires sys/types.h.

Thank you, I was about to send the same fix :)
(except there's a typo in subject as glib and glibc are different libraries)

Additionally, we'll need this one:
https://github.com/paulusmack/ppp/commit/3c7b86229f7bd2600d74db14b1fe5b3896be3875
and then at91bootstrap broke yet another time with OSELAS.Toolchain-2018.12.0
Unless someone is going to be faster I'll send fixes later today.

But that brings a question whenever we want/need something to compare glibc
versions as I do not think it is good idea to add openssl (to ppp) dependency
for everyone, even those using pre-2.28 glibc.

	ladis

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-12-18 12:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 10:32 [ptxdist] [PATCH] " Gavin Schenk
2018-12-18 11:16 ` [ptxdist] [PATCH v2] " Gavin Schenk
2018-12-18 12:00   ` Ladislav Michl [this message]
2018-12-19  6:54     ` [ptxdist] [PATCH v3] squashfs-tools: Use sysmacros fixes build with glibc >= 2.28 Gavin Schenk
2018-12-19  7:04       ` [ptxdist] [PATCH v4] " Gavin Schenk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218120013.GA2995@lenoch \
    --to=ladis@linux-mips.org \
    --cc=g.schenk@eckelmann.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox