Re: [ptxdist] [PATCH v2 2/4] barebox: depend on HOST_LZOP

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Dec 13, 2018 at 01:02:50PM +0000, Baeuerle, Florian wrote:
> Am Donnerstag, den 13.12.2018, 12:16 +0100 schrieb Michael Olbrich:
> > On Wed, Dec 12, 2018 at 02:52:54PM +0000, Baeuerle, Florian wrote:
> > > The version shipped by ptxdist allows us to override the modification
> > > time in the lzop headers.
> > > 
> > > Signed-off-by: Florian Bäuerle <florian.baeuerle@allegion.com>
> > > ---
> > >  platforms/barebox.in | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/platforms/barebox.in b/platforms/barebox.in
> > > index 645366e93..46ab32a07 100644
> > > --- a/platforms/barebox.in
> > > +++ b/platforms/barebox.in
> > > @@ -12,7 +12,7 @@ menuconfig BAREBOX
> > >  	select HOST_LIBUSB if BAREBOX_NEEDS_HOST_LIBUSB
> > >  	select HOST_OPENSSL if BAREBOX_NEEDS_HOST_OPENSSL
> > >  	select HOST_IMX_CST if BAREBOX_NEEDS_HOST_IMX_CST
> > > -	select HOST_LZOP if BAREBOX_NEEDS_HOST_LZOP
> > > +	select HOST_LZOP if BAREBOX_NEEDS_HOST_LZOP ||
> > > !SETUP_DISABLE_REPRODUCIBLE
> > 
> > This does not work. You will need to enable BAREBOX_NEEDS_HOST_LZOP
> > manually if lzop is used by barebox.
> 
> Oops, you're right – in the platformconfig menu all SETUP_ symbols seem to be
> undefined. Anyway, it's probably a bad idea to depend on regenerating a
> platformconfig when the user en/disables user properties.
> 
> Can I just make barebox unconditionally depend on HOST_LZOP?
> 
> Other suggestions?

Why not leave it as is? lzop is not always used in barebox. You should
enable BAREBOX_NEEDS_HOST_LZOP if lzop compression is used in barebox.
That's the use-case for this option.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de