From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files
Date: Tue, 11 Dec 2018 08:55:18 +0100 [thread overview]
Message-ID: <20181211075518.mjxrcedlgahpl5ic@pengutronix.de> (raw)
In-Reply-To: <589275efb43fce551aab6c6cf6b47a5d44a564d8.camel@allegion.com>
Hi,
On Mon, Dec 10, 2018 at 04:05:18PM +0000, Baeuerle, Florian wrote:
> I think .done is actually required.
>
> $ ptxdist migrate [...]
> ptxdist: error: PTXdist in /usr/local/lib/ptxdist-2018.11.0 is not built.
>
> I tried to install ptxdist from git master (./autogen.sh; ./configure; make
> install)
>
> For reference:
> https://git.pengutronix.de/cgit/ptxdist/tree/bin/ptxdist?id=master#n2160
Indeed. Thank you for catching this. I need to do more tests with installed
versions of ptxdist.
Fixed in master.
Michael
> Am Dienstag, den 13.11.2018, 21:10 +0100 schrieb Roland Hieber:
> > From: Roland Hieber <rohieb@rohieb.name>
> >
> > .done is created by make all, and is an empty file.
> > .gitignore is only resonable in git repositories, and we exclude .git/.
> > vim swap files happen sometimes (e.g. when editing the makefile).
> >
> > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> >
> > ---
> > v1 -> v2: use the right filename for .gitignore, and add vim swap files
> > ---
> > Makefile.in | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Makefile.in b/Makefile.in
> > index 40c676c2b..26e75b00b 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -101,7 +101,10 @@ install: all dirty-check
> > @mkdir -p "$(DESTDIR)$(instdir)"
> > @tar -C "$(abs_srcdir)" -cf - \
> > --exclude *~ \
> > + --exclude .*.sw* \
> > + --exclude .done \
> > --exclude .git \
> > + --exclude .gitignore \
> > --exclude .pc \
> > --exclude .svn \
> > --exclude autom4te.cache \
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-12-11 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 19:53 [ptxdist] [PATCH] Makefile: don't install files .done and .gitignore Roland Hieber
2018-11-13 20:10 ` [ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files Roland Hieber
2018-11-13 20:54 ` Uwe Kleine-König
2018-12-10 16:05 ` Baeuerle, Florian
2018-12-11 7:55 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211075518.mjxrcedlgahpl5ic@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox