Re: [ptxdist] [PATCH 2/2] rules: systemd: Change hardcoded polkit configure option

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Dec 10, 2018 at 02:18:11PM +0000, Dold, Wolfram wrote:
> For the polkit framework to work at all,
> you have to enable polkit in systemd via
> the configure option.
> ---
>  rules/systemd.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/systemd.make b/rules/systemd.make
> index bad43049f..2134df1d3 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -119,7 +119,7 @@ SYSTEMD_CONF_OPT	:= \
>  	-Doss-fuzz=false \
>  	-Dpam=false \
>  	-Dpcre2=false \
> -	-Dpolkit=false \
> +	-Dpolkit=$(call ptx/truefalse, PTXCONF_POLKIT_SYSTEMD) \

No, using variables of other packages like this is not allowed. If you do
this, then systemd won't be rebuilt if PTXCONF_POLKIT_SYSTEMD changes. You
need to define and use:

config SYSTEMD_POLKIT
	bool
	default POLKIT_SYSTEMD

The options will have the same value, but ptxdist will notice changes and
reconfigure systemd when appropriate.

Michael

>  	-Dportabled=false \
>  	-Dqrencode=false \
>  	-Dquotacheck=true \
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de