From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Thorsten K. Scherer" <t.scherer@eckelmann.de>
Subject: Re: [ptxdist] [PATCH 2/5] ptxdist: add tpm2-tss version 2.1.0
Date: Mon, 3 Dec 2018 09:40:46 +0100 [thread overview]
Message-ID: <20181203084046.kkhxugkdetb2tl3b@pengutronix.de> (raw)
In-Reply-To: <2cd9be64-4a60-8779-53af-987bbd8ea148@pengutronix.de>
Hello Marc,
On Wed, Nov 28, 2018 at 09:02:10AM +0100, Marc Kleine-Budde wrote:
> On 11/26/18 11:23 AM, Thorsten K. Scherer wrote:
> > Signed-off-by: Thorsten K. Scherer <t.scherer@eckelmann.de>
> > ---
> > ...rom-the-list-of-libs-to-link-against.patch | 21 ++++++
> > patches/tpm2-tss-2.1.0/series | 4 ++
> > rules/tpm.in | 5 ++
> > rules/tpm2-tss.in | 22 +++++++
> > rules/tpm2-tss.make | 66 +++++++++++++++++++
> > 5 files changed, 118 insertions(+)
> > create mode 100644 patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch
> > create mode 100644 patches/tpm2-tss-2.1.0/series
> > create mode 100644 rules/tpm.in
> > create mode 100644 rules/tpm2-tss.in
> > create mode 100644 rules/tpm2-tss.make
> >
> > diff --git a/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch
> > new file mode 100644
> > index 0000000..0230570
> > --- /dev/null
> > +++ b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch
> > @@ -0,0 +1,21 @@
> > +From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
> > +Date: Fri, 12 Oct 2018 11:13:42 +0200
> > +Subject: [PATCH] drop -lgcrypt from the list of libs to link against
> > +
> > +If --with-crypto=ossl is used -lgcrypt is wrong. There shouldn't be any need
> > +to explicitly tell the linker because the library already depends the chosen
> > +crypto lib
>
> S-o-b missing
I'm unsure why you think a S-o-b is necessary here. The upstream project
requires a S-o-b by the submitter (who is not necessarily the patch
author) only when the patch is sent to them for application. And in my
eyes the S-o-b on the ptxdist-patch already covers that the whole
content (so including the added patch file) is compatible with ptxdist's
license.
Can you clearify?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-12-03 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 10:23 Thorsten K. Scherer
2018-11-28 7:53 ` Michael Olbrich
2018-11-28 8:02 ` Marc Kleine-Budde
2018-12-03 8:40 ` Uwe Kleine-König [this message]
2018-12-10 12:45 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203084046.kkhxugkdetb2tl3b@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=t.scherer@eckelmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox