From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Cc: "Thorsten K. Scherer" <t.scherer@eckelmann.de>
Subject: Re: [ptxdist] [PATCH 3/5] ptxdist: add tpm2-tools 3.1.2
Date: Wed, 28 Nov 2018 09:30:02 +0100 [thread overview]
Message-ID: <20181128083001.GA29353@lenoch> (raw)
In-Reply-To: <f4156fee-cc6e-d489-8010-54561cc12f5e@pengutronix.de>
On Wed, Nov 28, 2018 at 08:57:30AM +0100, Marc Kleine-Budde wrote:
> On 11/26/18 11:23 AM, Thorsten K. Scherer wrote:
> > Signed-off-by: Thorsten K. Scherer <t.scherer@eckelmann.de>
> > ---
> > rules/tpm2-tools.in | 92 ++++++++++++++++++++++++++++
> > rules/tpm2-tools.make | 137 ++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 229 insertions(+)
> > create mode 100644 rules/tpm2-tools.in
> > create mode 100644 rules/tpm2-tools.make
> >
> > diff --git a/rules/tpm2-tools.in b/rules/tpm2-tools.in
> > new file mode 100644
> > index 0000000..85638f7
> > --- /dev/null
> > +++ b/rules/tpm2-tools.in
> > @@ -0,0 +1,92 @@
> > +## SECTION=tpm
> > +menuconfig TPM2_TOOLS
> > + tristate
> > + prompt "tpm2-tools "
> > + select TPM2_TSS
> > + select OPENSSL
> > + select LIBCURL
> > + help
> > + This package contains a set of tools to use with TPM 2.0
> > + chips, for common tasks and features provided by the
> > + hardware; such as for doing basic key management,
> > + attestation, encryption and signing.
> > +
> > + See https://github.com/tpm2-software/tpm2-tools for details
> > +
> > +if TPM2_TOOLS
> > +
> > +config TPM2_TOOLS_START_UP
> > + bool "Start-up"
> > + help
> > + tpm2_startup
> > +
> > +config TPM2_TOOLS_OBJECT
> > + bool "Object"
> > + help
> > + tpm2_create, tpm2_createprimary, tpm2_load, tpm2_loadexternal, \
> > + tpm2_readpublic, tpm2_activatecredential, tpm2_makecredential, \
> > + tpm2_unseal
>
> No need for \ in the help text
Also whitespaces should be fixed - tabs vs spaces. It's all over those patches.
> > +config TPM2_TOOLS_ASYMMETRIC_PRIMITIVES
> > + bool "Asymmetric primitives"
> > + help
> > + tpm2_rsaencrypt, tpm2_rsadecrypt
> > +
> > +config TPM2_TOOLS_SYMMETRIC_PRIMITIVES
> > + bool "Symmetric primitives"
> > + help
> > + tpm2_encryptdecrypt, tpm2_hash, tpm2_hmac
> > +
> > +config TPM2_TOOLS_RANDOM_NUMBER_GENERATOR
> > + bool "Random number generator"
> > + help
> > + tpm2_getrandom
> > +
> > +config TPM2_TOOLS_ATTESTATION
> > + bool "Attestation"
> > + help
> > + tpm2_certify, tpm2_quote
> > +
> > +config TPM2_TOOLS_SIGNING_AND_SIGNATURE_VERIFICATION
> > + bool "Signing and signature verification"
> > + help
> > + tpm2_sign, tpm2_verifysignature
> > +
> > +config TPM2_TOOLS_INTEGRITY
> > + bool "Integrity"
> > + help
> > + tpm2_pcrextend, tpm2_pcrevent, tpm2_pcrlist
> > +
> > +config TPM2_TOOLS_ENHANCED_AUTHORISATION
> > + bool "Enhanced authorisation (EA)"
> > + help
> > + tpm2_createpolicy
> > +
> > +config TPM2_TOOLS_DICTIONARY_ATTACK
> > + bool "Dictionary attack"
> > + help
> > + tpm2_dictionarylockout
> > +
> > +config TPM2_TOOLS_CONTEXT_MANAGEMENT
> > + bool "Context management"
> > + help
> > + tpm2_evictcontrol
> > +
> > +config TPM2_TOOLS_CAPABILITY_COMMANDS
> > + bool "Capability commands"
> > + help
> > + tpm2_getcap
> > +
> > +config TPM2_TOOLS_NON_VOLATILE_STORAGE
> > + bool "Non-volatile storage"
> > + help
> > + tpm2_nvdefine, tpm2_nvlist, tpm2_nvread, tpm2_nvreadlock, \
> > + tpm2_nvrelease, tpm2_nvwrite
>
> same here
>
> >
> > +config TPM2_TOOLS_MISC
> > + bool "Miscellaneous"
> > + help
> > + tpm2_send, tpm2_getmanufec, tpm2_getpubak, tpm2_getpubek, \
> > + tpm2_listpersistent, tpm2_rc_decode, tpm2_takeownership
>
> same here
>
> > +
> > +endif
> > diff --git a/rules/tpm2-tools.make b/rules/tpm2-tools.make
> > new file mode 100644
> > index 0000000..3bee70d
> > --- /dev/null
> > +++ b/rules/tpm2-tools.make
> > @@ -0,0 +1,137 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2017 by Marc Kleine-Budde <m...@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_TPM2_TOOLS) += tpm2-tools
> > +
> > +#
> > +# Paths and names
> > +#
> > +TPM2_TOOLS_VERSION := 3.1.2
>
> 3.1.3 is the latest release
>
> > +TPM2_TOOLS_MD5 := aa8e0f61608bd02a2b0082dafceddb60
> > +TPM2_TOOLS := tpm2-tools-$(TPM2_TOOLS_VERSION)
> > +TPM2_TOOLS_SUFFIX := tar.gz
> > +TPM2_TOOLS_URL := https://github.com/01org/tpm2-tools.git;tag=$(TPM2_TOOLS_VERSION)
> > +TPM2_TOOLS_SOURCE := $(SRCDIR)/$(TPM2_TOOLS).$(TPM2_TOOLS_SUFFIX)
> > +TPM2_TOOLS_DIR := $(BUILDDIR)/$(TPM2_TOOLS)
> > +TPM2_TOOLS_LICENSE := BSD-3-Clause
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +#
> > +# autoconf
> > +#
> > +TPM2_TOOLS_CONF_TOOL := autoconf
> > +TPM2_TOOLS_CONF_OPT := $(CROSS_AUTOCONF_USR)
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/tpm2-tools.targetinstall:
> > + @$(call targetinfo)
> > +
> > + @$(call install_init, tpm2-tools)
> > + @$(call install_fixup, tpm2-tools,PRIORITY,optional)
> > + @$(call install_fixup, tpm2-tools,SECTION,base)
> > + @$(call install_fixup, tpm2-tools,AUTHOR,"Marc Kleine-Budde <m...@pengutronix.de>")
> > + @$(call install_fixup, tpm2-tools,DESCRIPTION,missing)
> > +
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_START_UP
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_startup)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_OBJECT
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_create)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_createprimary)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_load)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_loadexternal)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_readpublic)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_activatecredential)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_makecredential)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_unseal)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_ASYMMETRIC_PRIMITIVES
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_rsaencrypt)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_rsadecrypt)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_SYMMETRIC_PRIMITIVES
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_encryptdecrypt)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_hash)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_hmac)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_RANDOM_NUMBER_GENERATOR
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_getrandom)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_ATTESTATION
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_certify)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_quote)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_SIGNING_AND_SIGNATURE_VERIFICATION
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_sign)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_verifysignature)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_INTEGRITY
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_pcrextend)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_pcrevent)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_pcrlist)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_ENHANCED_AUTHORISATION
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_createpolicy)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_DICTIONARY_ATTACK
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_dictionarylockout)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_CONTEXT_MANAGEMENT
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_evictcontrol)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_CAPABILITY_COMMANDS
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_getcap)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_NON_VOLATILE_STORAGE
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvdefine)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvlist)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvread)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvreadlock)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvrelease)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_nvwrite)
> > +endif
> > +
> > +ifdef PTXCONF_TPM2_TOOLS_MISC
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_send)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_getmanufec)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_getpubak)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_getpubek)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_listpersistent)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_rc_decode)
> > + $(call install_copy, tpm2-tools, tss, tss, 0755, -, /usr/bin/tpm2_takeownership)
> > +endif
> > +
> > + @$(call install_finish, tpm2-tools)
> > +
> > + @$(call touch)
> > +
> > +# vim: syntax=make
> >
>
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-11-28 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 10:23 Thorsten K. Scherer
2018-11-28 7:57 ` Marc Kleine-Budde
2018-11-28 8:30 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128083001.GA29353@lenoch \
--to=ladis@linux-mips.org \
--cc=ptxdist@pengutronix.de \
--cc=t.scherer@eckelmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox