Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle git://file:

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hello,

On Tue, Nov 20, 2018 at 03:41:19PM +0000, Горелов Валентин Владимирович wrote:
> I've been using your system for a long time and I find it very
> convenient. But unfortunately,  it is unable to get sources from local
> folder-based Git repositories. That would be useful.
> I've made a patch to add this function. May I expect it (or refurbished
> version of it) to be included in a future release?

Please provide a patch with a proper patch header and including a
Signed-of-by line.
And I prefer patches inline (sent with 'git send-email') but attachments
are ok as well.

About the patch:

> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 17c515644..7c00fe149 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -394,6 +394,13 @@ ptxd_make_get() {
>  		shift
>  
>  		case "${url}" in
> +		git://file:*)

I think git+file:// is a better syntax for this.

> +			echo "local git repository, removing git://file: prefix from URL"
> +			url=${url#git://file:}
> +

Instead of this:

> +			ptxd_make_get_download_permitted &&
> +			ptxd_make_get_git && return
> +			;;

do this:
			;&

That's the fall-though for bash 'case' statements.

Michael

>  		git://*|http://*.git|https://*.git|ssh://*.git)
>  			ptxd_make_get_download_permitted &&
>  			ptxd_make_get_git && return

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de