Re: [ptxdist] [PATCH] classpath: Fix for building with OpenJDK-1.8 (again)

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Nov 19, 2018 at 10:30:06AM +0100, Guillermo Rodriguez Garcia wrote:
> El sáb., 17 nov. 2018 a las 14:50, Michael Olbrich
> (<m.olbrich@pengutronix.de>) escribió:
> >
> > On Sat, Nov 17, 2018 at 01:33:19AM +0100, Guillermo Rodriguez Garcia wrote:
> > > El viernes, 16 de noviembre de 2018, Michael Olbrich <
> > > m.olbrich@pengutronix.de> escribió:
> > >
> > > > On Fri, Nov 16, 2018 at 12:20:18PM +0100, Guillermo Rodríguez wrote:
> > > > > Commit bbc978e623cafc added a patch intended to fix building
> > > > > with OpenJDK 1.8, however that commit was not complete. It is
> > > > > necessary to run autogen.sh so that the configure script is
> > > > > regenerated and the patched m4 macros are used.
> > > > >
> > > > > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > > >
> > > > Unfortunately it's not that simple. The */Makefile.am also need the
> > > > 1.5 -> 1.6 change. I tried that an then I get lots of errors like this:
> > > >
> > > > warning: as of release 9, '_' is a keyword, and may not be used as an
> > > > identifier
> > >
> > >
> > > Uhm, those are not errors, they are warnings (as long as we specify -target
> > > < 9, which is the case here). Anyway from these messages it looks like you
> > > are building with OpenJDK9? That is not supposed to work; the intent of the
> > > patch was to allow building with OpenJDK8... can you check the version of
> > > javac?
> >
> > Right, I missed the errors because of all those warnings:
> > [...]/classpath-0.99/java/util/regex/Matcher.java:623: error: unmappable character (0xC2) for encoding US-ASCII
> >    *??@since 1.5
> >     ^
> >
> > There is some white-space there that does not match the selected encoding,
> > I think. If I replace this with a space, then building the package
> > succeeds.
> > So please add the Makefile.am changes to the first patch and create another
> > to fix this whitespace.
> 
> Please let me have a look at this.
> 
> However, can you confirm which javac are you using? I believe javac
> from OpenJDK 1.8 should not require any of this.

It the current default jdk from Debian unstable. That's OpenJDK 11.

Anyways, the new patches work as expected and are now in master. Thanks!

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de