[ptxdist] [PATCH] Makefile: don't install files .done and .gitignore

[ptxdist] [PATCH] Makefile: don't install files .done and .gitignore

[Roland Hieber]

From: Roland Hieber <rohieb@rohieb.name>

.done is created by make all, and is an empty file.
.gitignore is only resonable in git repositories, and we exclude .git/.

Signed-off-by: Roland Hieber <rohieb@rohieb.name>
---
 Makefile.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile.in b/Makefile.in
index 40c676c2b..2ad26d432 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -101,6 +101,8 @@ install: all dirty-check
 	@mkdir -p "$(DESTDIR)$(instdir)"
 	@tar -C "$(abs_srcdir)" -cf - \
 		--exclude *~ \
+		--exclude .done \
+		--exclude .git \
 		--exclude .git \
 		--exclude .pc \
 		--exclude .svn \
-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files

[Roland Hieber]

From: Roland Hieber <rohieb@rohieb.name>

.done is created by make all, and is an empty file.
.gitignore is only resonable in git repositories, and we exclude .git/.
vim swap files happen sometimes (e.g. when editing the makefile).

Signed-off-by: Roland Hieber <rohieb@rohieb.name>

---
v1 -> v2: use the right filename for .gitignore, and add vim swap files
---
 Makefile.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile.in b/Makefile.in
index 40c676c2b..26e75b00b 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -101,7 +101,10 @@ install: all dirty-check
 	@mkdir -p "$(DESTDIR)$(instdir)"
 	@tar -C "$(abs_srcdir)" -cf - \
 		--exclude *~ \
+		--exclude .*.sw* \
+		--exclude .done \
 		--exclude .git \
+		--exclude .gitignore \
 		--exclude .pc \
 		--exclude .svn \
 		--exclude autom4te.cache \
-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files

[Uwe Kleine-König]

Hello Roland,

On Tue, Nov 13, 2018 at 09:10:56PM +0100, Roland Hieber wrote:
> .gitignore is only resonable in git repositories, and we exclude .git/.

s/resonable/reasonable/

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files

[Baeuerle, Florian]

Hi,

I think .done is actually required.

$ ptxdist migrate [...]
ptxdist: error: PTXdist in /usr/local/lib/ptxdist-2018.11.0 is not built.

I tried to install ptxdist from git master (./autogen.sh; ./configure; make
install)

For reference:
https://git.pengutronix.de/cgit/ptxdist/tree/bin/ptxdist?id=master#n2160


Best regards
Florian

Am Dienstag, den 13.11.2018, 21:10 +0100 schrieb Roland Hieber:
> From: Roland Hieber <rohieb@rohieb.name>
> 
> .done is created by make all, and is an empty file.
> .gitignore is only resonable in git repositories, and we exclude .git/.
> vim swap files happen sometimes (e.g. when editing the makefile).
> 
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> 
> ---
> v1 -> v2: use the right filename for .gitignore, and add vim swap files
> ---
>  Makefile.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Makefile.in b/Makefile.in
> index 40c676c2b..26e75b00b 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -101,7 +101,10 @@ install: all dirty-check
>  	@mkdir -p "$(DESTDIR)$(instdir)"
>  	@tar -C "$(abs_srcdir)" -cf - \
>  		--exclude *~ \
> +		--exclude .*.sw* \
> +		--exclude .done \
>  		--exclude .git \
> +		--exclude .gitignore \
>  		--exclude .pc \
>  		--exclude .svn \
>  		--exclude autom4te.cache \
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH v2] Makefile: don't install .done, .gitignore and vim swap files

[Michael Olbrich]

Hi,

On Mon, Dec 10, 2018 at 04:05:18PM +0000, Baeuerle, Florian wrote:
> I think .done is actually required.
> 
> $ ptxdist migrate [...]
> ptxdist: error: PTXdist in /usr/local/lib/ptxdist-2018.11.0 is not built.
> 
> I tried to install ptxdist from git master (./autogen.sh; ./configure; make
> install)
> 
> For reference:
> https://git.pengutronix.de/cgit/ptxdist/tree/bin/ptxdist?id=master#n2160

Indeed. Thank you for catching this. I need to do more tests with installed
versions of ptxdist.

Fixed in master.

Michael

> Am Dienstag, den 13.11.2018, 21:10 +0100 schrieb Roland Hieber:
> > From: Roland Hieber <rohieb@rohieb.name>
> > 
> > .done is created by make all, and is an empty file.
> > .gitignore is only resonable in git repositories, and we exclude .git/.
> > vim swap files happen sometimes (e.g. when editing the makefile).
> > 
> > Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> > 
> > ---
> > v1 -> v2: use the right filename for .gitignore, and add vim swap files
> > ---
> >  Makefile.in | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Makefile.in b/Makefile.in
> > index 40c676c2b..26e75b00b 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -101,7 +101,10 @@ install: all dirty-check
> >  	@mkdir -p "$(DESTDIR)$(instdir)"
> >  	@tar -C "$(abs_srcdir)" -cf - \
> >  		--exclude *~ \
> > +		--exclude .*.sw* \
> > +		--exclude .done \
> >  		--exclude .git \
> > +		--exclude .gitignore \
> >  		--exclude .pc \
> >  		--exclude .svn \
> >  		--exclude autom4te.cache \
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de