mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] imx-kobs: New package
@ 2018-10-23  9:23 Guillermo Rodríguez
  2018-10-23 10:59 ` Alexander Dahl
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Guillermo Rodríguez @ 2018-10-23  9:23 UTC (permalink / raw)
  To: ptxdist; +Cc: Guillermo Rodríguez

The imx-kobs tool is used to create and write i.MX NAND boot
related boot data structures to NAND flash.

Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
---
 rules/imx-kobs.in   |  8 ++++++++
 rules/imx-kobs.make | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
 create mode 100644 rules/imx-kobs.in
 create mode 100644 rules/imx-kobs.make

diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
new file mode 100644
index 0000000..e00ca24
--- /dev/null
+++ b/rules/imx-kobs.in
@@ -0,0 +1,8 @@
+## SECTION=shell_and_console
+
+config IMX_KOBS
+	tristate
+	prompt "imx-kobs"
+	help
+	  The imx-kobs tool is used to create and write i.MX NAND boot
+	  related boot data structures to NAND flash.
diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
new file mode 100644
index 0000000..49380c2
--- /dev/null
+++ b/rules/imx-kobs.make
@@ -0,0 +1,53 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
+
+#
+# Paths and names
+#
+IMX_KOBS_VERSION	:= 5.5
+IMX_KOBS_SUFFIX		:= tar.gz
+IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
+IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
+IMX_KOBS_URL		:= http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
+IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
+IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
+IMX_KOBS_LICENSE	:= GPLv2
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+IMX_KOBS_CONF_TOOL	:= autoconf
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/imx-kobs.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, imx-kobs)
+	@$(call install_fixup, imx-kobs, PRIORITY, optional)
+	@$(call install_fixup, imx-kobs, SECTION, base)
+	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez <guille.rodriguez@gmail.com>")
+	@$(call install_fixup, imx-kobs, DESCRIPTION, missing)
+
+	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
+
+	@$(call install_finish, imx-kobs)
+
+	@$(call touch)
+	
+# vim: syntax=make	
-- 
1.9.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23  9:23 [ptxdist] [PATCH] imx-kobs: New package Guillermo Rodríguez
@ 2018-10-23 10:59 ` Alexander Dahl
  2018-10-23 11:41   ` Alexander Dahl
  2018-10-23 12:38   ` Guillermo Rodriguez Garcia
  2018-10-23 13:09 ` Michael Olbrich
  2018-10-23 14:17 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
  2 siblings, 2 replies; 11+ messages in thread
From: Alexander Dahl @ 2018-10-23 10:59 UTC (permalink / raw)
  To: ptxdist; +Cc: Guillermo Rodríguez

Hei hei,

this is strange, I was just working on a new package for the very same tool. 
o.O

Am Dienstag, 23. Oktober 2018, 11:23:36 CEST schrieb Guillermo Rodríguez:
> The imx-kobs tool is used to create and write i.MX NAND boot
> related boot data structures to NAND flash.
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/imx-kobs.in   |  8 ++++++++
>  rules/imx-kobs.make | 53
> +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61
> insertions(+)
>  create mode 100644 rules/imx-kobs.in
>  create mode 100644 rules/imx-kobs.make
> 
> diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> new file mode 100644
> index 0000000..e00ca24
> --- /dev/null
> +++ b/rules/imx-kobs.in
> @@ -0,0 +1,8 @@
> +## SECTION=shell_and_console
> +
> +config IMX_KOBS
> +	tristate
> +	prompt "imx-kobs"
> +	help
> +	  The imx-kobs tool is used to create and write i.MX NAND boot
> +	  related boot data structures to NAND flash.
> diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> new file mode 100644
> index 0000000..49380c2
> --- /dev/null
> +++ b/rules/imx-kobs.make
> @@ -0,0 +1,53 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> +
> +#
> +# Paths and names
> +#
> +IMX_KOBS_VERSION	:= 5.5
> +IMX_KOBS_SUFFIX		:= tar.gz
> +IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
> +IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
> +IMX_KOBS_URL		:=
> http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFI

How did you find this? I would have taken the tool from GitHub:

https://github.com/NXPmicro/imx-kobs

That one is without tags however.

> X) +IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
> +IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_LICENSE	:= GPLv2

GPL-2.0-or-later

What about IMX_KOBS_LICENSE_FILES  := file://COPYING;md5=…

> +
> +#
> ---------------------------------------------------------------------------
> - +# Prepare
> +#
> ---------------------------------------------------------------------------
> - +
> +IMX_KOBS_CONF_TOOL	:= autoconf
> +
> +#
> ---------------------------------------------------------------------------
> - +# Target-Install
> +#
> ---------------------------------------------------------------------------
> - +
> +$(STATEDIR)/imx-kobs.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, imx-kobs)
> +	@$(call install_fixup, imx-kobs, PRIORITY, optional)
> +	@$(call install_fixup, imx-kobs, SECTION, base)
> +	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez
> <guille.rodriguez@gmail.com>") +	@$(call install_fixup, imx-kobs,
> DESCRIPTION, missing)
> +
> +	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
> +
> +	@$(call install_finish, imx-kobs)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23 10:59 ` Alexander Dahl
@ 2018-10-23 11:41   ` Alexander Dahl
  2018-10-23 12:38   ` Guillermo Rodriguez Garcia
  1 sibling, 0 replies; 11+ messages in thread
From: Alexander Dahl @ 2018-10-23 11:41 UTC (permalink / raw)
  To: ptxdist; +Cc: Guillermo Rodríguez

Hello, 

Am Dienstag, 23. Oktober 2018, 12:59:56 CEST schrieb Alexander Dahl:
> Am Dienstag, 23. Oktober 2018, 11:23:36 CEST schrieb Guillermo Rodríguez:
> > +IMX_KOBS_VERSION	:= 5.5
> > +IMX_KOBS_SUFFIX		:= tar.gz
> > +IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
> > +IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
> > +IMX_KOBS_URL		:=
> > http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFF
> > I
> 
> How did you find this? 

Also, that URL redirects to this one:

https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/imx-kobs-5.5.tar.gz

> I would have taken the tool from GitHub:
> 
> https://github.com/NXPmicro/imx-kobs
> 
> That one is without tags however.

The only difference I see is in the README, so we probably can use that 
tarball:

--- imx-kobs/README     2018-10-01 15:07:10.285277014 +0200
+++ imx-kobs-5.5/README 2016-04-20 04:39:46.000000000 +0200
@@ -1,5 +1,3 @@
-imx-kobs version 5.5  GPL-2.0
-
 If you want to compile it in cross environment.
 Please try the following :
-       #./configure CC=arm-none-linux-gnueabihf-gcc --host=arm-none-linux-
gnueabihf-gcc
+       #./configure CC=arm-none-linux-gnueabi-gcc --host=arm-none-linux-
gnueabi-gcc

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23 10:59 ` Alexander Dahl
  2018-10-23 11:41   ` Alexander Dahl
@ 2018-10-23 12:38   ` Guillermo Rodriguez Garcia
  2018-10-23 12:43     ` Uwe Kleine-König
  2018-10-23 12:48     ` Alexander Dahl
  1 sibling, 2 replies; 11+ messages in thread
From: Guillermo Rodriguez Garcia @ 2018-10-23 12:38 UTC (permalink / raw)
  To: ada; +Cc: ptxdist

Hi Alexander,

El mar., 23 oct. 2018 a las 13:00, Alexander Dahl (<ada@thorsis.com>) escribió:
>
> Hei hei,
>
> this is strange, I was just working on a new package for the very same tool.
> o.O

:)

> Am Dienstag, 23. Oktober 2018, 11:23:36 CEST schrieb Guillermo Rodríguez:
> > The imx-kobs tool is used to create and write i.MX NAND boot
> > related boot data structures to NAND flash.
> >
> > Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > ---
> >  rules/imx-kobs.in   |  8 ++++++++
> >  rules/imx-kobs.make | 53
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61
> > insertions(+)
> >  create mode 100644 rules/imx-kobs.in
> >  create mode 100644 rules/imx-kobs.make
> >
> > diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> > new file mode 100644
> > index 0000000..e00ca24
> > --- /dev/null
> > +++ b/rules/imx-kobs.in
> > @@ -0,0 +1,8 @@
> > +## SECTION=shell_and_console
> > +
> > +config IMX_KOBS
> > +     tristate
> > +     prompt "imx-kobs"
> > +     help
> > +       The imx-kobs tool is used to create and write i.MX NAND boot
> > +       related boot data structures to NAND flash.
> > diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> > new file mode 100644
> > index 0000000..49380c2
> > --- /dev/null
> > +++ b/rules/imx-kobs.make
> > @@ -0,0 +1,53 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> > +
> > +#
> > +# Paths and names
> > +#
> > +IMX_KOBS_VERSION     := 5.5
> > +IMX_KOBS_SUFFIX              := tar.gz
> > +IMX_KOBS_MD5         := 48ed9e69e9527d2e98b5cfcbf133d75b
> > +IMX_KOBS             := imx-kobs-$(IMX_KOBS_VERSION)
> > +IMX_KOBS_URL         :=
> > http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFI
>
> How did you find this? I would have taken the tool from GitHub:

I have to admit I am not sure anymore where I found this. When
cleaning up the .make file I considered switching to github, but at
the end I chose not to do it as it had no tags and I thought that this
would be cleaner than referencing a specific commit by its hash.

> https://github.com/NXPmicro/imx-kobs
>
> That one is without tags however.
>
> > X) +IMX_KOBS_DIR              := $(BUILDDIR)/$(IMX_KOBS)
> > +IMX_KOBS_SOURCE              := $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> > +IMX_KOBS_LICENSE     := GPLv2
>
> GPL-2.0-or-later

OK.

> What about IMX_KOBS_LICENSE_FILES  := file://COPYING;md5=…

Never did this before, I thought it was only necessary for
not-well-known licenses. Should I add it?

Thanks,

Guillermo

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23 12:38   ` Guillermo Rodriguez Garcia
@ 2018-10-23 12:43     ` Uwe Kleine-König
  2018-10-23 12:48     ` Alexander Dahl
  1 sibling, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2018-10-23 12:43 UTC (permalink / raw)
  To: ptxdist; +Cc: ada

On Tue, Oct 23, 2018 at 02:38:55PM +0200, Guillermo Rodriguez Garcia wrote:
> > What about IMX_KOBS_LICENSE_FILES  := file://COPYING;md5=…
> 
> Never did this before, I thought it was only necessary for
> not-well-known licenses. Should I add it?

This has nothing to do with well-known or not. It's to catch license
changes when the version is bumped.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23 12:38   ` Guillermo Rodriguez Garcia
  2018-10-23 12:43     ` Uwe Kleine-König
@ 2018-10-23 12:48     ` Alexander Dahl
  1 sibling, 0 replies; 11+ messages in thread
From: Alexander Dahl @ 2018-10-23 12:48 UTC (permalink / raw)
  To: Guillermo Rodriguez Garcia; +Cc: ptxdist

Hei hei,

Am Dienstag, 23. Oktober 2018, 14:38:55 CEST schrieb Guillermo Rodriguez 
Garcia:
> El mar., 23 oct. 2018 a las 13:00, Alexander Dahl (<ada@thorsis.com>) 
escribió:
> > How did you find this? I would have taken the tool from GitHub:
> I have to admit I am not sure anymore where I found this. When
> cleaning up the .make file I considered switching to github, but at
> the end I chose not to do it as it had no tags and I thought that this
> would be cleaner than referencing a specific commit by its hash.

+1

It tried to find it on the NXP webpage. You get a hit, when you type 'kobs' in 
the search field and this is returned:

https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/imx-kobs-5.5.tar.gz

I could not find it through clicking through product and support pages 
however.

> > What about IMX_KOBS_LICENSE_FILES  := file://COPYING;md5=…
> 
> Never did this before, I thought it was only necessary for
> not-well-known licenses. Should I add it?

This is needed for a license report, the checksum is to detect changes in 
licensing. It doesn't hurt to add it and may benefit users generating such a 
report.

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH] imx-kobs: New package
  2018-10-23  9:23 [ptxdist] [PATCH] imx-kobs: New package Guillermo Rodríguez
  2018-10-23 10:59 ` Alexander Dahl
@ 2018-10-23 13:09 ` Michael Olbrich
  2018-10-23 14:17 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
  2 siblings, 0 replies; 11+ messages in thread
From: Michael Olbrich @ 2018-10-23 13:09 UTC (permalink / raw)
  To: ptxdist; +Cc: Guillermo Rodríguez

On Tue, Oct 23, 2018 at 11:23:36AM +0200, Guillermo Rodríguez wrote:
> The imx-kobs tool is used to create and write i.MX NAND boot
> related boot data structures to NAND flash.
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/imx-kobs.in   |  8 ++++++++
>  rules/imx-kobs.make | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 rules/imx-kobs.in
>  create mode 100644 rules/imx-kobs.make
> 
> diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> new file mode 100644
> index 0000000..e00ca24
> --- /dev/null
> +++ b/rules/imx-kobs.in
> @@ -0,0 +1,8 @@
> +## SECTION=shell_and_console
> +
> +config IMX_KOBS
> +	tristate
> +	prompt "imx-kobs"
> +	help
> +	  The imx-kobs tool is used to create and write i.MX NAND boot
> +	  related boot data structures to NAND flash.
> diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> new file mode 100644
> index 0000000..49380c2
> --- /dev/null
> +++ b/rules/imx-kobs.make
> @@ -0,0 +1,53 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> +
> +#
> +# Paths and names
> +#
> +IMX_KOBS_VERSION	:= 5.5
> +IMX_KOBS_SUFFIX		:= tar.gz
> +IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
> +IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
> +IMX_KOBS_URL		:= http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
> +IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_LICENSE	:= GPLv2
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +IMX_KOBS_CONF_TOOL	:= autoconf

You need to set the configure options and include
$(GLOBAL_LARGE_FILE_OPTION).

The rest has already been commented on by others.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/imx-kobs.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, imx-kobs)
> +	@$(call install_fixup, imx-kobs, PRIORITY, optional)
> +	@$(call install_fixup, imx-kobs, SECTION, base)
> +	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez <guille.rodriguez@gmail.com>")
> +	@$(call install_fixup, imx-kobs, DESCRIPTION, missing)
> +
> +	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
> +
> +	@$(call install_finish, imx-kobs)
> +
> +	@$(call touch)
> +	
> +# vim: syntax=make	
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ptxdist] [PATCH v2] imx-kobs: New package
  2018-10-23  9:23 [ptxdist] [PATCH] imx-kobs: New package Guillermo Rodríguez
  2018-10-23 10:59 ` Alexander Dahl
  2018-10-23 13:09 ` Michael Olbrich
@ 2018-10-23 14:17 ` Guillermo Rodríguez
  2018-10-23 15:09   ` Alexander Dahl
  2018-10-23 15:10   ` Ladislav Michl
  2 siblings, 2 replies; 11+ messages in thread
From: Guillermo Rodríguez @ 2018-10-23 14:17 UTC (permalink / raw)
  To: ptxdist; +Cc: Guillermo Rodríguez

The imx-kobs tool is used to create and write i.MX NAND boot
related boot data structures to NAND flash.

Changes since v1:
- Fix license name
- Add license files
- Add configure options and GLOBAL_LARGE_FILE_OPTION

Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
---
 rules/imx-kobs.in   |  8 ++++++++
 rules/imx-kobs.make | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 rules/imx-kobs.in
 create mode 100644 rules/imx-kobs.make

diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
new file mode 100644
index 0000000..e00ca24
--- /dev/null
+++ b/rules/imx-kobs.in
@@ -0,0 +1,8 @@
+## SECTION=shell_and_console
+
+config IMX_KOBS
+	tristate
+	prompt "imx-kobs"
+	help
+	  The imx-kobs tool is used to create and write i.MX NAND boot
+	  related boot data structures to NAND flash.
diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
new file mode 100644
index 0000000..2883f7a
--- /dev/null
+++ b/rules/imx-kobs.make
@@ -0,0 +1,57 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
+
+#
+# Paths and names
+#
+IMX_KOBS_VERSION	:= 5.5
+IMX_KOBS_SUFFIX		:= tar.gz
+IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
+IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
+IMX_KOBS_URL		:= https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
+IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
+IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
+IMX_KOBS_LICENSE	:= GPL-2.0-or-later
+IMX_KOBS_LICENSE_FILES	:= file://COPYING;md5=393a5ca445f6965873eca0259a17f833
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+IMX_KOBS_CONF_TOOL	:= autoconf
+IMX_KOBS_CONF_OPT	:= \
+	$(CROSS_AUTOCONF_USR) \
+	$(GLOBAL_LARGE_FILE_OPTION)
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/imx-kobs.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, imx-kobs)
+	@$(call install_fixup, imx-kobs, PRIORITY, optional)
+	@$(call install_fixup, imx-kobs, SECTION, base)
+	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez <guille.rodriguez@gmail.com>")
+	@$(call install_fixup, imx-kobs, DESCRIPTION, missing)
+
+	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
+
+	@$(call install_finish, imx-kobs)
+
+	@$(call touch)
+	
+# vim: syntax=make	
-- 
1.9.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH v2] imx-kobs: New package
  2018-10-23 14:17 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
@ 2018-10-23 15:09   ` Alexander Dahl
  2018-10-23 15:10   ` Ladislav Michl
  1 sibling, 0 replies; 11+ messages in thread
From: Alexander Dahl @ 2018-10-23 15:09 UTC (permalink / raw)
  To: ptxdist

Reviewed-by: Alexander Dahl <ada@thorsis.com>

Am Dienstag, 23. Oktober 2018, 16:17:32 CEST schrieb Guillermo Rodríguez:
> The imx-kobs tool is used to create and write i.MX NAND boot
> related boot data structures to NAND flash.
> 
> Changes since v1:
> - Fix license name
> - Add license files
> - Add configure options and GLOBAL_LARGE_FILE_OPTION
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/imx-kobs.in   |  8 ++++++++
>  rules/imx-kobs.make | 57
> +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 65
> insertions(+)
>  create mode 100644 rules/imx-kobs.in
>  create mode 100644 rules/imx-kobs.make
> 
> diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> new file mode 100644
> index 0000000..e00ca24
> --- /dev/null
> +++ b/rules/imx-kobs.in
> @@ -0,0 +1,8 @@
> +## SECTION=shell_and_console
> +
> +config IMX_KOBS
> +	tristate
> +	prompt "imx-kobs"
> +	help
> +	  The imx-kobs tool is used to create and write i.MX NAND boot
> +	  related boot data structures to NAND flash.
> diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> new file mode 100644
> index 0000000..2883f7a
> --- /dev/null
> +++ b/rules/imx-kobs.make
> @@ -0,0 +1,57 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> +
> +#
> +# Paths and names
> +#
> +IMX_KOBS_VERSION	:= 5.5
> +IMX_KOBS_SUFFIX		:= tar.gz
> +IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
> +IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
> +IMX_KOBS_URL		:=
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
> +IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_LICENSE	:= GPL-2.0-or-later
> +IMX_KOBS_LICENSE_FILES	:=
> file://COPYING;md5=393a5ca445f6965873eca0259a17f833 +
> +#
> ---------------------------------------------------------------------------
> - +# Prepare
> +#
> ---------------------------------------------------------------------------
> - +
> +IMX_KOBS_CONF_TOOL	:= autoconf
> +IMX_KOBS_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION)
> +
> +#
> ---------------------------------------------------------------------------
> - +# Target-Install
> +#
> ---------------------------------------------------------------------------
> - +
> +$(STATEDIR)/imx-kobs.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, imx-kobs)
> +	@$(call install_fixup, imx-kobs, PRIORITY, optional)
> +	@$(call install_fixup, imx-kobs, SECTION, base)
> +	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez
> <guille.rodriguez@gmail.com>") +	@$(call install_fixup, imx-kobs,
> DESCRIPTION, missing)
> +
> +	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
> +
> +	@$(call install_finish, imx-kobs)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make



_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH v2] imx-kobs: New package
  2018-10-23 14:17 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
  2018-10-23 15:09   ` Alexander Dahl
@ 2018-10-23 15:10   ` Ladislav Michl
  2018-10-23 15:30     ` Guillermo Rodriguez Garcia
  1 sibling, 1 reply; 11+ messages in thread
From: Ladislav Michl @ 2018-10-23 15:10 UTC (permalink / raw)
  To: ptxdist

Hi,

On Tue, Oct 23, 2018 at 04:17:32PM +0200, Guillermo Rodríguez wrote:
> The imx-kobs tool is used to create and write i.MX NAND boot
> related boot data structures to NAND flash.

just a side note, changelog bellow is not part of commit log, so it
should be placed bellow "---".

> Changes since v1:
> - Fix license name
> - Add license files
> - Add configure options and GLOBAL_LARGE_FILE_OPTION
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---

... here; it is not processed by 'git am', while humans will still read it :)
 
>  rules/imx-kobs.in   |  8 ++++++++
>  rules/imx-kobs.make | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 65 insertions(+)
>  create mode 100644 rules/imx-kobs.in
>  create mode 100644 rules/imx-kobs.make
> 
> diff --git a/rules/imx-kobs.in b/rules/imx-kobs.in
> new file mode 100644
> index 0000000..e00ca24
> --- /dev/null
> +++ b/rules/imx-kobs.in
> @@ -0,0 +1,8 @@
> +## SECTION=shell_and_console
> +
> +config IMX_KOBS
> +	tristate
> +	prompt "imx-kobs"
> +	help
> +	  The imx-kobs tool is used to create and write i.MX NAND boot
> +	  related boot data structures to NAND flash.
> diff --git a/rules/imx-kobs.make b/rules/imx-kobs.make
> new file mode 100644
> index 0000000..2883f7a
> --- /dev/null
> +++ b/rules/imx-kobs.make
> @@ -0,0 +1,57 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Guillermo Rodriguez <guille.rodriguez@gmail.com>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_IMX_KOBS) += imx-kobs
> +
> +#
> +# Paths and names
> +#
> +IMX_KOBS_VERSION	:= 5.5
> +IMX_KOBS_SUFFIX		:= tar.gz
> +IMX_KOBS_MD5		:= 48ed9e69e9527d2e98b5cfcbf133d75b
> +IMX_KOBS		:= imx-kobs-$(IMX_KOBS_VERSION)
> +IMX_KOBS_URL		:= https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_DIR		:= $(BUILDDIR)/$(IMX_KOBS)
> +IMX_KOBS_SOURCE		:= $(SRCDIR)/$(IMX_KOBS).$(IMX_KOBS_SUFFIX)
> +IMX_KOBS_LICENSE	:= GPL-2.0-or-later
> +IMX_KOBS_LICENSE_FILES	:= file://COPYING;md5=393a5ca445f6965873eca0259a17f833
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +IMX_KOBS_CONF_TOOL	:= autoconf
> +IMX_KOBS_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/imx-kobs.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, imx-kobs)
> +	@$(call install_fixup, imx-kobs, PRIORITY, optional)
> +	@$(call install_fixup, imx-kobs, SECTION, base)
> +	@$(call install_fixup, imx-kobs, AUTHOR, "Guillermo Rodriguez <guille.rodriguez@gmail.com>")
> +	@$(call install_fixup, imx-kobs, DESCRIPTION, missing)
> +
> +	@$(call install_copy, imx-kobs, 0, 0, 0755, -, /usr/bin/kobs-ng)
> +
> +	@$(call install_finish, imx-kobs)
> +
> +	@$(call touch)
> +	
> +# vim: syntax=make	
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ptxdist] [PATCH v2] imx-kobs: New package
  2018-10-23 15:10   ` Ladislav Michl
@ 2018-10-23 15:30     ` Guillermo Rodriguez Garcia
  0 siblings, 0 replies; 11+ messages in thread
From: Guillermo Rodriguez Garcia @ 2018-10-23 15:30 UTC (permalink / raw)
  To: ptxdist

Hi Ladislav,

El mar., 23 oct. 2018 a las 17:10, Ladislav Michl
(<ladis@linux-mips.org>) escribió:
> just a side note, changelog bellow is not part of commit log, so it
> should be placed bellow "---".

Noted, thank you!

Guillermo

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-10-23 15:30 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23  9:23 [ptxdist] [PATCH] imx-kobs: New package Guillermo Rodríguez
2018-10-23 10:59 ` Alexander Dahl
2018-10-23 11:41   ` Alexander Dahl
2018-10-23 12:38   ` Guillermo Rodriguez Garcia
2018-10-23 12:43     ` Uwe Kleine-König
2018-10-23 12:48     ` Alexander Dahl
2018-10-23 13:09 ` Michael Olbrich
2018-10-23 14:17 ` [ptxdist] [PATCH v2] " Guillermo Rodríguez
2018-10-23 15:09   ` Alexander Dahl
2018-10-23 15:10   ` Ladislav Michl
2018-10-23 15:30     ` Guillermo Rodriguez Garcia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox