Re: [ptxdist] [PATCH 6/7] u-boot: allow generation of custom environment binary

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Oct 16, 2018 at 01:27:13PM +0200, Alexander Dahl wrote:
> Am Dienstag, 16. Oktober 2018, 10:58:50 CEST schrieb Denis OSTERLAND:
> > Am Mittwoch, den 10.10.2018, 14:03 +0200 schrieb Ahmad Fatoum:
> > > +ifdef PTXCONF_U_BOOT_ENV
> > > +	@$(U_BOOT_DIR)/tools/mkenvimage \
> > > +		$(U_BOOT_ENV_FLAGS) -s $(PTXCONF_U_BOOT_ENV_IMAGE_SIZE) \
> > > +		-o $(U_BOOT_DIR)/uboot-env.bin \
> > > +		$(U_BOOT_ENV_TXT)
> > > +endif
> > 
> > We had a similar case, but end up with an image of compiled in env, using
> > get_default_envs script.
> > We didn´t had the time to clean it up.
> 
> Same usecase here, but … 
> 
> What I did was creating a new platform image rule depending on 
> HOST_U_BOOT_TOOLS. Creating an U-Boot environment image file is independent 
> from building U-Boot itself and it creates an artefact I would consider an 
> image. I'm not happy seeing this feature inside the U-Boot target package 
> itself.

Ahmad had a separate package originally but I told him to integrate it...
It seemed more natural to me. Maybe because the environment is more
integrated in barebox and that's what I usually use.
But I'm not too set on it either way.

> The reason I didn't share my rules/image-ubootenv.make and platforms/image-
> ubootenv.in was setting lots of custom options through the menu by replacing 
> placeholders, which makes that approach a little more complex than just 
> creating such an image from a static file.
> 
> If anyone is interested though, I could share.

Hmm, we could use ptxd_replace_magic() in general and source the config
files for this. Then a BSP could overwrite just the menu file and add some
options. Would that match your use-case?

What about the script (patch 7/7)? Do you think that should be a separate
package too?

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de