mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <r.hieber@pengutronix.de>
To: distrokit@pengutronix.de, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [DistroKit] Recent DistroKit with ptxdist 2018.10.0 fails to get host-coreutils
Date: Thu, 11 Oct 2018 16:28:43 +0200	[thread overview]
Message-ID: <20181011142843.fs35rq2h2ml5yuvi@pengutronix.de> (raw)
In-Reply-To: <20181010132213.2a7i5qr6taahvhwn@falbala.home.lespocky.de>

On Wed, Oct 10, 2018 at 03:22:13PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> On Wed, Oct 10, 2018 at 02:21:48PM +0200, Roland Hieber wrote:
> > On Wed, Oct 10, 2018 at 01:04:01PM +0200, Roland Hieber wrote:
> > > Ohai,
> > > 
> > > I set my source download folder to ./src/ and I can reproduce this with
> > > various other packages as well (kernel, coreutils, systemd,
> > > networkmanager), and even on PTXdist 2018.01.0…?!
> 
> I don't think that is the same problem. I set PTXCONF_SETUP_SRCDIR to
> /mnt/trash/src first, and to the default ${PTXDIST_WORKSPACE}/src
> then. The problem is reproducible for packages where you build the
> host, but not the target package, e.g. FOO=n and HOST_FOO=y. For
> DistroKit master that is the case for acl, coreutils and maybe more.

Indeed, I can also reproduce this with ${PTXDIST_WORKSPACE}/src. I guess
HOST_* packages are missing the mapping from the HOST_*_SOURCE to the
*_SOURCE variables, but I cannot see right now where and when this
broke. I'll try a bisect later today.

 - Roland

> 
> > > I added some debug echos to ptxdist/rules/post/ptxd_make_world_get.make:
> > > 
> > > ------------------------------------------------ 8<---------------------
> > > --- a/rules/post/ptxd_make_world_get.make
> > > +++ b/rules/post/ptxd_make_world_get.make
> > > @@ -15,7 +15,8 @@
> > >  #
> > >  $(SRCDIR)/%:
> > >         →@$(call targetinfo)
> > > -       →@$(call get, $($@))
> > > +       →echo target '$$(SRCDIR)/%'; echo params: $@; echo $$($$@) = $($@); set -x; \
> > > +       →$(call get, $($@))
> > >  
> > >  ifneq ($(call remove_quotes, $(PTXCONF_PROJECT_DEVPKGDIR)),)
> > >  $(call remove_quotes, $(PTXCONF_PROJECT_DEVPKGDIR))/%-dev.tar.gz:
> > > ------------------------------------------------ >8---------------------
> 
> Nice. Let me show you two example outputs from my side, first is from
> a usual target only package, second triggers the problem:
> 
> --------------------------
> target: glib-2.56.1.tar.xz
> --------------------------
> 
> echo target '$(SRCDIR)/%'; echo params: /home/alex/src/DistroKit/src/glib-2.56.1.tar.xz; echo $($@) = GLIB; set -x; \
> ptxd_make_get_mirror=http://www.pengutronix.de/software/ptxdist/temporary-src ptxd_make_get "/home/alex/src/DistroKit/src/glib-2.56.1.tar.xz" "http://ftp.gnome.o
> rg/pub/GNOME/sources/glib/2.56/glib-2.56.1.tar.xz"
> target $(SRCDIR)/%
> params: /home/alex/src/DistroKit/src/glib-2.56.1.tar.xz
> = GLIB
> 
> 
> -----------------------------
> target: acl-2.2.52.src.tar.gz
> -----------------------------
> 
> echo target '$(SRCDIR)/%'; echo params: /home/alex/src/DistroKit/src/acl-2.2.52.src.tar.gz; echo $($@) = ; set -x; \
> ptxd_make_get_mirror=http://www.pengutronix.de/software/ptxdist/temporary-src ptxd_make_get "" ""
> target $(SRCDIR)/%
> params: /home/alex/src/DistroKit/src/acl-2.2.52.src.tar.gz
> =
> 
> > > I think that the $($@) expression should result in "NETWORKMANAGER", so
> > > ptxd_make_get knows about what package to download. As far as I
> > > understand, this should be a generated rule in
> > > DistroKit/platform-$name/state/ptxd_dgen_deps.post, but I cannot find it
> > > there... I'll try a bisect on ptxdist to find out where it first went
> > > wrong.
> 
> If I compare the above output, the same happens here. In the second
> case ACL is missing while in the first case GLIB is there.
> 
> I could reproduce this on another build host.
> 
> So to say it clear again: download of a tarball fails, if the host
> package is selected, but the normal target package is not. If the
> tarball is already there, build is successful.
> 
> Greets
> Alex
> 
> -- 
> /"\ ASCII RIBBON | »With the first link, the chain is forged. The first
> \ / CAMPAIGN     | speech censured, the first thought forbidden, the
>  X  AGAINST      | first freedom denied, chains us all irrevocably.«
> / \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)



> _______________________________________________
> DistroKit mailing list
> DistroKit@pengutronix.de


-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-10-11 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  8:05 [ptxdist] " Alexander Dahl
2018-10-10 11:04 ` Roland Hieber
2018-10-10 12:21   ` Roland Hieber
2018-10-10 13:22     ` Alexander Dahl
2018-10-11 14:28       ` Roland Hieber [this message]
2018-10-11 20:05         ` [ptxdist] [DistroKit] " Roland Hieber
2018-10-12 11:59           ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011142843.fs35rq2h2ml5yuvi@pengutronix.de \
    --to=r.hieber@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox