mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] host-system-tcl: new package
@ 2018-10-10 12:14 Ahmad Fatoum
  2018-10-11 13:44 ` Ladislav Michl
  0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2018-10-10 12:14 UTC (permalink / raw)
  To: ptxdist; +Cc: Ahmad Fatoum

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 rules/host-system-tcl.in   |  6 ++++++
 rules/host-system-tcl.make | 30 ++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 rules/host-system-tcl.in
 create mode 100644 rules/host-system-tcl.make

diff --git a/rules/host-system-tcl.in b/rules/host-system-tcl.in
new file mode 100644
index 000000000000..c736194d0e66
--- /dev/null
+++ b/rules/host-system-tcl.in
@@ -0,0 +1,6 @@
+## SECTION=hosttools_noprompt
+## SECTION=bootloader
+
+config HOST_SYSTEM_TCL
+	tristate
+
diff --git a/rules/host-system-tcl.make b/rules/host-system-tcl.make
new file mode 100644
index 000000000000..1c933841e092
--- /dev/null
+++ b/rules/host-system-tcl.make
@@ -0,0 +1,30 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2013 by Michael Olbrich <m.olbrich@pengutronix.de>
+#           (C) 2018 by Ahmad Fatoum <a.fatoum@pengutronix.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+HOST_PACKAGES-$(PTXCONF_HOST_SYSTEM_TCL) += host-system-tcl
+HOST_SYSTEM_TCL_LICENSE = ignore
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/host-system-tcl.prepare:
+	@$(call targetinfo)
+	@echo "Checking for tclsh ..."
+	@echo exit 0 | tclsh >/dev/null 2>&1 || \
+		ptxd_bailout "'tclsh' not found! Please install.";
+	@echo
+	@$(call touch)
+
+# vim: syntax=make
-- 
2.19.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH] host-system-tcl: new package
  2018-10-10 12:14 [ptxdist] [PATCH] host-system-tcl: new package Ahmad Fatoum
@ 2018-10-11 13:44 ` Ladislav Michl
  2018-10-15  9:37   ` Ahmad Fatoum
  0 siblings, 1 reply; 3+ messages in thread
From: Ladislav Michl @ 2018-10-11 13:44 UTC (permalink / raw)
  To: ptxdist

Hello Ahmad,

On Wed, Oct 10, 2018 at 02:14:16PM +0200, Ahmad Fatoum wrote:
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  rules/host-system-tcl.in   |  6 ++++++
>  rules/host-system-tcl.make | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+)
>  create mode 100644 rules/host-system-tcl.in
>  create mode 100644 rules/host-system-tcl.make

What is this package intended to be for? Could be the same realized
with already existing host-jimtcl package to lower number of tools
required on the build host?

	ladis

> diff --git a/rules/host-system-tcl.in b/rules/host-system-tcl.in
> new file mode 100644
> index 000000000000..c736194d0e66
> --- /dev/null
> +++ b/rules/host-system-tcl.in
> @@ -0,0 +1,6 @@
> +## SECTION=hosttools_noprompt
> +## SECTION=bootloader
> +
> +config HOST_SYSTEM_TCL
> +	tristate
> +
> diff --git a/rules/host-system-tcl.make b/rules/host-system-tcl.make
> new file mode 100644
> index 000000000000..1c933841e092
> --- /dev/null
> +++ b/rules/host-system-tcl.make
> @@ -0,0 +1,30 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2013 by Michael Olbrich <m.olbrich@pengutronix.de>
> +#           (C) 2018 by Ahmad Fatoum <a.fatoum@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_SYSTEM_TCL) += host-system-tcl
> +HOST_SYSTEM_TCL_LICENSE = ignore
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/host-system-tcl.prepare:
> +	@$(call targetinfo)
> +	@echo "Checking for tclsh ..."
> +	@echo exit 0 | tclsh >/dev/null 2>&1 || \
> +		ptxd_bailout "'tclsh' not found! Please install.";
> +	@echo
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.19.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH] host-system-tcl: new package
  2018-10-11 13:44 ` Ladislav Michl
@ 2018-10-15  9:37   ` Ahmad Fatoum
  0 siblings, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2018-10-15  9:37 UTC (permalink / raw)
  To: ptxdist

Hello Ladislav,

On 11/10/18 15:44, Ladislav Michl wrote:
> What is this package intended to be for? Could be the same realized
> with already existing host-jimtcl package to lower number of tools
> required on the build host?

I hadn't noticed that your jimtcl patch also included a host-jimtcl rule.
It works just fine for my use case. Thank you!

I agree this makes this patch unnecessary.

Cheers
Ahmad

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-15  9:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 12:14 [ptxdist] [PATCH] host-system-tcl: new package Ahmad Fatoum
2018-10-11 13:44 ` Ladislav Michl
2018-10-15  9:37   ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox