* [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends
@ 2018-09-13 7:22 Alexander Dahl
2018-09-13 7:22 ` [ptxdist] [PATCH 1/1] doc: Fix wrong use of PKGDIR Alexander Dahl
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexander Dahl @ 2018-09-13 7:22 UTC (permalink / raw)
To: ptxdist
Hei hei,
I'm currently writing package rules for some ugly Make only based
sources. I could sort out my questions about how to use $(SYSROOT) and
$(FOO_PKGDIR) in compile and install stages by looking at other
packages, but I would say that part is missing in the documentation.
My assumption so far is: the default install stage installs to
$(FOO_PKGDIR) and that content is magically copied to $(SYSROOT) then?
I tried to find some help in the docs, there's not much, but I spotted
one thing I consider to be wrong at this time. See the patch.
Alexander Dahl (1):
doc: Fix wrong use of PKGDIR
doc/ref_manual.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread* [ptxdist] [PATCH 1/1] doc: Fix wrong use of PKGDIR
2018-09-13 7:22 [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Alexander Dahl
@ 2018-09-13 7:22 ` Alexander Dahl
2018-09-13 9:26 ` [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Roland Hieber
2018-10-08 6:35 ` Alexander Dahl
2 siblings, 0 replies; 6+ messages in thread
From: Alexander Dahl @ 2018-09-13 7:22 UTC (permalink / raw)
To: ptxdist
$(PKGDIR) expands to <platform-dir>/packages/ and contains folders with
package names where artefacts from the install stage go, e.g. foo-1.0
from the package FOO. There is no root folder hierarchy directly in
$(PKGDIR), but one for each package in the subfolders. For the
targetinstall stage the source is the matching subfolder for the
package's targetinstall, $(FOO_PKGDIR) expands to that.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
doc/ref_manual.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/ref_manual.rst b/doc/ref_manual.rst
index 56034d8e7..c9e26ffab 100644
--- a/doc/ref_manual.rst
+++ b/doc/ref_manual.rst
@@ -884,7 +884,7 @@ match ``<yglob>`` and do not match ``<nglob>`` are installed.
Examples:
-Install all shared libraries found in ``$(PKGDIR)/usr/lib/foo`` except
+Install all shared libraries found in ``$(FOO_PKGDIR)/usr/lib/foo`` except
libbar.so
.. code-block:: make
--
2.11.0
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends
2018-09-13 7:22 [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Alexander Dahl
2018-09-13 7:22 ` [ptxdist] [PATCH 1/1] doc: Fix wrong use of PKGDIR Alexander Dahl
@ 2018-09-13 9:26 ` Roland Hieber
2018-09-17 8:50 ` Michael Olbrich
2018-10-08 6:35 ` Alexander Dahl
2 siblings, 1 reply; 6+ messages in thread
From: Roland Hieber @ 2018-09-13 9:26 UTC (permalink / raw)
To: ptxdist
On Thu, Sep 13, 2018 at 09:22:57AM +0200, Alexander Dahl wrote:
> Hei hei,
>
> I'm currently writing package rules for some ugly Make only based
> sources. I could sort out my questions about how to use $(SYSROOT) and
> $(FOO_PKGDIR) in compile and install stages by looking at other
> packages, but I would say that part is missing in the documentation.
> My assumption so far is: the default install stage installs to
> $(FOO_PKGDIR) and that content is magically copied to $(SYSROOT) then?
As far as I remember, the install stage installs to FOO_PKGDIR, and the
targetinstall stage then installs from FOO_PKGDIR to SYSROOT.
I guess there is the need to document the interface between the single
stages somehow, what each stage expects and what it is supposed to do.
- Roland
--
Roland Hieber | r.hieber@pengutronix.de |
Pengutronix e.K. | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends
2018-09-13 9:26 ` [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Roland Hieber
@ 2018-09-17 8:50 ` Michael Olbrich
0 siblings, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2018-09-17 8:50 UTC (permalink / raw)
To: ptxdist
On Thu, Sep 13, 2018 at 11:26:29AM +0200, Roland Hieber wrote:
> On Thu, Sep 13, 2018 at 09:22:57AM +0200, Alexander Dahl wrote:
> > Hei hei,
> >
> > I'm currently writing package rules for some ugly Make only based
> > sources. I could sort out my questions about how to use $(SYSROOT) and
> > $(FOO_PKGDIR) in compile and install stages by looking at other
> > packages, but I would say that part is missing in the documentation.
> > My assumption so far is: the default install stage installs to
> > $(FOO_PKGDIR) and that content is magically copied to $(SYSROOT) then?
>
> As far as I remember, the install stage installs to FOO_PKGDIR, and the
> targetinstall stage then installs from FOO_PKGDIR to SYSROOT.
> I guess there is the need to document the interface between the single
> stages somehow, what each stage expects and what it is supposed to do.
It's install.post not targetinstall that copies the files to the correct
sysroot.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends
2018-09-13 7:22 [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Alexander Dahl
2018-09-13 7:22 ` [ptxdist] [PATCH 1/1] doc: Fix wrong use of PKGDIR Alexander Dahl
2018-09-13 9:26 ` [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Roland Hieber
@ 2018-10-08 6:35 ` Alexander Dahl
2018-10-09 7:21 ` Michael Olbrich
2 siblings, 1 reply; 6+ messages in thread
From: Alexander Dahl @ 2018-10-08 6:35 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Olbrich
Hello,
Am Donnerstag, 13. September 2018, 09:22:57 CEST schrieb Alexander Dahl:
> I'm currently writing package rules for some ugly Make only based
> sources. I could sort out my questions about how to use $(SYSROOT) and
> $(FOO_PKGDIR) in compile and install stages by looking at other
> packages, but I would say that part is missing in the documentation.
I saw some additions to the documentation with
966628a9a30553714556f8fb8860809bfbaf8732.
Thanks Michael for working on this. :-)
Greets
Alex
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends
2018-10-08 6:35 ` Alexander Dahl
@ 2018-10-09 7:21 ` Michael Olbrich
0 siblings, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2018-10-09 7:21 UTC (permalink / raw)
To: ptxdist
Hi,
On Mon, Oct 08, 2018 at 08:35:40AM +0200, Alexander Dahl wrote:
> Am Donnerstag, 13. September 2018, 09:22:57 CEST schrieb Alexander Dahl:
> > I'm currently writing package rules for some ugly Make only based
> > sources. I could sort out my questions about how to use $(SYSROOT) and
> > $(FOO_PKGDIR) in compile and install stages by looking at other
> > packages, but I would say that part is missing in the documentation.
>
> I saw some additions to the documentation with
> 966628a9a30553714556f8fb8860809bfbaf8732.
>
> Thanks Michael for working on this. :-)
You're welcome. I try to improve the documentation, but it's a slow
progress. I'm not very fast at this and my time is limited.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 7:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 7:22 [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Alexander Dahl
2018-09-13 7:22 ` [ptxdist] [PATCH 1/1] doc: Fix wrong use of PKGDIR Alexander Dahl
2018-09-13 9:26 ` [ptxdist] [PATCH 0/1] doc: Documenting PKGDIR and friends Roland Hieber
2018-09-17 8:50 ` Michael Olbrich
2018-10-08 6:35 ` Alexander Dahl
2018-10-09 7:21 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox