From: Robert Schwebel <r.schwebel@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxd_install_replace_figlet: replace all backslashes, not only the first
Date: Sat, 6 Oct 2018 12:30:39 +0200 [thread overview]
Message-ID: <20181006103039.ajixydomsnxfv4wu@pengutronix.de> (raw)
In-Reply-To: <20181005205212.24577-1-u.kleine-koenig@pengutronix.de>
On Fri, Oct 05, 2018 at 10:52:12PM +0200, Uwe Kleine-König wrote:
> Fixes: f53889792197 ("ptxd_install_replace_figlet: Use sed instead of awk to quote backslashes")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> scripts/lib/ptxd_make_xpkg_pkg.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
> index b3f2f20f3e4e..766d46ac3238 100644
> --- a/scripts/lib/ptxd_make_xpkg_pkg.sh
> +++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
> @@ -587,7 +587,7 @@ install replace figlet:
> # figlet needs to be replaced by \\\\. As a \ in sed needs to be
> # quoted, too, this results in eight backslashes in the replacement
> # string.
> - etcissue) sed 's,\\,\\\\\\\\,';;
> + etcissue) sed 's,\\,\\\\\\\\,g';;
> *) ;;
> esac | \
> awk '{ if ($0 !~ "^ *$") printf("%s\\n", $0) }' # newlines for sed
> --
> 2.19.0
Tested-by: Robert Schwebel <r.schwebel@pengutronix.de>
on DistroKit.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-10-06 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 8:43 [ptxdist] [PATCH] ptxd_install_replace_figlet: Use sed instead of awk to quote backslashes Uwe Kleine-König
2018-10-05 15:50 ` Robert Schwebel
2018-10-05 20:52 ` [ptxdist] [PATCH] ptxd_install_replace_figlet: replace all backslashes, not only the first Uwe Kleine-König
2018-10-06 10:30 ` Robert Schwebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006103039.ajixydomsnxfv4wu@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox