Re: [ptxdist] [PATCH] ptxd_install_replace_figlet: Use sed instead of awk to quote backslashes

[Robert Schwebel <r.schwebel@pengutronix.de>]

Hi Uwe,

On Wed, Sep 19, 2018 at 10:43:36AM +0200, Uwe Kleine-König wrote:
> TL;DR: awk and backslashes in the replacement argument of gsub is ugly.
> 
> With GNU Awk 4.0.2 we have:
> 
> 	$ echo '\' | awk '{ gsub("\\\\", "\\\\\\\\\\\\\\\\"); print }'
> 	\\\\\\\\
> 
> and with GNU Awk 4.1.4 (and newer) we have:
> 
> 	$ echo '\' | awk '{ gsub("\\\\", "\\\\\\\\\\\\\\\\"); print }'
> 	\\\\
> 
> This results in too much backslashes in /etc/issues for users of the
> former version.
> 
> For the glory details I recommend reading through
> 
> 	https://www.gnu.org/software/gawk/manual/html_node/Gory-Details.html
> 	https://bugs.debian.org/909147
> 
> As it's awkward to come up with an expression that does the same on both
> versions (e.g. using --posix) use sed instead.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

This has now landed in ptxdist-2018.10.0, and it is broken.
Here is what DistroKit outputs:

 ____                        _                   _      
|  _ \ ___ _ __   __ _ _   _| |_ _ __ ___  _ __ (_)_  __
| |_) / _ \ '_  / _` | | | | __| '__/ _ | '_ |  / /
|  __/  __/ | | | (_| | |_| | |_| | | (_) | | | | |>  < 
|_|   \___|_| |_|__, |__,_|__|_|  ___/|_| |_|_/_/_DistroKit                 |___/                                  

 ____  _     _             _  ___ _   
|  _ \(_)___| |_ _ __ ___ | |/ (_) |_ 
| | | | / __| __| '__/ _ \| ' /| | __|
| |_| | \__  |_| | | (_) | . | | |_ 
|____/|_|___/\__|_|  ___/|_|__|__|

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de