From: Roland Hieber <r.hieber@pengutronix.de>
To: Guillermo Rodriguez Garcia <guille.rodriguez@gmail.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] stm32flash: New package
Date: Fri, 5 Oct 2018 14:07:26 +0200 [thread overview]
Message-ID: <20181005120726.hau64fpdqgd5blgh@pengutronix.de> (raw)
In-Reply-To: <CABDcavahWfHaQ1D6sQ5GYj3s6-Er-fGnMDPaeyjJU_1E1pg8Og@mail.gmail.com>
> > Also most packages keep *_INSTALL_* variables under the Install section
> > header, and *_MAKE_* variables under the "Compile" section header. I
> > would suggest to do it here too to get a unified look over package
> > rules.
>
> Uhm, most of the existing packages I have checked define MAKE_ and
> INSTALL_ vars in the prepare stage. See for example bzip2 (this is the
> one I used as a reference), busybox, i2c-tools, openssl, zip ...
Hm. The style seems to be very mixed between packages. Sorry, my bad.
- Roland
--
Roland Hieber | r.hieber@pengutronix.de |
Pengutronix e.K. | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2018-10-05 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 9:25 Guillermo Rodriguez
2018-10-05 10:30 ` Roland Hieber
2018-10-05 10:43 ` Guillermo Rodriguez Garcia
2018-10-05 12:07 ` Roland Hieber [this message]
2018-10-05 14:04 ` Michael Olbrich
2018-10-06 17:05 ` Guillermo Rodriguez Garcia
2018-10-06 17:14 ` [ptxdist] [PATCH v2] " Guillermo Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005120726.hau64fpdqgd5blgh@pengutronix.de \
--to=r.hieber@pengutronix.de \
--cc=guille.rodriguez@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox