Re: [ptxdist] [PATCH v2 1/3] jimtcl: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Sep 18, 2018 at 09:04:40AM +0200, Ladislav Michl wrote:
> On Mon, Sep 17, 2018 at 10:21:29AM +0200, Michael Olbrich wrote:
> > On Thu, Sep 13, 2018 at 12:38:47PM +0200, Ladislav Michl wrote:
> > > On Thu, Sep 13, 2018 at 11:59:37AM +0200, Roland Hieber wrote:
> > > > On Thu, Sep 13, 2018 at 10:32:26AM +0200, Ladislav Michl wrote:
> > > > [...]
> > > > > diff --git a/rules/jimtcl.make b/rules/jimtcl.make
> > > > > new file mode 100644
> > > > > index 000000000..16a5e2ae3
> > > > > --- /dev/null
> > > > > +++ b/rules/jimtcl.make
> > > > > @@ -0,0 +1,77 @@
> > > > > +# -*-makefile-*-
> > > > > +#
> > > > > +# Copyright (C) 2018 by Ladislav Michl <ladis@linux-mips.org>
> > > > > +#
> > > > > +# See CREDITS for details about who has contributed to this project.
> > > > > +#
> > > > > +# For further information about the PTXdist project and license conditions
> > > > > +# see the README file.
> > > > > +#
> > > > > +
> > > > > +#
> > > > > +# We provide this package
> > > > > +#
> > > > > +PACKAGES-$(PTXCONF_JIMTCL) += jimtcl
> > > > > +
> > > > > +#
> > > > > +# Paths and names
> > > > > +#
> > > > > +JIMTCL_VERSION	:= 0.78
> > > > > +JIMTCL_MD5	:= bde9021d78a77fe28e1bbc423142ab23
> > > > > +JIMTCL		:= jimtcl-$(JIMTCL_VERSION)
> > > > > +JIMTCL_SUFFIX	:= tar.xz
> > > > > +JIMTCL_URL	:= http://repo.or.cz/jimtcl.git;tag=$(JIMTCL_VERSION)
> > > > > +JIMTCL_SOURCE	:= $(SRCDIR)/$(JIMTCL).$(JIMTCL_SUFFIX)
> > > > > +JIMTCL_DIR	:= $(BUILDDIR)/$(JIMTCL)
> > > > > +JIMTCL_LICENSE	:= BSD-2-Clause 
> > > > > +
> > > > > +# ----------------------------------------------------------------------------
> > > > > +# Prepare
> > > > > +# ----------------------------------------------------------------------------
> > > > > +
> > > > > +#
> > > > > +# Package is not using autoconf but autosetup which is enough compatible...
> > > > > +#
> > > > > +JIMTCL_CONF_ENV		:= $(CROSS_ENV)
> > > > > +JIMTCL_CONF_TOOL	:= autoconf
> > > > > +JIMTCL_CONF_OPT		:= \
> > > > > +	$(CROSS_AUTOCONF_USR) \
> > > > > +	--shared
> > > > 
> > > > configure_helper.py shows a lot of options which are not present here.
> > > > Did you take a look at them?
> > > 
> > > Yes. Those are related to commit log message :) As Tcl is in staging and
> > > noone bothered I guess Tcl is not important to anyone and thus it does
> > > not make sense to implement features noobody asks for. So jimtcl is here
> > > only to make usb-nodeswitch happy which it does as it is.
> > 
> > It's not really autoconf, so you need to be careful which options are set,
> > but there is stuff that is autodetected, so that needs explicit options.
> > I think a lot of it is disabled by default, but at least lineedit and docs
> > should imho be disabled.
> 
> ("It's not really autoconf" is even stated in comment :)). I'll disable doc
> and create option for lineedit and it is usefull when used as tcl
> replacement.

I just noticed, that lineedit only seems to need a header from glibc, so
maybe we can just always enable this. Can you verify that this works
without extra dependencies?

But an option for readline may be useful with the corresponding dependency
for libreadline, but I'm not sure how this works at runtime.

> > Also, this packages seems to use tclsh at configure and compile time. We
> > need a host-system-tcl to make sure tclsh is installed. Check with
> >
> > type -P tclsh >/dev/null || ptxd_bailout "..."
> > 
> > I think.
> 
> Oh wait! I think we do not want to add more system dependencies.
> We have host-jimtcl for that purpose, I just have to make sure that
> bootstrapping works correctly as it first checks for system tcl
> or compiles bootstrap one if not found. Or do you think it is better
> to create host-system-tcl package?

I didn't know that. I prefer bootstrapping. The package didn't take long to
build, so that won't be a problem.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de