Re: [ptxdist] [PATCH v2 1/3] jimtcl: new package

[Ladislav Michl <ladis@linux-mips.org>]

On Thu, Sep 13, 2018 at 11:59:37AM +0200, Roland Hieber wrote:
> On Thu, Sep 13, 2018 at 10:32:26AM +0200, Ladislav Michl wrote:
> [...]
> > diff --git a/rules/jimtcl.make b/rules/jimtcl.make
> > new file mode 100644
> > index 000000000..16a5e2ae3
> > --- /dev/null
> > +++ b/rules/jimtcl.make
> > @@ -0,0 +1,77 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2018 by Ladislav Michl <ladis@linux-mips.org>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_JIMTCL) += jimtcl
> > +
> > +#
> > +# Paths and names
> > +#
> > +JIMTCL_VERSION	:= 0.78
> > +JIMTCL_MD5	:= bde9021d78a77fe28e1bbc423142ab23
> > +JIMTCL		:= jimtcl-$(JIMTCL_VERSION)
> > +JIMTCL_SUFFIX	:= tar.xz
> > +JIMTCL_URL	:= http://repo.or.cz/jimtcl.git;tag=$(JIMTCL_VERSION)
> > +JIMTCL_SOURCE	:= $(SRCDIR)/$(JIMTCL).$(JIMTCL_SUFFIX)
> > +JIMTCL_DIR	:= $(BUILDDIR)/$(JIMTCL)
> > +JIMTCL_LICENSE	:= BSD-2-Clause 
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +#
> > +# Package is not using autoconf but autosetup which is enough compatible...
> > +#
> > +JIMTCL_CONF_ENV		:= $(CROSS_ENV)
> > +JIMTCL_CONF_TOOL	:= autoconf
> > +JIMTCL_CONF_OPT		:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--shared
> 
> configure_helper.py shows a lot of options which are not present here.
> Did you take a look at them?

Yes. Those are related to commit log message :) As Tcl is in staging and
noone bothered I guess Tcl is not important to anyone and thus it does
not make sense to implement features noobody asks for. So jimtcl is here
only to make usb-nodeswitch happy which it does as it is.

> Also I noticed that Makefile.in sets
> 
>   CC = @CCACHE@ @CC@
>   CXX = @CCACHE@ @CXX@
> 
> which, in my case, becomes
> 
>   CC = ccache arm-v7a-linux-gnueabihf-gcc
>   CXX = ccache arm-v7a-linux-gnueabihf-g++
> 
> which is probably the reason why jimtcl.install fails because my ccache
> is not set up correctly (I did not enable it in ptxdist setup).

I did not enable it either. Which way does install fail in your case?

> I'm not sure how using ccache can be avoided without patching the build
> system.
> 
> There is another error happening here in jimtcl.install, but i'm not
> sure if it is related to the faulty ccache usage:
> 
>   jim-readdir.c: In function 'Jim_ReaddirCmd':
>   jim-readdir.c:72:5: error: unknown type name 'DIR'
>        DIR *dirPtr;
>        ^~~
>   make[1]: *** [jim-readdir.o] Error 1
>   Makefile:65: recipe for target 'jim-readdir.o' failed

I do not see this message, care to investigate more? Thank you.

>  - Roland
> 
> > +
> > +# ----------------------------------------------------------------------------
> > +# Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/jimtcl.install:
> > +	@$(call targetinfo)
> > +	@$(call world/install, JIMTCL)
> > +	@ln -sf libjim.so.$(JIMTCL_VERSION) $(JIMTCL_PKGDIR)/usr/lib/libjim.so
> > +	@$(call touch)
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/jimtcl.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, jimtcl)
> > +	@$(call install_fixup, jimtcl, PRIORITY, optional)
> > +	@$(call install_fixup, jimtcl, SECTION, base)
> > +	@$(call install_fixup, jimtcl, AUTHOR, "Ladislav Michl <ladis@linux-mips.org>")
> > +	@$(call install_fixup, jimtcl, DESCRIPTION, \
> > +		"A small footprint implementation of the Tcl programming language")
> > +
> > +ifdef PTXCONF_JIMTCL_SHELL
> > +	@$(call install_copy, jimtcl, 0, 0, 0755, -, /usr/bin/jimsh)
> > +ifdef PTXCONF_JIMTCL_SYMLINK
> > +	@$(call install_link, jimtcl, jimsh, /usr/bin/tclsh)
> > +endif
> > +endif
> > +	@$(call install_lib, jimtcl, 0, 0, 0644, libjim)
> > +
> > +	@$(call install_finish, jimtcl)
> > +
> > +	@$(call touch)
> > +
> > +# vim: syntax=make
> > -- 
> > 2.19.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> 
> -- 
> Roland Hieber                     | r.hieber@pengutronix.de     |
> Pengutronix e.K.                  | https://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de