mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 3/3] usb_modeswitch: link dispatcher against JimTcl
Date: Wed, 12 Sep 2018 15:07:50 +0200	[thread overview]
Message-ID: <20180912130750.GA31109@lenoch> (raw)
In-Reply-To: <20180912082938.GD12132@lenoch>

On Wed, Sep 12, 2018 at 10:29:39AM +0200, Ladislav Michl wrote:
> diff --git a/rules/usb-modeswitch.in b/rules/usb-modeswitch.in
> index 754e19304..037169150 100644
> --- a/rules/usb-modeswitch.in
> +++ b/rules/usb-modeswitch.in
> @@ -4,7 +4,8 @@ menuconfig USB_MODESWITCH
>  	tristate
>  	prompt "usb-modeswitch                "
>  	select LIBUSB
> -	select TCL if (USB_MODESWITCH_UDEV_HELPER || USB_MODESWITCH_SYSTEMD_UNIT) && RUNTIME
> +	select JIMTCL if (USB_MODESWITCH_UDEV_HELPER || USB_MODESWITCH_SYSTEMD_UNIT) && RUNTIME

This should actually be:
select JIMTCL if USB_MODESWITCH_UDEV_HELPER || USB_MODESWITCH_SYSTEMD_UNIT
as it is compile time dependency. I'll wait for comments before v3.

> +	select HOST_JIMTCL if (USB_MODESWITCH_UDEV_HELPER || USB_MODESWITCH_SYSTEMD_UNIT)
>  	help
>  	  USB_ModeSwitch is (surprise!) a mode switching tool
>  	  for controlling 'multi-mode' USB devices.
> @@ -15,13 +16,11 @@ config USB_MODESWITCH_UDEV_HELPER
>  	bool "install udev helper"
>  	default y
>  	depends on UDEV
> -	depends on STAGING
>  
>  config USB_MODESWITCH_SYSTEMD_UNIT
>  	bool "install systemd unit file"
>  	default y
>  	depends on SYSTEMD
> -	depends on STAGING
>  
>  endif
>  
> diff --git a/rules/usb-modeswitch.make b/rules/usb-modeswitch.make
> index 0f00e9c5c..4934d72c0 100644
> --- a/rules/usb-modeswitch.make
> +++ b/rules/usb-modeswitch.make
> @@ -33,11 +33,15 @@ USB_MODESWITCH_LICENSE	:= GPL-2.0-only
>  # autoconf
>  #
>  USB_MODESWITCH_CONF_TOOL	:= NO
> -USB_MODESWITCH_MAKE_ENV		:= $(CROSS_ENV)
> -USB_MODESWITCH_MAKE_OPT		:= $(CROSS_ENV_PROGS)
> +USB_MODESWITCH_MAKE_ENV		:= \
> +	$(CROSS_ENV) \
> +	HOST_TCL=$(PTXCONF_SYSROOT_HOST)/usr/bin/jimsh
> +USB_MODESWITCH_MAKE_OPT		:= \
> +	$(CROSS_ENV_PROGS) \
> +	shared
>  USB_MODESWITCH_INSTALL_OPT	:= \
>  	UDEVDIR=$(USB_MODESWITCH_PKGDIR)/usr/lib/udev \
> -	install
> +	install-shared
>  
>  # ----------------------------------------------------------------------------
>  # Install
> -- 
> 2.19.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2018-09-12 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12  8:26 [ptxdist] [PATCH v2 0/3] Update usb_modeswitch Ladislav Michl
2018-09-12  8:27 ` [ptxdist] [PATCH 1/3] jimtcl: new package Ladislav Michl
2018-09-12  8:29 ` [ptxdist] [PATCH v2 2/3] usb_modeswitch: version bump 2.5.1 -> 2.5.2 Ladislav Michl
2018-09-12  8:29 ` [ptxdist] [PATCH v2 3/3] usb_modeswitch: link dispatcher against JimTcl Ladislav Michl
2018-09-12 13:07   ` Ladislav Michl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912130750.GA31109@lenoch \
    --to=ladis@linux-mips.org \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox