From: Ladislav Michl <ladis@linux-mips.org>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: Josua Dietze <usb_admin@draisberghof.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 0/2] Update usb_modeswitch
Date: Tue, 11 Sep 2018 11:48:09 +0200 [thread overview]
Message-ID: <20180911094809.GA30164@lenoch> (raw)
In-Reply-To: <20180907102011.wz3f2kk63mev7rf7@pengutronix.de>
On Fri, Sep 07, 2018 at 12:20:11PM +0200, Michael Olbrich wrote:
> On Fri, Sep 07, 2018 at 12:08:36PM +0200, Ladislav Michl wrote:
> > Hi,
> >
> > although this little patchset does not completely solve all issues
> > with usb_modeswitch, it is worth applying anyway.
> >
> > This package was moved to staging with Tcl it depends on. However
> > it is possible to use builtin Tcl interpreter and link helper
> > script statically with it. That avoids Tcl dependency and decreases
> > size footprint.
> >
> > Unfortunately above solution fails for some configurations and a bug
> > was reported:
> > http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2813
> > While it is possible to add local patch to solve this, I'm not sure
> > it is worth doing as it is over ~300k lines and quite difficult to
> > review. So I'd just suggest waiting for new upstream version with
> > a fix. In case anyone prefers patching package locally, please let me
> > know and I'll resend with patch.
>
> Please add this to the commit message so others can find this in the git
> history if they run into the same issue.
> There is no upstream git or similar, that we could point to, right?
So far it seems the preferred (and already implemented) solution would
be to add jimtcl package and make usb-modeswitch to link against it.
After all Debian does the same. Side benefit is having small Tcl
interpreter which fits PTXdist more than full-blown Tcl. I'll send v2
after some more testing.
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2018-09-11 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 10:08 Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 2/2] usb_modeswitch: version bump 2.5.1 -> 2.5.2 Ladislav Michl
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
2018-09-07 10:53 ` Ladislav Michl
2018-09-11 9:48 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911094809.GA30164@lenoch \
--to=ladis@linux-mips.org \
--cc=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=usb_admin@draisberghof.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox