* [ptxdist] [PATCH 0/2] Update usb_modeswitch
@ 2018-09-07 10:08 Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl Ladislav Michl
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ladislav Michl @ 2018-09-07 10:08 UTC (permalink / raw)
To: ptxdist
Hi,
although this little patchset does not completely solve all issues
with usb_modeswitch, it is worth applying anyway.
This package was moved to staging with Tcl it depends on. However
it is possible to use builtin Tcl interpreter and link helper
script statically with it. That avoids Tcl dependency and decreases
size footprint.
Unfortunately above solution fails for some configurations and a bug
was reported:
http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2813
While it is possible to add local patch to solve this, I'm not sure
it is worth doing as it is over ~300k lines and quite difficult to
review. So I'd just suggest waiting for new upstream version with
a fix. In case anyone prefers patching package locally, please let me
know and I'll resend with patch.
Thank you,
ladis
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl
2018-09-07 10:08 [ptxdist] [PATCH 0/2] Update usb_modeswitch Ladislav Michl
@ 2018-09-07 10:09 ` Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 2/2] usb_modeswitch: version bump 2.5.1 -> 2.5.2 Ladislav Michl
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
2 siblings, 0 replies; 6+ messages in thread
From: Ladislav Michl @ 2018-09-07 10:09 UTC (permalink / raw)
To: ptxdist
As Tcl moved to staging, statically link dispatcher script with builtin
JimTcl interpreter.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
rules/usb-modeswitch.in | 3 ---
rules/usb-modeswitch.make | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/rules/usb-modeswitch.in b/rules/usb-modeswitch.in
index 754e19304..639fd44f0 100644
--- a/rules/usb-modeswitch.in
+++ b/rules/usb-modeswitch.in
@@ -4,7 +4,6 @@ menuconfig USB_MODESWITCH
tristate
prompt "usb-modeswitch "
select LIBUSB
- select TCL if (USB_MODESWITCH_UDEV_HELPER || USB_MODESWITCH_SYSTEMD_UNIT) && RUNTIME
help
USB_ModeSwitch is (surprise!) a mode switching tool
for controlling 'multi-mode' USB devices.
@@ -15,13 +14,11 @@ config USB_MODESWITCH_UDEV_HELPER
bool "install udev helper"
default y
depends on UDEV
- depends on STAGING
config USB_MODESWITCH_SYSTEMD_UNIT
bool "install systemd unit file"
default y
depends on SYSTEMD
- depends on STAGING
endif
diff --git a/rules/usb-modeswitch.make b/rules/usb-modeswitch.make
index 193a6eede..6b63af22e 100644
--- a/rules/usb-modeswitch.make
+++ b/rules/usb-modeswitch.make
@@ -37,7 +37,7 @@ USB_MODESWITCH_MAKE_ENV := $(CROSS_ENV)
USB_MODESWITCH_MAKE_OPT := $(CROSS_ENV_PROGS)
USB_MODESWITCH_INSTALL_OPT := \
UDEVDIR=$(USB_MODESWITCH_PKGDIR)/usr/lib/udev \
- install
+ install-static
# ----------------------------------------------------------------------------
# Install
--
2.19.0.rc2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ptxdist] [PATCH 2/2] usb_modeswitch: version bump 2.5.1 -> 2.5.2
2018-09-07 10:08 [ptxdist] [PATCH 0/2] Update usb_modeswitch Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl Ladislav Michl
@ 2018-09-07 10:09 ` Ladislav Michl
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
2 siblings, 0 replies; 6+ messages in thread
From: Ladislav Michl @ 2018-09-07 10:09 UTC (permalink / raw)
To: ptxdist
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
rules/usb-modeswitch.make | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/rules/usb-modeswitch.make b/rules/usb-modeswitch.make
index 6b63af22e..37ffc8e11 100644
--- a/rules/usb-modeswitch.make
+++ b/rules/usb-modeswitch.make
@@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_USB_MODESWITCH) += usb-modeswitch
#
# Paths and names
#
-USB_MODESWITCH_VERSION := 2.5.1
-USB_MODESWITCH_MD5 := 7e6435a2afe7aed8574fe59cf09a3503
+USB_MODESWITCH_VERSION := 2.5.2
+USB_MODESWITCH_MD5 := 16b9a8efa1bf8fbd7d5612757eae4f26
USB_MODESWITCH := usb-modeswitch-$(USB_MODESWITCH_VERSION)
USB_MODESWITCH_SUFFIX := tar.bz2
USB_MODESWITCH_URL := http://www.draisberghof.de/usb_modeswitch/$(USB_MODESWITCH).$(USB_MODESWITCH_SUFFIX)
--
2.19.0.rc2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/2] Update usb_modeswitch
2018-09-07 10:08 [ptxdist] [PATCH 0/2] Update usb_modeswitch Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 2/2] usb_modeswitch: version bump 2.5.1 -> 2.5.2 Ladislav Michl
@ 2018-09-07 10:20 ` Michael Olbrich
2018-09-07 10:53 ` Ladislav Michl
2018-09-11 9:48 ` Ladislav Michl
2 siblings, 2 replies; 6+ messages in thread
From: Michael Olbrich @ 2018-09-07 10:20 UTC (permalink / raw)
To: ptxdist
On Fri, Sep 07, 2018 at 12:08:36PM +0200, Ladislav Michl wrote:
> Hi,
>
> although this little patchset does not completely solve all issues
> with usb_modeswitch, it is worth applying anyway.
>
> This package was moved to staging with Tcl it depends on. However
> it is possible to use builtin Tcl interpreter and link helper
> script statically with it. That avoids Tcl dependency and decreases
> size footprint.
>
> Unfortunately above solution fails for some configurations and a bug
> was reported:
> http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2813
> While it is possible to add local patch to solve this, I'm not sure
> it is worth doing as it is over ~300k lines and quite difficult to
> review. So I'd just suggest waiting for new upstream version with
> a fix. In case anyone prefers patching package locally, please let me
> know and I'll resend with patch.
Please add this to the commit message so others can find this in the git
history if they run into the same issue.
There is no upstream git or similar, that we could point to, right?
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/2] Update usb_modeswitch
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
@ 2018-09-07 10:53 ` Ladislav Michl
2018-09-11 9:48 ` Ladislav Michl
1 sibling, 0 replies; 6+ messages in thread
From: Ladislav Michl @ 2018-09-07 10:53 UTC (permalink / raw)
To: ptxdist
On Fri, Sep 07, 2018 at 12:20:11PM +0200, Michael Olbrich wrote:
> On Fri, Sep 07, 2018 at 12:08:36PM +0200, Ladislav Michl wrote:
> > Hi,
> >
> > although this little patchset does not completely solve all issues
> > with usb_modeswitch, it is worth applying anyway.
> >
> > This package was moved to staging with Tcl it depends on. However
> > it is possible to use builtin Tcl interpreter and link helper
> > script statically with it. That avoids Tcl dependency and decreases
> > size footprint.
> >
> > Unfortunately above solution fails for some configurations and a bug
> > was reported:
> > http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2813
> > While it is possible to add local patch to solve this, I'm not sure
> > it is worth doing as it is over ~300k lines and quite difficult to
> > review. So I'd just suggest waiting for new upstream version with
> > a fix. In case anyone prefers patching package locally, please let me
> > know and I'll resend with patch.
>
> Please add this to the commit message so others can find this in the git
> history if they run into the same issue.
Will do (perhaps after some waiting for Josh's answer)
> There is no upstream git or similar, that we could point to, right?
I do not think so. Also there's only web phorum, no mailing list.
> Michael
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH 0/2] Update usb_modeswitch
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
2018-09-07 10:53 ` Ladislav Michl
@ 2018-09-11 9:48 ` Ladislav Michl
1 sibling, 0 replies; 6+ messages in thread
From: Ladislav Michl @ 2018-09-11 9:48 UTC (permalink / raw)
To: Michael Olbrich; +Cc: Josua Dietze, ptxdist
On Fri, Sep 07, 2018 at 12:20:11PM +0200, Michael Olbrich wrote:
> On Fri, Sep 07, 2018 at 12:08:36PM +0200, Ladislav Michl wrote:
> > Hi,
> >
> > although this little patchset does not completely solve all issues
> > with usb_modeswitch, it is worth applying anyway.
> >
> > This package was moved to staging with Tcl it depends on. However
> > it is possible to use builtin Tcl interpreter and link helper
> > script statically with it. That avoids Tcl dependency and decreases
> > size footprint.
> >
> > Unfortunately above solution fails for some configurations and a bug
> > was reported:
> > http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2813
> > While it is possible to add local patch to solve this, I'm not sure
> > it is worth doing as it is over ~300k lines and quite difficult to
> > review. So I'd just suggest waiting for new upstream version with
> > a fix. In case anyone prefers patching package locally, please let me
> > know and I'll resend with patch.
>
> Please add this to the commit message so others can find this in the git
> history if they run into the same issue.
> There is no upstream git or similar, that we could point to, right?
So far it seems the preferred (and already implemented) solution would
be to add jimtcl package and make usb-modeswitch to link against it.
After all Debian does the same. Side benefit is having small Tcl
interpreter which fits PTXdist more than full-blown Tcl. I'll send v2
after some more testing.
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-11 9:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 10:08 [ptxdist] [PATCH 0/2] Update usb_modeswitch Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 1/2] usb_modeswitch: use builtin JimTcl Ladislav Michl
2018-09-07 10:09 ` [ptxdist] [PATCH 2/2] usb_modeswitch: version bump 2.5.1 -> 2.5.2 Ladislav Michl
2018-09-07 10:20 ` [ptxdist] [PATCH 0/2] Update usb_modeswitch Michael Olbrich
2018-09-07 10:53 ` Ladislav Michl
2018-09-11 9:48 ` Ladislav Michl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox