Re: [ptxdist] [PATCH v2 01/23] xorg-font-ttf-android: isolate from xorg-fonts

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Sep 04, 2018 at 10:47:56AM +0000, Baeuerle, Florian wrote:
> Am Dienstag, den 04.09.2018, 11:34 +0200 schrieb Michael Olbrich:
> > >  
> > >  # ----------------------------------------------------------------------------
> > >  # Compile
> > > @@ -55,6 +46,18 @@ $(STATEDIR)/xorg-font-ttf-android.compile:
> > >  
> > >  $(STATEDIR)/xorg-font-ttf-android.install:
> > >  	@$(call targetinfo)
> > > +
> > > +	@rm -rf $(XORG_FONT_TTF_ANDROID_PKGDIR)
> > > +	@mkdir -p $(XORG_FONT_TTF_ANDROID_FONTPKGDIR)
> > > +	@find $(XORG_FONT_TTF_ANDROID_DIR) \
> > > +		-name "*.ttf" \
> > > +		| \
> > > +		while read file; do \
> > > +		install -m 644 $${file} $(XORG_FONT_TTF_ANDROID_FONTPKGDIR); \
> > > +	done
> > > +	@mkfontscale $(XORG_FONT_TTF_ANDROID_FONTPKGDIR)
> > > +	@mkfontdir $(XORG_FONT_TTF_ANDROID_FONTPKGDIR)
> > 
> > This adds a lot of boiler plate for all packages. I'd like to see this here:
> > 
> > 	@$(call world/install-fonts, XORG_FONT_TTF_ANDROID, *.ttf)
> 
> I would have also preferred that, *but* if you look at xorg-font-ttf-noto, the
> original package author did not want to just install every font present in the
> archive. I did not question that decision and instead concluded, that such a
> macro cannot easily do the job for every font package.
> 
> So should I
> 
> a) reconsider the original author's decision

Do this. I'm the original author :-). It's just one extra font anyways.
My plan is to extend the make much like install_glob. I don't want to ask
you to do that, because that will be a lot more complex.
For the packages that you have converted, the simple version will be
enough.

Michael

> or
> b) add the boilerplate to the noto package and use the macro everywhere else
> 
> I know the current approach sucks, so much that I edited all the makefiles with
> sed.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de