Re: [ptxdist] [PATCH] minicoredumper: New package

[Roland Hieber <r.hieber@pengutronix.de>]

On Tue, Aug 14, 2018 at 12:38:38PM +0000, Denis OSTERLAND wrote:
> Am Dienstag, den 14.08.2018, 13:02 +0200 schrieb Uwe Kleine-König:
> > On Tue, Aug 14, 2018 at 12:14:20PM +0200, Roland Hieber wrote:
> > > On Tue, Aug 14, 2018 at 11:57:44AM +0200, Roland Hieber wrote:
> > > > On Mon, Aug 13, 2018 at 04:57:48PM +0200, Uwe Kleine-König wrote:
> > > > > +$(STATEDIR)/minicoredumper.extract: $(STATEDIR)/autogen-tools
> > > > Interesting, I didn't know this one yet. Apparently it generates a
> > > > configure script when only a configure.ac is present?
> > > Hm. On second read of ptxdist/rules/pre/autogen.make, this should be a
> > > no-op as long as no patches/$(MINICOREDUMPER)/autogen.sh is present,
> > > which is the case here. Does it work for you as intended?
> > Yes, works as intended (i.e. the package builds fine) :-)
> > 
> > I used that not because I consider it sensible but because that's what
> > ptxdist newpackage did for me.
> > 
> > Best regards
> > Uwe
> 
> I would expect a link in patch folder instead of prepare section:
> patches/minicoredumper-2.0.1/autogen.sh -> ../autogen.sh

Yes, that is the usual way to do it, the extract.post stage will find
patches/minicoredumper-2.0.1/autogen.sh and execute it in the package
directory to generate configure from configure.ac.

In this case, configure was already present in the tarball, so nothing
of these solutions were needed.

 - Roland


-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de